{"id":1992881,"url":"http://patchwork.ozlabs.org/api/patches/1992881/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-14-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20241004163042.85922-14-philmd@linaro.org>","list_archive_url":null,"date":"2024-10-04T16:30:29","name":"[v2,13/25] target/sh4: Use explicit little-endian LD/ST API","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1c068d62bd79eb01a5cde51705074b37c6944057","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-14-philmd@linaro.org/mbox/","series":[{"id":426623,"url":"http://patchwork.ozlabs.org/api/series/426623/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=426623","date":"2024-10-04T16:30:18","name":"misc: Use explicit endian LD/ST API","version":2,"mbox":"http://patchwork.ozlabs.org/series/426623/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1992881/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1992881/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=WupiJwVH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XKvJr0pfkz1xv2\n\tfor ; Sat, 5 Oct 2024 02:34:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swlFt-0002Y5-IP; Fri, 04 Oct 2024 12:34:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1swlFo-0001vu-9d\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:34:08 -0400","from mail-lf1-x134.google.com ([2a00:1450:4864:20::134])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1swlFl-00061M-SK\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:34:08 -0400","by mail-lf1-x134.google.com with SMTP id\n 2adb3069b0e04-5398a26b64fso2386005e87.3\n for ; Fri, 04 Oct 2024 09:34:04 -0700 (PDT)","from localhost.localdomain ([91.223.100.150])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-539b0025812sm766e87.307.2024.10.04.09.33.56\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 04 Oct 2024 09:34:01 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728059643; x=1728664443; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=uKaUzar4CyW9b+VidODguwjQPRzdI1IQfcANAiFe0bI=;\n b=WupiJwVHeCXB6aPmjNqYTZQbwDvic76JnBZYSNwJcF6NcAnh5iuWAJYBTnkXvvT1/u\n 1LKwvMKpx5NG+nkDD3hIT9ZhdNLM4Ynd5LkvF0VuIpzDmWGEBTmCvuCq89h+cWAGtSBu\n pl7dPt2xRYfNE3HfjbIbThhcWzicmn0U5rtFys5Tt5Sbpfuka87E3dCO/v19YoC9K0Rr\n WHX5RvUtRad2mIaM/U9VV7elCk05c5urP93tZezjGLuijrUVJX+aqF4T/n/EhmJ+LeWq\n TCYu6wA2z2ptkWwQQgntaXGr1/TFF989nVW438YvhK+nRfr0YhKKKWgOdy2I5rT5csx5\n LKng==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728059643; x=1728664443;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=uKaUzar4CyW9b+VidODguwjQPRzdI1IQfcANAiFe0bI=;\n b=K2OBCgWA2Qs6R/VxyGikl52Xs4yZIuilad0q4PVSgyiHu3gp0XKQlI6JYE8MStV3xw\n J4swRm/UG1ojC5edXaamaU7gGVZzzIldsf9nqpzFEQKOSYSfWCPPdBOiWd/+p/Ukqdi6\n +px1nAxnwXS4qEpCGCZPg5lnh8874H7+oQ5KKqT670b1lx0xWrE+EKboGIf/QZXP0DEO\n IBCRdU/62qXLaY0aic+0ZQz+2eUqjMYbsNaFYH4nLJh1ozanfoYlhe0V5Qq4l5YIHREr\n ULEn+zE8uWOXl9H5tQFAjFV07AkYWpIL/xuLZaM2PvMdGVypU7gmUEQoXV92vJNOGL/q\n XF3g==","X-Gm-Message-State":"AOJu0YwwynnQ9XOpSJczXScnMZw4VY7R47kh6Wfa0o/KNJKiWLp0LkhE\n a9510h1QnC5d7RPor9Pcep5Se/JdqBebMQ8afuCvUK6FBVWi4cXfzCxPr04rWhzuJ2jzwwJS1DG\n nZia4zw==","X-Google-Smtp-Source":"\n AGHT+IFuVaVw2FeEj02CoP4GD4TKrUCRAAI2yJWWIn245ZaDyKf2L+98Bsw33FI6NNiG3GQCT3c70w==","X-Received":"by 2002:a05:6512:318e:b0:536:7cfb:6998 with SMTP id\n 2adb3069b0e04-539ab89e01bmr2589237e87.35.1728059642951;\n Fri, 04 Oct 2024 09:34:02 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Richard Henderson ,\n Pierrick Bouvier , qemu-ppc@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v2 13/25] target/sh4: Use explicit little-endian LD/ST API","Date":"Fri, 4 Oct 2024 13:30:29 -0300","Message-ID":"<20241004163042.85922-14-philmd@linaro.org>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241004163042.85922-1-philmd@linaro.org>","References":"<20241004163042.85922-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::134;\n envelope-from=philmd@linaro.org; helo=mail-lf1-x134.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Since commit 73ceb12960e (\"Remove the unused sh4eb target\")\nwe only build the SH4 architecture for little endianness.\nDirectly use the little-endian LD/ST API.\n\nMechanical change using:\n\n $ end=le; \\\n for acc in uw w l q tul; do \\\n sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n $(git grep -wlE '(ld|st)t?u?[wlq]_p' target/sh4/); \\\n done\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/sh4/gdbstub.c | 36 ++++++++++++++++++------------------\n 1 file changed, 18 insertions(+), 18 deletions(-)","diff":"diff --git a/target/sh4/gdbstub.c b/target/sh4/gdbstub.c\nindex 75926d4e049..194be1d5db3 100644\n--- a/target/sh4/gdbstub.c\n+++ b/target/sh4/gdbstub.c\n@@ -80,59 +80,59 @@ int superh_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n switch (n) {\n case 0 ... 7:\n if ((env->sr & (1u << SR_MD)) && (env->sr & (1u << SR_RB))) {\n- env->gregs[n + 16] = ldl_p(mem_buf);\n+ env->gregs[n + 16] = ldl_le_p(mem_buf);\n } else {\n- env->gregs[n] = ldl_p(mem_buf);\n+ env->gregs[n] = ldl_le_p(mem_buf);\n }\n break;\n case 8 ... 15:\n- env->gregs[n] = ldl_p(mem_buf);\n+ env->gregs[n] = ldl_le_p(mem_buf);\n break;\n case 16:\n- env->pc = ldl_p(mem_buf);\n+ env->pc = ldl_le_p(mem_buf);\n break;\n case 17:\n- env->pr = ldl_p(mem_buf);\n+ env->pr = ldl_le_p(mem_buf);\n break;\n case 18:\n- env->gbr = ldl_p(mem_buf);\n+ env->gbr = ldl_le_p(mem_buf);\n break;\n case 19:\n- env->vbr = ldl_p(mem_buf);\n+ env->vbr = ldl_le_p(mem_buf);\n break;\n case 20:\n- env->mach = ldl_p(mem_buf);\n+ env->mach = ldl_le_p(mem_buf);\n break;\n case 21:\n- env->macl = ldl_p(mem_buf);\n+ env->macl = ldl_le_p(mem_buf);\n break;\n case 22:\n- cpu_write_sr(env, ldl_p(mem_buf));\n+ cpu_write_sr(env, ldl_le_p(mem_buf));\n break;\n case 23:\n- env->fpul = ldl_p(mem_buf);\n+ env->fpul = ldl_le_p(mem_buf);\n break;\n case 24:\n- env->fpscr = ldl_p(mem_buf);\n+ env->fpscr = ldl_le_p(mem_buf);\n break;\n case 25 ... 40:\n if (env->fpscr & FPSCR_FR) {\n- env->fregs[n - 9] = ldl_p(mem_buf);\n+ env->fregs[n - 9] = ldl_le_p(mem_buf);\n } else {\n- env->fregs[n - 25] = ldl_p(mem_buf);\n+ env->fregs[n - 25] = ldl_le_p(mem_buf);\n }\n break;\n case 41:\n- env->ssr = ldl_p(mem_buf);\n+ env->ssr = ldl_le_p(mem_buf);\n break;\n case 42:\n- env->spc = ldl_p(mem_buf);\n+ env->spc = ldl_le_p(mem_buf);\n break;\n case 43 ... 50:\n- env->gregs[n - 43] = ldl_p(mem_buf);\n+ env->gregs[n - 43] = ldl_le_p(mem_buf);\n break;\n case 51 ... 58:\n- env->gregs[n - (51 - 16)] = ldl_p(mem_buf);\n+ env->gregs[n - (51 - 16)] = ldl_le_p(mem_buf);\n break;\n default:\n return 0;\n","prefixes":["v2","13/25"]}