{"id":1992874,"url":"http://patchwork.ozlabs.org/api/patches/1992874/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-13-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20241004163042.85922-13-philmd@linaro.org>","list_archive_url":null,"date":"2024-10-04T16:30:28","name":"[v2,12/25] target/loongarch: Use explicit little-endian LD/ST API","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f0ca8fe79c0a2a2351fefb07488300563e8420d0","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-13-philmd@linaro.org/mbox/","series":[{"id":426623,"url":"http://patchwork.ozlabs.org/api/series/426623/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=426623","date":"2024-10-04T16:30:18","name":"misc: Use explicit endian LD/ST API","version":2,"mbox":"http://patchwork.ozlabs.org/series/426623/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1992874/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1992874/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ZGrzTCf0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XKvJV4KVYz1xtH\n\tfor ; Sat, 5 Oct 2024 02:34:18 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swlFl-0001hr-Up; Fri, 04 Oct 2024 12:34:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1swlFX-0000Q2-3f\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:33:51 -0400","from mail-lf1-x130.google.com ([2a00:1450:4864:20::130])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1swlFU-0005yj-Ph\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:33:50 -0400","by mail-lf1-x130.google.com with SMTP id\n 2adb3069b0e04-5399041167cso4063653e87.0\n for ; Fri, 04 Oct 2024 09:33:48 -0700 (PDT)","from localhost.localdomain ([91.223.100.150])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-539afec8430sm2064e87.98.2024.10.04.09.33.40\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 04 Oct 2024 09:33:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728059627; x=1728664427; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=hLzg4uMG2cx+IKbaUwzfii1q1L/0Wc5xbNn8QzHBma0=;\n b=ZGrzTCf0aCI/SK37IHwhcqfSdUL0BqiYgZlmmGh9E5PRuKKQtMsCFhpfEPhnJKOZpM\n vqxW/IMXXxRX+SJjfAvBdyT1ahHT+jgYymKp1oh8BtS7SfuUy0XMCWjGBULu+CG1Hhge\n PDEwk6NO8dZnWz7xQIc2KsgOXAxCfDPvWL9fIVvEoFp7DuXZ9ki0FhNvTppASATzKJCq\n cx0PWWffM29TZ10u9jJ+ZOWgMR1VD/ezvd86tZHdPwUZ5PSWQvtNICCQgLW4EM+U2Ys7\n gu45omNUfAzy0hvL/4Lgw3qyMf4MfMhq0sNqcYrW2EV8c6cZGEDHwf5iRcBgP2Lh+K3N\n 8HTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728059627; x=1728664427;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=hLzg4uMG2cx+IKbaUwzfii1q1L/0Wc5xbNn8QzHBma0=;\n b=hzyT9Dox2rNDs/86IFgbuKDb16Jlq8UrqDK0aVT+7r44dQ0bjCLRG5pDdaXnjROOZT\n kL/H25iZd4vk4zHodQhII8uQWKomO/j3ibYlRr1kDnFLw1lF+stzSfY3VNE63nm2qAHv\n yNr1AxQAc9lDocxle7fZ6ivZ+bNOUQsojkyl2s67WDo4Ew/wx0otzdIVYEy1JvJPqTpz\n PREp++uHnP2bYg5bRC1CarbbcpJacLw7Wgf3cBrdsljSWkTNpunt6Bc37kSN/yu+nIr+\n +xXhEnX16rcuy8rpc/HYVqSR6ncb7CbdbOiZj3Pv2bg/Oxh6LBzwPWRiTEYnVhavJptG\n Pchw==","X-Gm-Message-State":"AOJu0Yw2QCSJoiBAXZka+7BJzsvlICd9CTUtk9r3JnQcJ1MsMIHC/VIA\n yifvJQhvSeI8FkHozMibtXu04X6hVIMQtka1BlbsXhV64MVGJa0f8HaKu0evSNp48yl4lwW3fd8\n 1qBj5lQ==","X-Google-Smtp-Source":"\n AGHT+IEuSAOZSCN26tBePII+5E9mmDeltRZqJrGv08/GBrPxmSMNYn/k2BT5kWYju5saHekA9/bXHQ==","X-Received":"by 2002:a05:6512:3b98:b0:539:9ee4:baab with SMTP id\n 2adb3069b0e04-539ab87dcbfmr3297739e87.30.1728059626757;\n Fri, 04 Oct 2024 09:33:46 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Richard Henderson ,\n Pierrick Bouvier , qemu-ppc@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v2 12/25] target/loongarch: Use explicit little-endian LD/ST\n API","Date":"Fri, 4 Oct 2024 13:30:28 -0300","Message-ID":"<20241004163042.85922-13-philmd@linaro.org>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241004163042.85922-1-philmd@linaro.org>","References":"<20241004163042.85922-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::130;\n envelope-from=philmd@linaro.org; helo=mail-lf1-x130.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The LoongArch architecture uses little endianness. Directly\nuse the little-endian LD/ST API.\n\nMechanical change using:\n\n $ end=le; \\\n for acc in uw w l q tul; do \\\n sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n $(git grep -wlE '(ld|st)t?u?[wlq]_p' target/loongarch/); \\\n done\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/loongarch/gdbstub.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/target/loongarch/gdbstub.c b/target/loongarch/gdbstub.c\nindex 3a03cf9cba9..dafa4feb75d 100644\n--- a/target/loongarch/gdbstub.c\n+++ b/target/loongarch/gdbstub.c\n@@ -67,10 +67,10 @@ int loongarch_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n int length = 0;\n \n if (is_la64(env)) {\n- tmp = ldq_p(mem_buf);\n+ tmp = ldq_le_p(mem_buf);\n read_length = 8;\n } else {\n- tmp = ldl_p(mem_buf);\n+ tmp = ldl_le_p(mem_buf);\n read_length = 4;\n }\n \n@@ -106,13 +106,13 @@ static int loongarch_gdb_set_fpu(CPUState *cs, uint8_t *mem_buf, int n)\n int length = 0;\n \n if (0 <= n && n < 32) {\n- env->fpr[n].vreg.D(0) = ldq_p(mem_buf);\n+ env->fpr[n].vreg.D(0) = ldq_le_p(mem_buf);\n length = 8;\n } else if (32 <= n && n < 40) {\n env->cf[n - 32] = ldub_p(mem_buf);\n length = 1;\n } else if (n == 40) {\n- env->fcsr0 = ldl_p(mem_buf);\n+ env->fcsr0 = ldl_le_p(mem_buf);\n length = 4;\n }\n return length;\n","prefixes":["v2","12/25"]}