{"id":1992870,"url":"http://patchwork.ozlabs.org/api/patches/1992870/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-11-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20241004163042.85922-11-philmd@linaro.org>","list_archive_url":null,"date":"2024-10-04T16:30:26","name":"[v2,10/25] target/avr: Use explicit little-endian LD/ST API","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2dd79b3c19e80a1d12ffbde8eae068785fd295b5","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-11-philmd@linaro.org/mbox/","series":[{"id":426623,"url":"http://patchwork.ozlabs.org/api/series/426623/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=426623","date":"2024-10-04T16:30:18","name":"misc: Use explicit endian LD/ST API","version":2,"mbox":"http://patchwork.ozlabs.org/series/426623/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1992870/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1992870/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=FSX6BOSJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XKvJG21Pjz1xtH\n\tfor ; Sat, 5 Oct 2024 02:34:06 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swlFX-0000Dg-Ov; Fri, 04 Oct 2024 12:33:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1swlF1-0007pc-O2\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:33:23 -0400","from mail-lj1-x236.google.com ([2a00:1450:4864:20::236])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1swlEz-0005rj-Jm\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:33:19 -0400","by mail-lj1-x236.google.com with SMTP id\n 38308e7fff4ca-2fad5024b8dso28325471fa.1\n for ; Fri, 04 Oct 2024 09:33:17 -0700 (PDT)","from localhost.localdomain ([91.223.100.150])\n by smtp.gmail.com with ESMTPSA id\n 38308e7fff4ca-2faf9ac461fsm207201fa.47.2024.10.04.09.33.10\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 04 Oct 2024 09:33:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728059595; x=1728664395; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Sos7CbirHso2UkebMmuBOYVoWuS2tFtvh+AVgSe77UQ=;\n b=FSX6BOSJB9wZcloMRiCyaAT97UBbQi1NKzy9WJdy9whe6In7PtuKCv1qdeb4TH87Ig\n X2NrfrL0fXFcwNYyOxPBR1fxFvmkVmPo9Wr5eRKlA+ckacRSCVoO22gn9jVCK5ZH6CcM\n 2JF2RJMhFD0BBo3WXwX4f1ylheyk8SjXQ6On1ygaR2/lTw5QoqO6LcR0ghvwGH8UkBop\n wdZvYYQCbRf7s7+RvZ8krEKvCInILR89VxXt2X5otiTowTsBYh44mzoUH13DdCpYNzck\n X/O9bFAqBXFWNvSmFLqABPoncYLPlsHCPi5DtOW1pkHafP84W1hWrXA9if0mZTLo6piN\n KaRA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728059595; x=1728664395;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Sos7CbirHso2UkebMmuBOYVoWuS2tFtvh+AVgSe77UQ=;\n b=FBFhfKMEEGRqDjLF6qE9gPhAuB3grGwoyV5ujSYnIP/hvVybCa/xLQ9PJp92lGGOch\n uZB+n+NQT+hEmY+AAdx9lY5dSqUbdXSRWsMQxCgSAbbcq4NEyIkIZwLpozVzduTbp62y\n UD+P67TQSG5HWDl2PZn5V4zu94Qj6aU3Q19YTBbFZa3r6rPWvvPUchFUVMfGJtFSivrY\n jLq4HDCvbl0DvOU1oYPSLby7b3kB5/vHElVvdzXuCIta9zST/3Rp1BYT0dd4oeX3Bqmc\n GBMwxLpYOfks8bqBOv/8jeMJI3x80CifjcLE9xtoQTDaFpsVkTrryuEEl3WHDXBcqdz/\n ng6w==","X-Gm-Message-State":"AOJu0Yyih1Qsb1xUGd1RmgJEXve5s3dXc70kEK3ZUrL3LriCZFClN2mv\n 9gXaL0UV2+GZzPT1BiReS70Xy8T0q+c1WhJsmlYGUpawCw0hL5QaQv77MjCveoqSKuljENAGnXB\n aldrNwQ==","X-Google-Smtp-Source":"\n AGHT+IHeOcG9Bnpx0IjVn7kLXVDgEz9fm68zgEHM60SbXPFLEIbauMEVjdnVKL9SBHFoEGkeAwTBUQ==","X-Received":"by 2002:a05:651c:1986:b0:2fa:c5b0:39a3 with SMTP id\n 38308e7fff4ca-2faf3c13677mr18816021fa.14.1728059595277;\n Fri, 04 Oct 2024 09:33:15 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Richard Henderson ,\n Pierrick Bouvier , qemu-ppc@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v2 10/25] target/avr: Use explicit little-endian LD/ST API","Date":"Fri, 4 Oct 2024 13:30:26 -0300","Message-ID":"<20241004163042.85922-11-philmd@linaro.org>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241004163042.85922-1-philmd@linaro.org>","References":"<20241004163042.85922-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::236;\n envelope-from=philmd@linaro.org; helo=mail-lj1-x236.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The AVR architecture uses little endianness. Directly use\nthe little-endian LD/ST API.\n\nMechanical change using:\n\n $ end=le; \\\n for acc in uw w l q tul; do \\\n sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n $(git grep -wlE '(ld|st)t?u?[wlq]_p' target/avr/); \\\n done\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/avr/gdbstub.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/target/avr/gdbstub.c b/target/avr/gdbstub.c\nindex d6d3c1479b3..aea71282a58 100644\n--- a/target/avr/gdbstub.c\n+++ b/target/avr/gdbstub.c\n@@ -69,13 +69,13 @@ int avr_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n \n /* SP */\n if (n == 33) {\n- env->sp = lduw_p(mem_buf);\n+ env->sp = lduw_le_p(mem_buf);\n return 2;\n }\n \n /* PC */\n if (n == 34) {\n- env->pc_w = ldl_p(mem_buf) / 2;\n+ env->pc_w = ldl_le_p(mem_buf) / 2;\n return 4;\n }\n \n","prefixes":["v2","10/25"]}