{"id":1992865,"url":"http://patchwork.ozlabs.org/api/patches/1992865/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-5-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20241004163042.85922-5-philmd@linaro.org>","list_archive_url":null,"date":"2024-10-04T16:30:20","name":"[v2,04/25] target/s390x: Replace ldtul_p() -> ldq_p()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a242f5c80005c004a5fe9936e6ef57f2929edb99","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-5-philmd@linaro.org/mbox/","series":[{"id":426623,"url":"http://patchwork.ozlabs.org/api/series/426623/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=426623","date":"2024-10-04T16:30:18","name":"misc: Use explicit endian LD/ST API","version":2,"mbox":"http://patchwork.ozlabs.org/series/426623/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1992865/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1992865/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=v5TLkMKG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XKvHp19drz1xtH\n\tfor ; Sat, 5 Oct 2024 02:33:42 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swlDi-0004jN-Af; Fri, 04 Oct 2024 12:31:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1swlDh-0004ij-BK\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:31:57 -0400","from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1swlDe-0005ej-Hm\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:31:56 -0400","by mail-lj1-x22d.google.com with SMTP id\n 38308e7fff4ca-2fac47f0b1aso29892941fa.1\n for ; Fri, 04 Oct 2024 09:31:54 -0700 (PDT)","from localhost.localdomain ([91.223.100.150])\n by smtp.gmail.com with ESMTPSA id\n 38308e7fff4ca-2faf9b3a945sm197011fa.127.2024.10.04.09.31.45\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 04 Oct 2024 09:31:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728059512; x=1728664312; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Ah2mpPOVGVx2cY8doZ+1TV8yPkrfA9ibyFMVLGjjZzw=;\n b=v5TLkMKGGU3jeDF43StLz8TirJz0aBZKBok9P9hgKt3RubmDjJhFiCyfe5HHUDSXx9\n H6S91S95yjS6H6JWc0VzH4k3UU1KdUyl0tqrZ+UoexJ/zDRx5Uxv82Rshe8o17CR6k/d\n Mh33ZCPJP6QU56TE2F5+o+Ci9HaQ793HxQ4P22zSNi6ZLpEK2UOEZSNO8YEpH2Go+b2V\n xHa4bv/3hQea4uWsE7jSVSEOaW3P89CfBpxuYcQWLp869MF0oVsoIm5LhSz4jWrUb9t7\n TnwbM6PPMbZ4CCrIScPwjAFUJYp525J9TvrUhrqOZzg8zZCQf4Sjnmd6tw59Fel21UKs\n YrJQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728059512; x=1728664312;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Ah2mpPOVGVx2cY8doZ+1TV8yPkrfA9ibyFMVLGjjZzw=;\n b=KRwlDHi/1fM+KzS1Y0sQndpsOih3Yu8SjkkXa2FpvGPq8vDqMfnRCqtXYSbPekOAfX\n Mivd55gLH77hNVR3NcSVYcVqYaUJi1ALFBW5vsXoiXwkBRtzhk+MT5iIeczHhEGcW1s6\n 66ujUSFe9oRkIAFUVVCxyIr33PtrsIkoz8NAVJmxYaogPxvyWaxidIO+Fv8cpOXo2foK\n JUWSyy8kLsKLN1oAu2yO3TwP+zMgHjml2E9vNPQAH50VtcVQwW9gUSfhJEFndUwtBkMv\n PYoGNWguplZj1VhE2l3FmjxxLj4dODOcVoRDXth6qjbz8M06fq/iNLAsKRQLCBUTGJMU\n Ypgg==","X-Gm-Message-State":"AOJu0YysdSvivKW5SE88FfmzCNNMO1YQuopbA7CdbjfJ6pta3NJyMsmE\n MmcldFX1tQt6F9lLqXUWlVxZ97YYjTiTzNDfAZqVTNgTiyYacGT8N5JH1lmtujLrYIQwLwXogEt\n 6Y9Gt8A==","X-Google-Smtp-Source":"\n AGHT+IFnOCgeednwzvnQ9fVYAH8BPIYN0wgVj41VvvPP8r9V3726wqo75sRYfr3Ng047GYTEWxPl5g==","X-Received":"by 2002:a05:651c:154a:b0:2ef:2cdb:5053 with SMTP id\n 38308e7fff4ca-2faf3d8a8e9mr14915461fa.37.1728059512245;\n Fri, 04 Oct 2024 09:31:52 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Richard Henderson ,\n Pierrick Bouvier , qemu-ppc@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v2 04/25] target/s390x: Replace ldtul_p() -> ldq_p()","Date":"Fri, 4 Oct 2024 13:30:20 -0300","Message-ID":"<20241004163042.85922-5-philmd@linaro.org>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241004163042.85922-1-philmd@linaro.org>","References":"<20241004163042.85922-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::22d;\n envelope-from=philmd@linaro.org; helo=mail-lj1-x22d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The S390X target is only built for 64-bit.\nUsing ldtul_p() is pointless, replace by ldq_p().\n\nMechanical change doing:\n\n $ sed -i -e 's/ldtul_p/ldq_p/' $(git grep -wl ldtul_p target/s390x/)\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/s390x/gdbstub.c | 30 +++++++++++++++---------------\n 1 file changed, 15 insertions(+), 15 deletions(-)","diff":"diff --git a/target/s390x/gdbstub.c b/target/s390x/gdbstub.c\nindex a9f4eb92adf..9ffec0bccbc 100644\n--- a/target/s390x/gdbstub.c\n+++ b/target/s390x/gdbstub.c\n@@ -46,7 +46,7 @@ int s390_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n)\n int s390_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n {\n CPUS390XState *env = cpu_env(cs);\n- target_ulong tmpl = ldtul_p(mem_buf);\n+ target_ulong tmpl = ldq_p(mem_buf);\n \n switch (n) {\n case S390_PSWM_REGNUM:\n@@ -126,7 +126,7 @@ static int cpu_write_fp_reg(CPUState *cs, uint8_t *mem_buf, int n)\n env->fpc = ldl_p(mem_buf);\n return 4;\n case S390_F0_REGNUM ... S390_F15_REGNUM:\n- *get_freg(env, n - S390_F0_REGNUM) = ldtul_p(mem_buf);\n+ *get_freg(env, n - S390_F0_REGNUM) = ldq_p(mem_buf);\n return 8;\n default:\n return 0;\n@@ -167,11 +167,11 @@ static int cpu_write_vreg(CPUState *cs, uint8_t *mem_buf, int n)\n \n switch (n) {\n case S390_V0L_REGNUM ... S390_V15L_REGNUM:\n- env->vregs[n][1] = ldtul_p(mem_buf + 8);\n+ env->vregs[n][1] = ldq_p(mem_buf + 8);\n return 8;\n case S390_V16_REGNUM ... S390_V31_REGNUM:\n- env->vregs[n][0] = ldtul_p(mem_buf);\n- env->vregs[n][1] = ldtul_p(mem_buf + 8);\n+ env->vregs[n][0] = ldq_p(mem_buf);\n+ env->vregs[n][1] = ldq_p(mem_buf + 8);\n return 16;\n default:\n return 0;\n@@ -203,7 +203,7 @@ static int cpu_write_c_reg(CPUState *cs, uint8_t *mem_buf, int n)\n \n switch (n) {\n case S390_C0_REGNUM ... S390_C15_REGNUM:\n- env->cregs[n] = ldtul_p(mem_buf);\n+ env->cregs[n] = ldq_p(mem_buf);\n if (tcg_enabled()) {\n tlb_flush(env_cpu(env));\n }\n@@ -246,19 +246,19 @@ static int cpu_write_virt_reg(CPUState *cs, uint8_t *mem_buf, int n)\n \n switch (n) {\n case S390_VIRT_CKC_REGNUM:\n- env->ckc = ldtul_p(mem_buf);\n+ env->ckc = ldq_p(mem_buf);\n cpu_synchronize_post_init(cs);\n return 8;\n case S390_VIRT_CPUTM_REGNUM:\n- env->cputm = ldtul_p(mem_buf);\n+ env->cputm = ldq_p(mem_buf);\n cpu_synchronize_post_init(cs);\n return 8;\n case S390_VIRT_BEA_REGNUM:\n- env->gbea = ldtul_p(mem_buf);\n+ env->gbea = ldq_p(mem_buf);\n cpu_synchronize_post_init(cs);\n return 8;\n case S390_VIRT_PREFIX_REGNUM:\n- env->psa = ldtul_p(mem_buf);\n+ env->psa = ldq_p(mem_buf);\n cpu_synchronize_post_init(cs);\n return 8;\n default:\n@@ -298,19 +298,19 @@ static int cpu_write_virt_kvm_reg(CPUState *cs, uint8_t *mem_buf, int n)\n \n switch (n) {\n case S390_VIRT_KVM_PP_REGNUM:\n- env->pp = ldtul_p(mem_buf);\n+ env->pp = ldq_p(mem_buf);\n cpu_synchronize_post_init(env_cpu(env));\n return 8;\n case S390_VIRT_KVM_PFT_REGNUM:\n- env->pfault_token = ldtul_p(mem_buf);\n+ env->pfault_token = ldq_p(mem_buf);\n cpu_synchronize_post_init(env_cpu(env));\n return 8;\n case S390_VIRT_KVM_PFS_REGNUM:\n- env->pfault_select = ldtul_p(mem_buf);\n+ env->pfault_select = ldq_p(mem_buf);\n cpu_synchronize_post_init(env_cpu(env));\n return 8;\n case S390_VIRT_KVM_PFC_REGNUM:\n- env->pfault_compare = ldtul_p(mem_buf);\n+ env->pfault_compare = ldq_p(mem_buf);\n cpu_synchronize_post_init(env_cpu(env));\n return 8;\n default:\n@@ -338,7 +338,7 @@ static int cpu_write_gs_reg(CPUState *cs, uint8_t *mem_buf, int n)\n S390CPU *cpu = S390_CPU(cs);\n CPUS390XState *env = &cpu->env;\n \n- env->gscb[n] = ldtul_p(mem_buf);\n+ env->gscb[n] = ldq_p(mem_buf);\n cpu_synchronize_post_init(env_cpu(env));\n return 8;\n }\n","prefixes":["v2","04/25"]}