{"id":1992864,"url":"http://patchwork.ozlabs.org/api/patches/1992864/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-8-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20241004163042.85922-8-philmd@linaro.org>","list_archive_url":null,"date":"2024-10-04T16:30:23","name":"[v2,07/25] target/hexagon: Use explicit little-endian LD/ST API","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1c7eb8284a368aa6fd5e0eef64eeca7f80a55d54","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-8-philmd@linaro.org/mbox/","series":[{"id":426623,"url":"http://patchwork.ozlabs.org/api/series/426623/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=426623","date":"2024-10-04T16:30:18","name":"misc: Use explicit endian LD/ST API","version":2,"mbox":"http://patchwork.ozlabs.org/series/426623/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1992864/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1992864/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Wr03iigy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XKvHm0GzWz1xtH\n\tfor ; Sat, 5 Oct 2024 02:33:40 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swlEj-0006hc-9p; Fri, 04 Oct 2024 12:33:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1swlEQ-0006GF-5n\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:32:44 -0400","from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1swlEN-0005mV-FM\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:32:41 -0400","by mail-lj1-x22d.google.com with SMTP id\n 38308e7fff4ca-2fac3f1287bso27652161fa.1\n for ; Fri, 04 Oct 2024 09:32:39 -0700 (PDT)","from localhost.localdomain ([91.223.100.150])\n by smtp.gmail.com with ESMTPSA id\n 38308e7fff4ca-2faf9b3ac99sm189601fa.130.2024.10.04.09.32.31\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 04 Oct 2024 09:32:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728059557; x=1728664357; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nZpimvVQnGecchp1DSJAwynwQ1iesRuTNy8I2ClNlvc=;\n b=Wr03iigyfvI5hDMkTCBshimDW281wdofMt9QlGJ0rkY0WHGDSwZAXhcv/ZO66XSCW4\n NrFq7vGOVDLQ1y+BjyF84sM7SN6p4tY00kEFAhmLcZ9rF0nMS4V3yE9qwiMS8Snc+aQG\n 3liULDInWpE5EzlI0oW9vu+lrZ/OyqLNl2ci/wafSl9dAVggVOCg0SBqw3heigfTzUXI\n PP+td8nZj9MdVQMh5sMgZaEUAJqk8QZLQfxxdoC9XVfiReRVLqhkZg16YBed6h4QYVPz\n QzupXQBwyrZRLu7y/7Vm8iZ0ETHMQusZEQGPRh4lXdqaMCSfil1icpZ6rBsZxE8Xnw1a\n 8K6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728059557; x=1728664357;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=nZpimvVQnGecchp1DSJAwynwQ1iesRuTNy8I2ClNlvc=;\n b=jplUEOR+JP69kcdfXEGFP0moSOL3L5pGx4tFABYc6wdjH6tXLSFynWCPlYhRTx3cTU\n OBJ7kK5wVq6liNMs7TzeJUOHmV+QCKPodlQq+8m6WcCKwt480x7M5WifKuOq8mLRH3mb\n 6oJJMWPkWo28Nry8Byt9FsT/AoOQvycM+lIXncs1xpse5eQXHryw/eisxpxrMq+huHrp\n jXAMIycY7werQ0H55is3fQInl441R/fZSxL0deQWl+L4mbBkIZI0mgkdQKpqJCh/nW15\n wpKWU3BZB8bRWIjkqAmsYDI7GtqJON6sz5aJMrOHDHQNlUq2qx2K/W7UdPhHkNnTAOiH\n 39cA==","X-Gm-Message-State":"AOJu0Yw4nSEc85EVCn+kTHgXNO6ETzi+iQAJmwKLCgKZX6xnFQccCO0l\n XXrhH4o/e/m5kfSrrASM6ZLEn29pK/+sK99Ivx+H0FnEocxw/N2uopokHamDHPTxDFq6juSb0Op\n FljQP7A==","X-Google-Smtp-Source":"\n AGHT+IESnbCx3EdGKG1FtJeY8vVI0UmMpyzLTgCEarsQnpb3j/g31sMRPD1Fmkc1iDWQo0CJPCsgag==","X-Received":"by 2002:a2e:a58a:0:b0:2f7:64b9:ff90 with SMTP id\n 38308e7fff4ca-2faf3c017d0mr17237501fa.9.1728059557389;\n Fri, 04 Oct 2024 09:32:37 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Richard Henderson ,\n Pierrick Bouvier , qemu-ppc@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v2 07/25] target/hexagon: Use explicit little-endian LD/ST API","Date":"Fri, 4 Oct 2024 13:30:23 -0300","Message-ID":"<20241004163042.85922-8-philmd@linaro.org>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241004163042.85922-1-philmd@linaro.org>","References":"<20241004163042.85922-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::22d;\n envelope-from=philmd@linaro.org; helo=mail-lj1-x22d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The Hexagon architecture uses little endianness. Directly use\nthe little-endian LD/ST API.\n\nMechanical change using:\n\n $ end=le; \\\n for acc in uw w l q tul; do \\\n sed -i -e \"s/ld${acc}_p(/ld${acc}_${end}_p(/\" \\\n -e \"s/st${acc}_p(/st${acc}_${end}_p(/\" \\\n $(git grep -wlE '(ld|st)t?u?[wlq]_p' target/hexagon/); \\\n done\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/hexagon/gdbstub.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/target/hexagon/gdbstub.c b/target/hexagon/gdbstub.c\nindex 557b3029785..12d6b3bbcbb 100644\n--- a/target/hexagon/gdbstub.c\n+++ b/target/hexagon/gdbstub.c\n@@ -52,7 +52,7 @@ int hexagon_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n CPUHexagonState *env = cpu_env(cs);\n \n if (n == HEX_REG_P3_0_ALIASED) {\n- uint32_t p3_0 = ldl_p(mem_buf);\n+ uint32_t p3_0 = ldl_le_p(mem_buf);\n for (int i = 0; i < NUM_PREGS; i++) {\n env->pred[i] = extract32(p3_0, i * 8, 8);\n }\n@@ -60,14 +60,14 @@ int hexagon_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n }\n \n if (n < TOTAL_PER_THREAD_REGS) {\n- env->gpr[n] = ldl_p(mem_buf);\n+ env->gpr[n] = ldl_le_p(mem_buf);\n return sizeof(target_ulong);\n }\n \n n -= TOTAL_PER_THREAD_REGS;\n \n if (n < NUM_PREGS) {\n- env->pred[n] = ldl_p(mem_buf) & 0xff;\n+ env->pred[n] = ldl_le_p(mem_buf) & 0xff;\n return sizeof(uint8_t);\n }\n \n@@ -117,7 +117,7 @@ static int gdb_put_vreg(CPUHexagonState *env, uint8_t *mem_buf, int n)\n {\n int i;\n for (i = 0; i < ARRAY_SIZE(env->VRegs[n].uw); i++) {\n- env->VRegs[n].uw[i] = ldl_p(mem_buf);\n+ env->VRegs[n].uw[i] = ldl_le_p(mem_buf);\n mem_buf += 4;\n }\n return MAX_VEC_SIZE_BYTES;\n@@ -127,7 +127,7 @@ static int gdb_put_qreg(CPUHexagonState *env, uint8_t *mem_buf, int n)\n {\n int i;\n for (i = 0; i < ARRAY_SIZE(env->QRegs[n].uw); i++) {\n- env->QRegs[n].uw[i] = ldl_p(mem_buf);\n+ env->QRegs[n].uw[i] = ldl_le_p(mem_buf);\n mem_buf += 4;\n }\n return MAX_VEC_SIZE_BYTES / 8;\n","prefixes":["v2","07/25"]}