{"id":1992854,"url":"http://patchwork.ozlabs.org/api/patches/1992854/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-3-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20241004163042.85922-3-philmd@linaro.org>","list_archive_url":null,"date":"2024-10-04T16:30:18","name":"[v2,02/25] target/hexagon: Replace ldtul_p() -> ldl_p()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fa3a596dd251e24aa75e392fac6b3ea633b0f006","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20241004163042.85922-3-philmd@linaro.org/mbox/","series":[{"id":426623,"url":"http://patchwork.ozlabs.org/api/series/426623/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=426623","date":"2024-10-04T16:30:18","name":"misc: Use explicit endian LD/ST API","version":2,"mbox":"http://patchwork.ozlabs.org/series/426623/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1992854/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1992854/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=czLUMgmZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4XKvG62FTXz1xtH\n\tfor ; Sat, 5 Oct 2024 02:32:14 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1swlDJ-0004Fb-3d; Fri, 04 Oct 2024 12:31:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1swlDD-0004CT-AS\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:31:28 -0400","from mail-lf1-x129.google.com ([2a00:1450:4864:20::129])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1swlDA-0005ZR-La\n for qemu-devel@nongnu.org; Fri, 04 Oct 2024 12:31:27 -0400","by mail-lf1-x129.google.com with SMTP id\n 2adb3069b0e04-539908f238fso2742510e87.2\n for ; Fri, 04 Oct 2024 09:31:24 -0700 (PDT)","from localhost.localdomain ([91.223.100.150])\n by smtp.gmail.com with ESMTPSA id\n 2adb3069b0e04-539aff23456sm408e87.228.2024.10.04.09.31.16\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 04 Oct 2024 09:31:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1728059483; x=1728664283; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=oAoM1TIG4dq1VUGRtKg0GSKBpc95w16YyE/RovaDYeo=;\n b=czLUMgmZg/WkeTEEMbGyhaKZYmhPUsGqIccstZ9kB0xk5mcfGu0povwpqMqZNC/8pa\n PQDvP2CiiYVdPCDJmX6xjCiKCpiy7fyqXaNot1yELmXR/sX5xv5vFQWrZ1UKZkG/Tt6K\n gPBqIRal3rAXeq0DhSRlMnlGRvNeVYBBhExcjtbJr0sLwhoJDOfZ5Fk7AxI1V23AgZJc\n O5+VtNs6yQqV+LFvdkmmZwEYRFE9/+Hhu8MbR+8Dmb8XO1zkDy9yo4vlgbV9UXJQyPXZ\n InxsWje2AmrttMi2mb5jgDJ+D6nzApmg0zjKS14RzCi3n4eWN5tIRyskAhvou/pRSlg2\n cYKg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1728059483; x=1728664283;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=oAoM1TIG4dq1VUGRtKg0GSKBpc95w16YyE/RovaDYeo=;\n b=GJ+H76jbs/OxLqaRWEwxgevvDGeNvikDsNqLUafHeXaBo+mdM9GcSm20fhKek1EKsL\n AQkI6pXOYvmV+zgdte5HM7BkbjsV+O7gQ7wSf6Ob5+uHTNVoEY4+59X2XrjSrN63/KUa\n fGzNA8X8hFGBlK6ZFaFnbDx75OLoST1Q1KZ8l0LQSb8PDHiK9r4JPjTWPp02ZiDQPZBK\n NHRdM07iwbPe5sfSFPXCSVShCAvoFUMd1iUGRBm8FN25tbwtXHAdmIX3n7Kt9w/fIIAU\n uA2CMD8VgNg7068LlgzlPH5bVwY5NVa9cJDliLUMcaqP/YZbYtyD++jcLxflUcV7XIwe\n M9fA==","X-Gm-Message-State":"AOJu0Yw0yTy52N00BucUXQ1PLvkHs2JdUwluzu1MCjqztG9jTVt3Us+J\n TPMPH0hEh0fvldp+Nk3W3S5u8p4YHfeQy+3lPOfHHaUJinUgSnONRWG6QEN0E+GidHrudPmoB6t\n Wo8svpQ==","X-Google-Smtp-Source":"\n AGHT+IFfOBslwkgwL+4yQuRBLExOXV8a8c828bT7DjbcDxRzT+V2oESEOon5TOz6PKBcbt216VV/dg==","X-Received":"by 2002:a05:6512:4007:b0:530:d088:233f with SMTP id\n 2adb3069b0e04-539ab9eadeamr2111073e87.40.1728059482649;\n Fri, 04 Oct 2024 09:31:22 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n Thomas Huth ,\n Richard Henderson ,\n Pierrick Bouvier , qemu-ppc@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH v2 02/25] target/hexagon: Replace ldtul_p() -> ldl_p()","Date":"Fri, 4 Oct 2024 13:30:18 -0300","Message-ID":"<20241004163042.85922-3-philmd@linaro.org>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241004163042.85922-1-philmd@linaro.org>","References":"<20241004163042.85922-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::129;\n envelope-from=philmd@linaro.org; helo=mail-lf1-x129.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The Hexagon target is only built for 64-bit.\nUsing ldtul_p() is pointless, replace by ldl_p().\n\nMechanical change doing:\n\n $ sed -i -e 's/ldtul_p/ldl_p/' \\\n $(git grep -wl ldtul_p target/hexagon/)\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/hexagon/gdbstub.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/target/hexagon/gdbstub.c b/target/hexagon/gdbstub.c\nindex 94e1db8ef8d..557b3029785 100644\n--- a/target/hexagon/gdbstub.c\n+++ b/target/hexagon/gdbstub.c\n@@ -52,7 +52,7 @@ int hexagon_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n CPUHexagonState *env = cpu_env(cs);\n \n if (n == HEX_REG_P3_0_ALIASED) {\n- uint32_t p3_0 = ldtul_p(mem_buf);\n+ uint32_t p3_0 = ldl_p(mem_buf);\n for (int i = 0; i < NUM_PREGS; i++) {\n env->pred[i] = extract32(p3_0, i * 8, 8);\n }\n@@ -60,14 +60,14 @@ int hexagon_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n }\n \n if (n < TOTAL_PER_THREAD_REGS) {\n- env->gpr[n] = ldtul_p(mem_buf);\n+ env->gpr[n] = ldl_p(mem_buf);\n return sizeof(target_ulong);\n }\n \n n -= TOTAL_PER_THREAD_REGS;\n \n if (n < NUM_PREGS) {\n- env->pred[n] = ldtul_p(mem_buf) & 0xff;\n+ env->pred[n] = ldl_p(mem_buf) & 0xff;\n return sizeof(uint8_t);\n }\n \n@@ -117,7 +117,7 @@ static int gdb_put_vreg(CPUHexagonState *env, uint8_t *mem_buf, int n)\n {\n int i;\n for (i = 0; i < ARRAY_SIZE(env->VRegs[n].uw); i++) {\n- env->VRegs[n].uw[i] = ldtul_p(mem_buf);\n+ env->VRegs[n].uw[i] = ldl_p(mem_buf);\n mem_buf += 4;\n }\n return MAX_VEC_SIZE_BYTES;\n@@ -127,7 +127,7 @@ static int gdb_put_qreg(CPUHexagonState *env, uint8_t *mem_buf, int n)\n {\n int i;\n for (i = 0; i < ARRAY_SIZE(env->QRegs[n].uw); i++) {\n- env->QRegs[n].uw[i] = ldtul_p(mem_buf);\n+ env->QRegs[n].uw[i] = ldl_p(mem_buf);\n mem_buf += 4;\n }\n return MAX_VEC_SIZE_BYTES / 8;\n","prefixes":["v2","02/25"]}