{"id":1954409,"url":"http://patchwork.ozlabs.org/api/patches/1954409/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1719776434-435013-8-git-send-email-steven.sistare@oracle.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1719776434-435013-8-git-send-email-steven.sistare@oracle.com>","list_archive_url":null,"date":"2024-06-30T19:40:30","name":"[V2,07/11] oslib: qemu_clear_cloexec","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"54a0dd0e42d0f25b0b5e5adc7027dbf1ab038299","submitter":{"id":71906,"url":"http://patchwork.ozlabs.org/api/people/71906/?format=json","name":"Steve Sistare","email":"steven.sistare@oracle.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1719776434-435013-8-git-send-email-steven.sistare@oracle.com/mbox/","series":[{"id":413181,"url":"http://patchwork.ozlabs.org/api/series/413181/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=413181","date":"2024-06-30T19:40:26","name":"Live update: cpr-exec","version":2,"mbox":"http://patchwork.ozlabs.org/series/413181/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1954409/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1954409/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oracle.com header.i=@oracle.com header.a=rsa-sha256\n header.s=corp-2023-11-20 header.b=LtTGZmBM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4WC02c5syfz1xpN\n\tfor ; Mon, 1 Jul 2024 05:43:04 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1sO0QH-0000En-Cr; Sun, 30 Jun 2024 15:41:17 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1sO0Px-0008VJ-Lg\n for qemu-devel@nongnu.org; Sun, 30 Jun 2024 15:40:57 -0400","from mx0a-00069f02.pphosted.com ([205.220.165.32])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1sO0Pu-0004Op-4q\n for qemu-devel@nongnu.org; Sun, 30 Jun 2024 15:40:57 -0400","from pps.filterd (m0246617.ppops.net [127.0.0.1])\n by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n 45UJbKi2018314;\n Sun, 30 Jun 2024 19:40:47 GMT","from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com\n (iadpaimrmta02.appoci.oracle.com [147.154.18.20])\n by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 402att9e20-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sun, 30 Jun 2024 19:40:47 +0000 (GMT)","from pps.filterd\n (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])\n by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19)\n with ESMTP id 45UEQnGW018357; Sun, 30 Jun 2024 19:40:45 GMT","from pps.reinject (localhost [127.0.0.1])\n by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id\n 4028qc16e1-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sun, 30 Jun 2024 19:40:45 +0000","from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com\n (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])\n by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 45UJeaSc014044;\n Sun, 30 Jun 2024 19:40:45 GMT","from ca-dev63.us.oracle.com (ca-dev63.us.oracle.com [10.211.8.221])\n by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with\n ESMTP id 4028qc16cc-8; Sun, 30 Jun 2024 19:40:45 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-type:content-transfer-encoding; s=\n corp-2023-11-20; bh=i5+JyvSJETfbDxmWNrKcfGvEku7jqW3wlnKNZ9xh0Mg=; b=\n LtTGZmBMFrWNAKRpn7Xo3R+wucLhFJg7/e5JjDMWU9fOSHj1VEcdcURIQzFeMtSp\n kcFlVE4zq/zx7m42wcFwSdMKzA2jOT5xQXniaVzmVwl4u0I6LqqwvvhzDBdBlpgI\n j9VSA0UJK0OzF8KmJWfXROd2wXg9kKBvpwIY6qQaG+ITlsPiS2OUgu6utrErh3EL\n ZOPobomSxiMb8oMNAL/T+7dOUn2uCVf7iCmz8PcqgEXX8Thz8xOuwrulz+Vo81rr\n LZeX3xHoMbMM8SGoL6U/ZD4XMuLgzOluYdP7FWLMEB7yNTsj6hEu1ELJ3MdT5B9j\n O478EYKPNHlmY+B8WmvVww==","From":"Steve Sistare ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , Fabiano Rosas ,\n David Hildenbrand ,\n Marcel Apfelbaum ,\n Eduardo Habkost ,\n Philippe Mathieu-Daude ,\n Paolo Bonzini ,\n \"Daniel P. Berrange\" ,\n Markus Armbruster ,\n Steve Sistare ","Subject":"[PATCH V2 07/11] oslib: qemu_clear_cloexec","Date":"Sun, 30 Jun 2024 12:40:30 -0700","Message-Id":"<1719776434-435013-8-git-send-email-steven.sistare@oracle.com>","X-Mailer":"git-send-email 1.8.3.1","In-Reply-To":"<1719776434-435013-1-git-send-email-steven.sistare@oracle.com>","References":"<1719776434-435013-1-git-send-email-steven.sistare@oracle.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16\n definitions=2024-06-30_16,2024-06-28_01,2024-05-17_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 suspectscore=0\n malwarescore=0\n adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 spamscore=0\n mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2406180000 definitions=main-2406300157","X-Proofpoint-GUID":"nYpOXhzlORUaiaL8QVXBAr9kQ7dWBiUR","X-Proofpoint-ORIG-GUID":"nYpOXhzlORUaiaL8QVXBAr9kQ7dWBiUR","Received-SPF":"pass client-ip=205.220.165.32;\n envelope-from=steven.sistare@oracle.com; helo=mx0a-00069f02.pphosted.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Define qemu_clear_cloexec, analogous to qemu_set_cloexec.\n\nSigned-off-by: Steve Sistare \nReviewed-by: Dr. David Alan Gilbert \nReviewed-by: Marc-André Lureau \nReviewed-by: Fabiano Rosas \n---\n include/qemu/osdep.h | 9 +++++++++\n util/oslib-posix.c | 9 +++++++++\n util/oslib-win32.c | 4 ++++\n 3 files changed, 22 insertions(+)","diff":"diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h\nindex 191916f..6ebf192 100644\n--- a/include/qemu/osdep.h\n+++ b/include/qemu/osdep.h\n@@ -662,6 +662,15 @@ ssize_t qemu_write_full(int fd, const void *buf, size_t count)\n \n void qemu_set_cloexec(int fd);\n \n+/*\n+ * Clear FD_CLOEXEC for a descriptor.\n+ *\n+ * The caller must guarantee that no other fork+exec's occur before the\n+ * exec that is intended to inherit this descriptor, eg by suspending CPUs\n+ * and blocking monitor commands.\n+ */\n+void qemu_clear_cloexec(int fd);\n+\n /* Return a dynamically allocated directory path that is appropriate for storing\n * local state.\n *\ndiff --git a/util/oslib-posix.c b/util/oslib-posix.c\nindex e764416..614c3e5 100644\n--- a/util/oslib-posix.c\n+++ b/util/oslib-posix.c\n@@ -272,6 +272,15 @@ int qemu_socketpair(int domain, int type, int protocol, int sv[2])\n return ret;\n }\n \n+void qemu_clear_cloexec(int fd)\n+{\n+ int f;\n+ f = fcntl(fd, F_GETFD);\n+ assert(f != -1);\n+ f = fcntl(fd, F_SETFD, f & ~FD_CLOEXEC);\n+ assert(f != -1);\n+}\n+\n char *\n qemu_get_local_state_dir(void)\n {\ndiff --git a/util/oslib-win32.c b/util/oslib-win32.c\nindex b623830..c3e969a 100644\n--- a/util/oslib-win32.c\n+++ b/util/oslib-win32.c\n@@ -222,6 +222,10 @@ void qemu_set_cloexec(int fd)\n {\n }\n \n+void qemu_clear_cloexec(int fd)\n+{\n+}\n+\n int qemu_get_thread_id(void)\n {\n return GetCurrentThreadId();\n","prefixes":["V2","07/11"]}