{"id":1954407,"url":"http://patchwork.ozlabs.org/api/patches/1954407/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1719776434-435013-10-git-send-email-steven.sistare@oracle.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1719776434-435013-10-git-send-email-steven.sistare@oracle.com>","list_archive_url":null,"date":"2024-06-30T19:40:32","name":"[V2,09/11] migration: cpr-exec-command parameter","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"116c08c553d95a0f066dd45ac55fa44fa637cd69","submitter":{"id":71906,"url":"http://patchwork.ozlabs.org/api/people/71906/?format=json","name":"Steve Sistare","email":"steven.sistare@oracle.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1719776434-435013-10-git-send-email-steven.sistare@oracle.com/mbox/","series":[{"id":413181,"url":"http://patchwork.ozlabs.org/api/series/413181/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=413181","date":"2024-06-30T19:40:26","name":"Live update: cpr-exec","version":2,"mbox":"http://patchwork.ozlabs.org/series/413181/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1954407/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1954407/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oracle.com header.i=@oracle.com header.a=rsa-sha256\n header.s=corp-2023-11-20 header.b=TnkizE5x;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4WC0276fBtz1xpN\n\tfor ; Mon, 1 Jul 2024 05:42:39 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1sO0QI-0000Er-3y; Sun, 30 Jun 2024 15:41:18 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1sO0Pw-0008UF-Fy\n for qemu-devel@nongnu.org; Sun, 30 Jun 2024 15:40:56 -0400","from mx0a-00069f02.pphosted.com ([205.220.165.32])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1sO0Pu-0004PE-5I\n for qemu-devel@nongnu.org; Sun, 30 Jun 2024 15:40:56 -0400","from pps.filterd (m0246629.ppops.net [127.0.0.1])\n by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n 45UJOOO6012862;\n Sun, 30 Jun 2024 19:40:49 GMT","from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com\n (iadpaimrmta02.appoci.oracle.com [147.154.18.20])\n by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 402a591erf-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sun, 30 Jun 2024 19:40:49 +0000 (GMT)","from pps.filterd\n (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])\n by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19)\n with ESMTP id 45UG0nJ0019121; Sun, 30 Jun 2024 19:40:48 GMT","from pps.reinject (localhost [127.0.0.1])\n by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id\n 4028qc16ee-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sun, 30 Jun 2024 19:40:48 +0000","from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com\n (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])\n by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 45UJeaSg014044;\n Sun, 30 Jun 2024 19:40:47 GMT","from ca-dev63.us.oracle.com (ca-dev63.us.oracle.com [10.211.8.221])\n by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with\n ESMTP id 4028qc16cc-10; Sun, 30 Jun 2024 19:40:47 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references; s=\n corp-2023-11-20; bh=0niKNmTF4WrGuB6zYfEq+bYLo3vZ/K4GncHP23R0cUo=; b=\n TnkizE5xSCefKzkKTzjUW540sd9EViOrK3E6ZWCBEz1O2k6/hTxRzgjTJCxPLJCk\n et1z6/HgtLx/HGMo4pg2Gc8WfHEEPUFPybdQqbQEGjw33SNAouDoBkBpfA7FJUp/\n 43ROB9trnt7cjN1PGj6n++uRfIwBCyIJkxP4NdmVwmXbVT5989oISjRU+Ul0rv8h\n h29X3epDhvtfYO9fBB4kV5u+nhxKSA9u9qHMNzgmIPf2i0KIIcjcS7F5uX67B/Gs\n EOvL3NqYzP5f+l3Ak7PV2gsbT+JFU6bBbiFC+3a6rHke6mmjKPp44okq6DGf8gZg\n iQ/y599jwkFNC575OUgprQ==","From":"Steve Sistare ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , Fabiano Rosas ,\n David Hildenbrand ,\n Marcel Apfelbaum ,\n Eduardo Habkost ,\n Philippe Mathieu-Daude ,\n Paolo Bonzini ,\n \"Daniel P. Berrange\" ,\n Markus Armbruster ,\n Steve Sistare ","Subject":"[PATCH V2 09/11] migration: cpr-exec-command parameter","Date":"Sun, 30 Jun 2024 12:40:32 -0700","Message-Id":"<1719776434-435013-10-git-send-email-steven.sistare@oracle.com>","X-Mailer":"git-send-email 1.8.3.1","In-Reply-To":"<1719776434-435013-1-git-send-email-steven.sistare@oracle.com>","References":"<1719776434-435013-1-git-send-email-steven.sistare@oracle.com>","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16\n definitions=2024-06-30_16,2024-06-28_01,2024-05-17_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 suspectscore=0\n malwarescore=0\n adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 spamscore=0\n mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2406180000 definitions=main-2406300157","X-Proofpoint-GUID":"gnP3ihmOBfFg8Rd5CkNMWkvpBjVzPV0P","X-Proofpoint-ORIG-GUID":"gnP3ihmOBfFg8Rd5CkNMWkvpBjVzPV0P","Received-SPF":"pass client-ip=205.220.165.32;\n envelope-from=steven.sistare@oracle.com; helo=mx0a-00069f02.pphosted.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Create the cpr-exec-command migration parameter, defined as a list of\nstrings. It will be used for cpr-exec migration mode in a subsequent\npatch, and contains forward references to cpr-exec mode in the qapi\ndoc.\n\nNo functional change, except that cpr-exec-command is shown by the\n'info migrate' command.\n\nSigned-off-by: Steve Sistare \n---\n hmp-commands.hx | 2 +-\n migration/migration-hmp-cmds.c | 25 +++++++++++++++++++++++++\n migration/options.c | 14 ++++++++++++++\n qapi/migration.json | 21 ++++++++++++++++++---\n 4 files changed, 58 insertions(+), 4 deletions(-)","diff":"diff --git a/hmp-commands.hx b/hmp-commands.hx\nindex 06746f0..0e04eac 100644\n--- a/hmp-commands.hx\n+++ b/hmp-commands.hx\n@@ -1009,7 +1009,7 @@ ERST\n \n {\n .name = \"migrate_set_parameter\",\n- .args_type = \"parameter:s,value:s\",\n+ .args_type = \"parameter:s,value:S\",\n .params = \"parameter value\",\n .help = \"Set the parameter for migration\",\n .cmd = hmp_migrate_set_parameter,\ndiff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c\nindex 7d608d2..16a4b00 100644\n--- a/migration/migration-hmp-cmds.c\n+++ b/migration/migration-hmp-cmds.c\n@@ -229,6 +229,18 @@ void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict)\n qapi_free_MigrationCapabilityStatusList(caps);\n }\n \n+static void monitor_print_cpr_exec_command(Monitor *mon, strList *args)\n+{\n+ monitor_printf(mon, \"%s:\",\n+ MigrationParameter_str(MIGRATION_PARAMETER_CPR_EXEC_COMMAND));\n+\n+ while (args) {\n+ monitor_printf(mon, \" %s\", args->value);\n+ args = args->next;\n+ }\n+ monitor_printf(mon, \"\\n\");\n+}\n+\n void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)\n {\n MigrationParameters *params;\n@@ -358,6 +370,9 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)\n MIGRATION_PARAMETER_DIRECT_IO),\n params->direct_io ? \"on\" : \"off\");\n }\n+\n+ assert(params->has_cpr_exec_command);\n+ monitor_print_cpr_exec_command(mon, params->cpr_exec_command);\n }\n \n qapi_free_MigrationParameters(params);\n@@ -635,6 +650,16 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)\n p->has_direct_io = true;\n visit_type_bool(v, param, &p->direct_io, &err);\n break;\n+ case MIGRATION_PARAMETER_CPR_EXEC_COMMAND: {\n+ g_autofree char **strv = g_strsplit(valuestr ?: \"\", \" \", -1);\n+ strList **tail = &p->cpr_exec_command;\n+\n+ for (int i = 0; strv[i]; i++) {\n+ QAPI_LIST_APPEND(tail, strv[i]);\n+ }\n+ p->has_cpr_exec_command = true;\n+ break;\n+ }\n default:\n assert(0);\n }\ndiff --git a/migration/options.c b/migration/options.c\nindex 305397a..b8d5f72 100644\n--- a/migration/options.c\n+++ b/migration/options.c\n@@ -931,6 +931,9 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp)\n params->zero_page_detection = s->parameters.zero_page_detection;\n params->has_direct_io = true;\n params->direct_io = s->parameters.direct_io;\n+ params->has_cpr_exec_command = true;\n+ params->cpr_exec_command = QAPI_CLONE(strList,\n+ s->parameters.cpr_exec_command);\n \n return params;\n }\n@@ -964,6 +967,7 @@ void migrate_params_init(MigrationParameters *params)\n params->has_mode = true;\n params->has_zero_page_detection = true;\n params->has_direct_io = true;\n+ params->has_cpr_exec_command = true;\n }\n \n /*\n@@ -1252,6 +1256,10 @@ static void migrate_params_test_apply(MigrateSetParameters *params,\n if (params->has_direct_io) {\n dest->direct_io = params->direct_io;\n }\n+\n+ if (params->has_cpr_exec_command) {\n+ dest->cpr_exec_command = params->cpr_exec_command;\n+ }\n }\n \n static void migrate_params_apply(MigrateSetParameters *params, Error **errp)\n@@ -1381,6 +1389,12 @@ static void migrate_params_apply(MigrateSetParameters *params, Error **errp)\n if (params->has_direct_io) {\n s->parameters.direct_io = params->direct_io;\n }\n+\n+ if (params->has_cpr_exec_command) {\n+ qapi_free_strList(s->parameters.cpr_exec_command);\n+ s->parameters.cpr_exec_command =\n+ QAPI_CLONE(strList, params->cpr_exec_command);\n+ }\n }\n \n void qmp_migrate_set_parameters(MigrateSetParameters *params, Error **errp)\ndiff --git a/qapi/migration.json b/qapi/migration.json\nindex 0f24206..20092d2 100644\n--- a/qapi/migration.json\n+++ b/qapi/migration.json\n@@ -829,6 +829,10 @@\n # only has effect if the @mapped-ram capability is enabled.\n # (Since 9.1)\n #\n+# @cpr-exec-command: Command to start the new QEMU process when @mode\n+# is @cpr-exec. The first list element is the program's filename,\n+# the remainder its arguments. (Since 9.1)\n+#\n # Features:\n #\n # @unstable: Members @x-checkpoint-delay and\n@@ -854,7 +858,8 @@\n 'vcpu-dirty-limit',\n 'mode',\n 'zero-page-detection',\n- 'direct-io'] }\n+ 'direct-io',\n+ 'cpr-exec-command'] }\n \n ##\n # @MigrateSetParameters:\n@@ -1004,6 +1009,10 @@\n # only has effect if the @mapped-ram capability is enabled.\n # (Since 9.1)\n #\n+# @cpr-exec-command: Command to start the new QEMU process when @mode\n+# is @cpr-exec. The first list element is the program's filename,\n+# the remainder its arguments. (Since 9.1)\n+#\n # Features:\n #\n # @unstable: Members @x-checkpoint-delay and\n@@ -1044,7 +1053,8 @@\n '*vcpu-dirty-limit': 'uint64',\n '*mode': 'MigMode',\n '*zero-page-detection': 'ZeroPageDetection',\n- '*direct-io': 'bool' } }\n+ '*direct-io': 'bool',\n+ '*cpr-exec-command': [ 'str' ]} }\n \n ##\n # @migrate-set-parameters:\n@@ -1208,6 +1218,10 @@\n # only has effect if the @mapped-ram capability is enabled.\n # (Since 9.1)\n #\n+# @cpr-exec-command: Command to start the new QEMU process when @mode\n+# is @cpr-exec. The first list element is the program's filename,\n+# the remainder its arguments. (Since 9.1)\n+#\n # Features:\n #\n # @unstable: Members @x-checkpoint-delay and\n@@ -1245,7 +1259,8 @@\n '*vcpu-dirty-limit': 'uint64',\n '*mode': 'MigMode',\n '*zero-page-detection': 'ZeroPageDetection',\n- '*direct-io': 'bool' } }\n+ '*direct-io': 'bool',\n+ '*cpr-exec-command': [ 'str' ]} }\n \n ##\n # @query-migrate-parameters:\n","prefixes":["V2","09/11"]}