{"id":1954398,"url":"http://patchwork.ozlabs.org/api/patches/1954398/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1719776434-435013-9-git-send-email-steven.sistare@oracle.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1719776434-435013-9-git-send-email-steven.sistare@oracle.com>","list_archive_url":null,"date":"2024-06-30T19:40:31","name":"[V2,08/11] vl: helper to request exec","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5022721aa6fe6cb86d7708b550372474ca547483","submitter":{"id":71906,"url":"http://patchwork.ozlabs.org/api/people/71906/?format=json","name":"Steve Sistare","email":"steven.sistare@oracle.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1719776434-435013-9-git-send-email-steven.sistare@oracle.com/mbox/","series":[{"id":413181,"url":"http://patchwork.ozlabs.org/api/series/413181/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=413181","date":"2024-06-30T19:40:26","name":"Live update: cpr-exec","version":2,"mbox":"http://patchwork.ozlabs.org/series/413181/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1954398/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1954398/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oracle.com header.i=@oracle.com header.a=rsa-sha256\n header.s=corp-2023-11-20 header.b=AwV3ZTBL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4WC01B0kBrz1xpS\n\tfor ; Mon, 1 Jul 2024 05:41:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1sO0Q5-00008R-7Y; Sun, 30 Jun 2024 15:41:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1sO0Pw-0008UA-Fa\n for qemu-devel@nongnu.org; Sun, 30 Jun 2024 15:40:56 -0400","from mx0a-00069f02.pphosted.com ([205.220.165.32])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1sO0Pu-0004Oq-5L\n for qemu-devel@nongnu.org; Sun, 30 Jun 2024 15:40:56 -0400","from pps.filterd (m0246627.ppops.net [127.0.0.1])\n by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n 45UIwcCx022697;\n Sun, 30 Jun 2024 19:40:48 GMT","from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com\n (iadpaimrmta02.appoci.oracle.com [147.154.18.20])\n by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4028v0hgjw-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sun, 30 Jun 2024 19:40:48 +0000 (GMT)","from pps.filterd\n (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])\n by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19)\n with ESMTP id 45UEQnGX018357; Sun, 30 Jun 2024 19:40:47 GMT","from pps.reinject (localhost [127.0.0.1])\n by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id\n 4028qc16e6-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sun, 30 Jun 2024 19:40:46 +0000","from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com\n (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1])\n by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 45UJeaSe014044;\n Sun, 30 Jun 2024 19:40:46 GMT","from ca-dev63.us.oracle.com (ca-dev63.us.oracle.com [10.211.8.221])\n by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with\n ESMTP id 4028qc16cc-9; Sun, 30 Jun 2024 19:40:46 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=\n from:to:cc:subject:date:message-id:in-reply-to:references; s=\n corp-2023-11-20; bh=4uKXgAn4d6hJh3JzwucC45gtPiookX4h8suJNmSSDmA=; b=\n AwV3ZTBLF7NOyDdrwxzRUONH+cwp7tO2g/DpZV1KW686YsfmGsHfFHfGmFzOEjSU\n aQJE2tmp6/ZqLJ7T9TKbBwlTQb8XGxKPpykWueZ1OuSJqAGAtDXjQwAUHgw8KVqM\n rJciOGYJyUOEFSeTo86EEy6vat0k0aymvwOxXAS90GQNgAnCcgm9S0S6BYd6vDd0\n GlLBNlko90mGWppRpmhv5Ofb1cUgIHzLTOiquHD37Je//66N1PeLw4PfqCyyx7Sr\n Y1lCh/v0+tsxv4OtwsVxZMwvF7blNwpwVeKwABns3imTm1BWELQc1O1X+BhAa9DI\n 4GkOcSDOGOapIoTCye3PNw==","From":"Steve Sistare ","To":"qemu-devel@nongnu.org","Cc":"Peter Xu , Fabiano Rosas ,\n David Hildenbrand ,\n Marcel Apfelbaum ,\n Eduardo Habkost ,\n Philippe Mathieu-Daude ,\n Paolo Bonzini ,\n \"Daniel P. Berrange\" ,\n Markus Armbruster ,\n Steve Sistare ","Subject":"[PATCH V2 08/11] vl: helper to request exec","Date":"Sun, 30 Jun 2024 12:40:31 -0700","Message-Id":"<1719776434-435013-9-git-send-email-steven.sistare@oracle.com>","X-Mailer":"git-send-email 1.8.3.1","In-Reply-To":"<1719776434-435013-1-git-send-email-steven.sistare@oracle.com>","References":"<1719776434-435013-1-git-send-email-steven.sistare@oracle.com>","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16\n definitions=2024-06-30_16,2024-06-28_01,2024-05-17_01","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0 suspectscore=0\n malwarescore=0\n adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 spamscore=0\n mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2406180000 definitions=main-2406300157","X-Proofpoint-ORIG-GUID":"JLC7LN32UQinUQ8IaB4vS5uDV9YeJhZc","X-Proofpoint-GUID":"JLC7LN32UQinUQ8IaB4vS5uDV9YeJhZc","Received-SPF":"pass client-ip=205.220.165.32;\n envelope-from=steven.sistare@oracle.com; helo=mx0a-00069f02.pphosted.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add a qemu_system_exec_request() hook that causes the main loop to exit and\nexec a command using the specified arguments. This will be used during CPR\nto exec a new version of QEMU.\n\nSigned-off-by: Steve Sistare \n---\n include/sysemu/runstate.h | 3 +++\n system/runstate.c | 29 +++++++++++++++++++++++++++++\n 2 files changed, 32 insertions(+)","diff":"diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h\nindex 0117d24..cb669cf 100644\n--- a/include/sysemu/runstate.h\n+++ b/include/sysemu/runstate.h\n@@ -80,6 +80,8 @@ typedef enum WakeupReason {\n QEMU_WAKEUP_REASON_OTHER,\n } WakeupReason;\n \n+typedef void (*qemu_exec_func)(char **exec_argv);\n+\n void qemu_system_reset_request(ShutdownCause reason);\n void qemu_system_suspend_request(void);\n void qemu_register_suspend_notifier(Notifier *notifier);\n@@ -91,6 +93,7 @@ void qemu_register_wakeup_support(void);\n void qemu_system_shutdown_request_with_code(ShutdownCause reason,\n int exit_code);\n void qemu_system_shutdown_request(ShutdownCause reason);\n+void qemu_system_exec_request(qemu_exec_func func, const strList *args);\n void qemu_system_powerdown_request(void);\n void qemu_register_powerdown_notifier(Notifier *notifier);\n void qemu_register_shutdown_notifier(Notifier *notifier);\ndiff --git a/system/runstate.c b/system/runstate.c\nindex ec32e27..afc56e4 100644\n--- a/system/runstate.c\n+++ b/system/runstate.c\n@@ -40,6 +40,7 @@\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-run-state.h\"\n #include \"qapi/qapi-events-run-state.h\"\n+#include \"qapi/type-helpers.h\"\n #include \"qemu/accel.h\"\n #include \"qemu/error-report.h\"\n #include \"qemu/job.h\"\n@@ -400,6 +401,8 @@ static NotifierList wakeup_notifiers =\n static NotifierList shutdown_notifiers =\n NOTIFIER_LIST_INITIALIZER(shutdown_notifiers);\n static uint32_t wakeup_reason_mask = ~(1 << QEMU_WAKEUP_REASON_NONE);\n+qemu_exec_func exec_func;\n+static char **exec_argv;\n \n ShutdownCause qemu_shutdown_requested_get(void)\n {\n@@ -416,6 +419,11 @@ static int qemu_shutdown_requested(void)\n return qatomic_xchg(&shutdown_requested, SHUTDOWN_CAUSE_NONE);\n }\n \n+static int qemu_exec_requested(void)\n+{\n+ return exec_argv != NULL;\n+}\n+\n static void qemu_kill_report(void)\n {\n if (!qtest_driver() && shutdown_signal) {\n@@ -693,6 +701,23 @@ void qemu_system_shutdown_request(ShutdownCause reason)\n qemu_notify_event();\n }\n \n+static void qemu_system_exec(void)\n+{\n+ exec_func(exec_argv);\n+\n+ /* exec failed */\n+ g_strfreev(exec_argv);\n+ exec_argv = NULL;\n+ exec_func = NULL;\n+}\n+\n+void qemu_system_exec_request(qemu_exec_func func, const strList *args)\n+{\n+ exec_func = func;\n+ exec_argv = strv_from_str_list(args);\n+ qemu_notify_event();\n+}\n+\n static void qemu_system_powerdown(void)\n {\n qapi_event_send_powerdown();\n@@ -739,6 +764,10 @@ static bool main_loop_should_exit(int *status)\n if (qemu_suspend_requested()) {\n qemu_system_suspend();\n }\n+ if (qemu_exec_requested()) {\n+ qemu_system_exec();\n+ return false;\n+ }\n request = qemu_shutdown_requested();\n if (request) {\n qemu_kill_report();\n","prefixes":["V2","08/11"]}