{"id":189840,"url":"http://patchwork.ozlabs.org/api/patches/189840/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/50718E45.1070706@linux.intel.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<50718E45.1070706@linux.intel.com>","list_archive_url":null,"date":"2012-10-07T14:14:29","name":"Fix PTP dependencies: explicitly select all the possible dependencies.","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"b767899acfbe8cb5d2caa4505fd743a0d3271cf2","submitter":{"id":16954,"url":"http://patchwork.ozlabs.org/api/people/16954/?format=json","name":"Haicheng Li","email":"haicheng.li@linux.intel.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/50718E45.1070706@linux.intel.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/189840/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/189840/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 456472C0189\n\tfor ;\n\tMon, 8 Oct 2012 01:14:39 +1100 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753055Ab2JGOOf (ORCPT );\n\tSun, 7 Oct 2012 10:14:35 -0400","from mga01.intel.com ([192.55.52.88]:45103 \"EHLO mga01.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750973Ab2JGOOc (ORCPT );\n\tSun, 7 Oct 2012 10:14:32 -0400","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 07 Oct 2012 07:14:31 -0700","from unknown (HELO hli22-desktop.sh.intel.com) ([10.239.77.107])\n\tby fmsmga001.fm.intel.com with ESMTP; 07 Oct 2012 07:14:30 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"4.80,547,1344236400\"; d=\"scan'208\";a=\"230944232\"","Message-ID":"<50718E45.1070706@linux.intel.com>","Date":"Sun, 07 Oct 2012 22:14:29 +0800","From":"Haicheng Li ","User-Agent":"Mozilla/5.0 (X11; U; Linux i686; en-US;\n\trv:1.9.2.28) Gecko/20120306 Thunderbird/3.1.20","MIME-Version":"1.0","To":"David Miller ","CC":"fengguang.wu@intel.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"[PATCH] Fix PTP dependencies: explicitly select all the possible\n\tdependencies.","References":"<50703B1B.2040705@linux.intel.com>\t<20121006.102132.1497404004255213029.davem@davemloft.net>\t<50706885.1030908@linux.intel.com>\n\t<20121006.171748.734171045678392820.davem@davemloft.net>","In-Reply-To":"<20121006.171748.734171045678392820.davem@davemloft.net>","Content-Type":"text/plain; charset=ISO-8859-1; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Fengguang reported a kernel build failure as following:\ndrivers/built-in.o: In function `pch_gbe_ioctl':\npch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write'\npch_gbe_main.c:(.text+0x510393): undefined reference to `pch_ch_control_write'\npch_gbe_main.c:(.text+0x5103b3): undefined reference to `pch_ch_control_write'\n...\n\nIt's a regression by commit da1586461. The root cause is that\nthe CONFIG_PPS is not set there, consequently CONFIG_PTP_1588_CLOCK\ncan not be set anyway, which finally causes ptp_pch and pch_gbe_main\nbuild failures.\n\nAs David prefers to use *select* to fix such module co-dependency issues,\nthis patch explicitly selects all the possible dependencies of PCH_PTP.\n\nReported-by: Fengguang Wu \nReviewed-by: David S. Miller \nSigned-off-by: Haicheng Li \n---\n drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)","diff":"diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig \nb/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig\nindex 9730241..5296cc8 100644\n--- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig\n+++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig\n@@ -26,6 +26,9 @@ if PCH_GBE\n config PCH_PTP\n \tbool \"PCH PTP clock support\"\n \tdefault n\n+\tdepends on EXPERIMENTAL\n+\tselect PPS\n+\tselect PTP_1588_CLOCK\n \tselect PTP_1588_CLOCK_PCH\n \t---help---\n \t Say Y here if you want to use Precision Time Protocol (PTP) in the\n","prefixes":[]}