{"id":1882144,"url":"http://patchwork.ozlabs.org/api/patches/1882144/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20240103173349.398526-38-alex.bennee@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20240103173349.398526-38-alex.bennee@linaro.org>","list_archive_url":null,"date":"2024-01-03T17:33:43","name":"[v2,37/43] gdbstub: expose api to find registers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7e1f5c2ea5ec443f88f568597b295d0a33207018","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20240103173349.398526-38-alex.bennee@linaro.org/mbox/","series":[{"id":388742,"url":"http://patchwork.ozlabs.org/api/series/388742/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=388742","date":"2024-01-03T17:33:08","name":"testing and plugin updates for 9.0 (pre-PR)","version":2,"mbox":"http://patchwork.ozlabs.org/series/388742/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1882144/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1882144/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=YzclKS91;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4T4xzl6VyJz1yQ5\n\tfor ; Thu, 4 Jan 2024 04:49:07 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1rL5DP-0007fH-IQ; Wed, 03 Jan 2024 12:39:39 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1rL5DB-0006Ys-Re\n for qemu-devel@nongnu.org; Wed, 03 Jan 2024 12:39:26 -0500","from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1rL5Cx-0000fe-RY\n for qemu-devel@nongnu.org; Wed, 03 Jan 2024 12:39:24 -0500","by mail-wr1-x42d.google.com with SMTP id\n ffacd0b85a97d-3367632ce7bso9142545f8f.2\n for ; Wed, 03 Jan 2024 09:39:11 -0800 (PST)","from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id\n j18-20020a5d5652000000b00336ca349bdesm21896679wrw.47.2024.01.03.09.39.06\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 03 Jan 2024 09:39:08 -0800 (PST)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 1FA005F9D3;\n Wed, 3 Jan 2024 17:33:53 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1704303550; x=1704908350; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=s7b3xpykHeaHl4suIRJtcydNJ+7RVLNIDOZxUbbJygc=;\n b=YzclKS91ROCiEUliPREbJ5vhRAlB73+Wjwf5IUCj09NEb4igPTjVwdzZtGqYJyNB0j\n pKngCV8XMGc+JaptJLXYKK5bfZ9EcjbIiza2IvHSZILsb9t8PUjGDnYYGfoWDntAQwy8\n leW35p4ZsWi+18Ui7IF7BaxMSF18azdmtbT2FhYyjGNLTq9dXRBwKxH8eRrYWuREFdgt\n iTfKDQ6sxNCEIfvqPLaxXZztRpUBafpsmJXIhi3PjaqApHPscXEvhGfNOEcmTVWYvwCN\n 5WY2qMZX+NwIxFpC3l43/WT+S0zQUES/hc/kteddsPrrrTkVdG80dZrg6wlnf692WfyC\n 1Qcw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1704303550; x=1704908350;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=s7b3xpykHeaHl4suIRJtcydNJ+7RVLNIDOZxUbbJygc=;\n b=IlIuhKZIX0ye5aLntQtt65MzicjHda5E9oaWShT3KijD0q4d5w6+TH5uJECagl7Y4h\n TLE10MYk7lr9SGHA+ym8ZTxqQ7SHBHJ/V/c6LIzH5nSAx5AOIa1nUG3PtF7r60nreKBC\n Ya1Td+XUQignLXKu/Brfgw9PyHD7W8oZB68091gxhQKj8l2xgbn4+PXOfcEWMRgr2+HD\n nF+vZrHusnkApKux8P3sjAoshm7ygMtp+4dsQfOh5hWzUDvR0qxMe55k08nz6d8hsXTN\n Nm2st89xwjZjlfsD0MupAHd4ByKzKeabunjEHedvV+CyTKmjX/TAZgIVRv5HaHtkiEn9\n PNyw==","X-Gm-Message-State":"AOJu0YzAXqCIhyutvJspSbCRMQnMQ3tI/HBERnXWUSKYheNhferxG0p7\n VZ90Kvh7jTvDAINMrhd8ye8lH4YxAUpO8Q==","X-Google-Smtp-Source":"\n AGHT+IFhVN5CUKKwTQpPFIkvofPSf4XwbYH6uuKyBdKo+vTtyQ3x8fc2E3p+z7+XbMrRJtLtJWYynA==","X-Received":"by 2002:a05:6000:1845:b0:337:39ee:2b85 with SMTP id\n c5-20020a056000184500b0033739ee2b85mr3828333wri.104.1704303550198;\n Wed, 03 Jan 2024 09:39:10 -0800 (PST)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,\n Richard Henderson ,\n Song Gao ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n David Hildenbrand , Aurelien Jarno ,\n Yoshinori Sato ,\n Yanan Wang , Bin Meng ,\n Laurent Vivier , Michael Rolnik ,\n Alexandre Iooss , David Woodhouse ,\n Laurent Vivier , Paolo Bonzini ,\n Brian Cain ,\n Daniel Henrique Barboza ,\n Beraldo Leal , Paul Durrant ,\n Mahmoud Mandour , Thomas Huth ,\n Liu Zhiwei , Cleber Rosa ,\n kvm@vger.kernel.org, Peter Maydell ,\n Wainer dos Santos Moschetta , =?utf-8?q?Alex_Benn?=\n\t=?utf-8?q?=C3=A9e?= , qemu-arm@nongnu.org,\n Weiwei Li ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n John Snow ,\n Daniel Henrique Barboza ,\n Nicholas Piggin , Palmer Dabbelt ,\n Marcel Apfelbaum ,\n Ilya Leoshkevich ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n \"Edgar E. Iglesias\" ,\n Eduardo Habkost ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Alistair Francis ,\n Akihiko Odaki ","Subject":"[PATCH v2 37/43] gdbstub: expose api to find registers","Date":"Wed, 3 Jan 2024 17:33:43 +0000","Message-Id":"<20240103173349.398526-38-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20240103173349.398526-1-alex.bennee@linaro.org>","References":"<20240103173349.398526-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42d;\n envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Expose an internal API to QEMU to return all the registers for a vCPU.\nThe list containing the details required to called gdb_read_register().\n\nBased-on: <20231025093128.33116-15-akihiko.odaki@daynix.com>\nCc: Akihiko Odaki \nSigned-off-by: Alex Bennée \n\n---\nv2\n - just make gdb_get_register_list return everything for a vCPU\n\nvAJB:\n\nThis principle difference is the find registers is a single call which\ncan return a) multiple registers and b) is agnostic to the gdb\nfeature. This is because I haven't so far found any duplicate\nregisters in the system so I thing the regname by itself should be\nenough. However I do expose the gdb feature name in case the caller\nwants to do some additional filtering.\n---\n include/exec/gdbstub.h | 47 +++++++++++++++++++++++++++++++++++\n gdbstub/gdbstub.c | 56 +++++++++++++++++++++++++++++++++++++++++-\n 2 files changed, 102 insertions(+), 1 deletion(-)","diff":"diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h\nindex da9ddfe54c5..7bddea8259e 100644\n--- a/include/exec/gdbstub.h\n+++ b/include/exec/gdbstub.h\n@@ -111,6 +111,53 @@ void gdb_feature_builder_end(const GDBFeatureBuilder *builder);\n */\n const GDBFeature *gdb_find_static_feature(const char *xmlname);\n \n+/**\n+ * gdb_find_feature() - Find a feature associated with a CPU.\n+ * @cpu: The CPU associated with the feature.\n+ * @name: The feature's name.\n+ *\n+ * Return: The feature's number.\n+ */\n+int gdb_find_feature(CPUState *cpu, const char *name);\n+\n+/**\n+ * gdb_find_feature_register() - Find a register associated with a CPU.\n+ * @cpu: The CPU associated with the register.\n+ * @feature: The feature's number returned by gdb_find_feature().\n+ * @name: The register's name.\n+ *\n+ * Return: The register's number.\n+ */\n+int gdb_find_feature_register(CPUState *cpu, int feature, const char *name);\n+\n+/**\n+ * gdb_read_register() - Read a register associated with a CPU.\n+ * @cpu: The CPU associated with the register.\n+ * @buf: The buffer that the read register will be appended to.\n+ * @reg: The register's number returned by gdb_find_feature_register().\n+ *\n+ * Return: The number of read bytes.\n+ */\n+int gdb_read_register(CPUState *cpu, GByteArray *buf, int reg);\n+\n+/**\n+ * typedef GDBRegDesc - a register description from gdbstub\n+ */\n+typedef struct {\n+ int gdb_reg;\n+ const char *name;\n+ const char *feature_name;\n+} GDBRegDesc;\n+\n+/**\n+ * gdb_get_register_list() - Return list of all registers for CPU\n+ * @cpu: The CPU being searched\n+ *\n+ * Returns a GArray of GDBRegDesc, caller frees array but not the\n+ * const strings.\n+ */\n+GArray *gdb_get_register_list(CPUState *cpu);\n+\n void gdb_set_stop_cpu(CPUState *cpu);\n \n /* in gdbstub-xml.c, generated by scripts/feature_to_c.py */\ndiff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c\nindex 420ab2a3766..b0230138246 100644\n--- a/gdbstub/gdbstub.c\n+++ b/gdbstub/gdbstub.c\n@@ -490,7 +490,61 @@ const GDBFeature *gdb_find_static_feature(const char *xmlname)\n g_assert_not_reached();\n }\n \n-static int gdb_read_register(CPUState *cpu, GByteArray *buf, int reg)\n+int gdb_find_feature(CPUState *cpu, const char *name)\n+{\n+ GDBRegisterState *r;\n+\n+ for (guint i = 0; i < cpu->gdb_regs->len; i++) {\n+ r = &g_array_index(cpu->gdb_regs, GDBRegisterState, i);\n+ if (!strcmp(name, r->feature->name)) {\n+ return i;\n+ }\n+ }\n+\n+ return -1;\n+}\n+\n+int gdb_find_feature_register(CPUState *cpu, int feature, const char *name)\n+{\n+ GDBRegisterState *r;\n+\n+ r = &g_array_index(cpu->gdb_regs, GDBRegisterState, feature);\n+\n+ for (int i = 0; i < r->feature->num_regs; i++) {\n+ if (r->feature->regs[i] && !strcmp(name, r->feature->regs[i])) {\n+ return r->base_reg + i;\n+ }\n+ }\n+\n+ return -1;\n+}\n+\n+GArray *gdb_get_register_list(CPUState *cpu)\n+{\n+ GArray *results = g_array_new(true, true, sizeof(GDBRegDesc));\n+\n+ /* registers are only available once the CPU is initialised */\n+ if (!cpu->gdb_regs) {\n+ return results;\n+ }\n+\n+ for (int f = 0; f < cpu->gdb_regs->len; f++) {\n+ GDBRegisterState *r = &g_array_index(cpu->gdb_regs, GDBRegisterState, f);\n+ for (int i = 0; i < r->feature->num_regs; i++) {\n+ const char *name = r->feature->regs[i];\n+ GDBRegDesc desc = {\n+ r->base_reg + i,\n+ name,\n+ r->feature->name\n+ };\n+ g_array_append_val(results, desc);\n+ }\n+ }\n+\n+ return results;\n+}\n+\n+int gdb_read_register(CPUState *cpu, GByteArray *buf, int reg)\n {\n CPUClass *cc = CPU_GET_CLASS(cpu);\n GDBRegisterState *r;\n","prefixes":["v2","37/43"]}