{"id":1882072,"url":"http://patchwork.ozlabs.org/api/patches/1882072/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20240103173349.398526-5-alex.bennee@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20240103173349.398526-5-alex.bennee@linaro.org>","list_archive_url":null,"date":"2024-01-03T17:33:10","name":"[v2,04/43] chardev: use bool for fe_is_open","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"48b1054dbd8f3da36cc02a6430f523c26f6040e4","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20240103173349.398526-5-alex.bennee@linaro.org/mbox/","series":[{"id":388742,"url":"http://patchwork.ozlabs.org/api/series/388742/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=388742","date":"2024-01-03T17:33:08","name":"testing and plugin updates for 9.0 (pre-PR)","version":2,"mbox":"http://patchwork.ozlabs.org/series/388742/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1882072/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1882072/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=j7R+G2pJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4T4xkC20Hlz1ydb\n\tfor ; Thu, 4 Jan 2024 04:37:23 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1rL58A-0003cz-D1; Wed, 03 Jan 2024 12:34:14 -0500","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1rL580-0003VI-JR\n for qemu-devel@nongnu.org; Wed, 03 Jan 2024 12:34:06 -0500","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1rL57p-0002Nz-Ub\n for qemu-devel@nongnu.org; Wed, 03 Jan 2024 12:34:01 -0500","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-40d5ac76667so55663305e9.1\n for ; Wed, 03 Jan 2024 09:33:53 -0800 (PST)","from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id\n fl27-20020a05600c0b9b00b0040d2dfb10e0sm2979265wmb.11.2024.01.03.09.33.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 03 Jan 2024 09:33:50 -0800 (PST)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id AB9515F933;\n Wed, 3 Jan 2024 17:33:49 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1704303231; x=1704908031; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rOpjk5Xc89URXPry+uTcPrYjjlL9ZRbEnDqtNUUFVo4=;\n b=j7R+G2pJWTMP9nz9N56OlOSgXJYdnt1QbdmbCheotup826UTwL7TO3/sUqhmPQ6eNG\n fSrZ2lIHg08wRb+613ubQ47Pu4cy743voWDbKgzXahU4ZSqIeQmMMCZcXoycVf7L8O4g\n ikIFEzJ5PXzlMSqj24sWKAtO/bX3DmaCKwajVfp5DmdBg7hNmaVzBBoRg+mdMOYH/t5l\n 7dwz4ECfIlCDFJ0qZP0+ydHpaRQYtqWgjEjWWjVeGy5DmEiJIJp7xJjbVK96yZxFK550\n f6aWCJy3NJHYphH7mlDBE/wFKyfb7j/MLfW9B5ufYOliv91lTXo/gwP+Mclm+lPbKOry\n bNjQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1704303231; x=1704908031;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=rOpjk5Xc89URXPry+uTcPrYjjlL9ZRbEnDqtNUUFVo4=;\n b=PX6VmDBOq+q/iVeA9WLPBWZfdbIMQT6BQAHKu1ffgd6gBTOT64kHHuVsQzQACQpkaW\n hDc2yqE2TPcNrfo1WjnLfE/n0m1ntgbkKPuY6OLfTFlegWNn+ldBmKfWVl0Z/gO7If/5\n 3NyhfhhMY/WA9NSm6OLGU7eHOUn0jDcVmJB4BP9avcbV5jWfE/DECFTzw4sxwsvDswWz\n S7EB/vYR13I4UIGF2awqbt//Ze/UeF3kOv1bSwLx8puWvPpIbFinBIbJlZBggK6zFbVq\n 8yT511Bskqe4/O1Im8tNta0k2kYpxzh2lIsqOBqPMhgV2DPnonakqqT0NOsZeyWxnlVe\n i1qg==","X-Gm-Message-State":"AOJu0Yzv0pK3EPnjTGR9idUa8ADVd3rHjwhlw1cWaJFiYbJ6ksmJOpc/\n rijm3tHD9GHlE80Jxj+P51cKIqmL3v8kMA==","X-Google-Smtp-Source":"\n AGHT+IEhbukIbMJxe0XeRt2lHobV2JbuWL9JZcjldNC8OY0732Jbqq6ubAvn3PMQTDTFrXUf5ogLhA==","X-Received":"by 2002:a05:600c:a003:b0:404:4b6f:d70d with SMTP id\n jg3-20020a05600ca00300b004044b6fd70dmr11754074wmb.17.1704303231383;\n Wed, 03 Jan 2024 09:33:51 -0800 (PST)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,\n Richard Henderson ,\n Song Gao ,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n David Hildenbrand , Aurelien Jarno ,\n Yoshinori Sato ,\n Yanan Wang , Bin Meng ,\n Laurent Vivier , Michael Rolnik ,\n Alexandre Iooss , David Woodhouse ,\n Laurent Vivier , Paolo Bonzini ,\n Brian Cain ,\n Daniel Henrique Barboza ,\n Beraldo Leal , Paul Durrant ,\n Mahmoud Mandour , Thomas Huth ,\n Liu Zhiwei , Cleber Rosa ,\n kvm@vger.kernel.org, Peter Maydell ,\n Wainer dos Santos Moschetta , =?utf-8?q?Alex_Benn?=\n\t=?utf-8?q?=C3=A9e?= , qemu-arm@nongnu.org,\n Weiwei Li ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n John Snow ,\n Daniel Henrique Barboza ,\n Nicholas Piggin , Palmer Dabbelt ,\n Marcel Apfelbaum ,\n Ilya Leoshkevich ,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n \"Edgar E. Iglesias\" ,\n Eduardo Habkost ,\n Pierrick Bouvier , qemu-riscv@nongnu.org,\n Alistair Francis ","Subject":"[PATCH v2 04/43] chardev: use bool for fe_is_open","Date":"Wed, 3 Jan 2024 17:33:10 +0000","Message-Id":"<20240103173349.398526-5-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20240103173349.398526-1-alex.bennee@linaro.org>","References":"<20240103173349.398526-1-alex.bennee@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The function qemu_chr_fe_init already treats be->fe_open as a bool and\nif it acts like a bool it should be one. While we are at it make the\nvariable name more descriptive and add kdoc decorations.\n\nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: Alex Bennée \nMessage-Id: <20231211145959.93759-1-alex.bennee@linaro.org>\n\n---\nv2\n - rename to fe_is_open at f4bug's request\n---\n include/chardev/char-fe.h | 19 ++++++++++++-------\n chardev/char-fe.c | 16 ++++++++--------\n chardev/char.c | 2 +-\n 3 files changed, 21 insertions(+), 16 deletions(-)","diff":"diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h\nindex 0ff6f875116..ecef1828355 100644\n--- a/include/chardev/char-fe.h\n+++ b/include/chardev/char-fe.h\n@@ -7,8 +7,12 @@\n typedef void IOEventHandler(void *opaque, QEMUChrEvent event);\n typedef int BackendChangeHandler(void *opaque);\n \n-/* This is the backend as seen by frontend, the actual backend is\n- * Chardev */\n+/**\n+ * struct CharBackend - back end as seen by front end\n+ * @fe_is_open: the front end is ready for IO\n+ *\n+ * The actual backend is Chardev\n+ */\n struct CharBackend {\n Chardev *chr;\n IOEventHandler *chr_event;\n@@ -17,7 +21,7 @@ struct CharBackend {\n BackendChangeHandler *chr_be_change;\n void *opaque;\n int tag;\n- int fe_open;\n+ bool fe_is_open;\n };\n \n /**\n@@ -156,12 +160,13 @@ void qemu_chr_fe_set_echo(CharBackend *be, bool echo);\n \n /**\n * qemu_chr_fe_set_open:\n+ * @be: a CharBackend\n+ * @is_open: the front end open status\n *\n- * Set character frontend open status. This is an indication that the\n- * front end is ready (or not) to begin doing I/O.\n- * Without associated Chardev, do nothing.\n+ * This is an indication that the front end is ready (or not) to begin\n+ * doing I/O. Without associated Chardev, do nothing.\n */\n-void qemu_chr_fe_set_open(CharBackend *be, int fe_open);\n+void qemu_chr_fe_set_open(CharBackend *be, bool is_open);\n \n /**\n * qemu_chr_fe_printf:\ndiff --git a/chardev/char-fe.c b/chardev/char-fe.c\nindex 7789f7be9c8..20222a4cad5 100644\n--- a/chardev/char-fe.c\n+++ b/chardev/char-fe.c\n@@ -211,7 +211,7 @@ bool qemu_chr_fe_init(CharBackend *b, Chardev *s, Error **errp)\n }\n }\n \n- b->fe_open = false;\n+ b->fe_is_open = false;\n b->tag = tag;\n b->chr = s;\n return true;\n@@ -257,7 +257,7 @@ void qemu_chr_fe_set_handlers_full(CharBackend *b,\n bool sync_state)\n {\n Chardev *s;\n- int fe_open;\n+ bool fe_open;\n \n s = b->chr;\n if (!s) {\n@@ -265,10 +265,10 @@ void qemu_chr_fe_set_handlers_full(CharBackend *b,\n }\n \n if (!opaque && !fd_can_read && !fd_read && !fd_event) {\n- fe_open = 0;\n+ fe_open = false;\n remove_fd_in_watch(s);\n } else {\n- fe_open = 1;\n+ fe_open = true;\n }\n b->chr_can_read = fd_can_read;\n b->chr_read = fd_read;\n@@ -336,7 +336,7 @@ void qemu_chr_fe_set_echo(CharBackend *be, bool echo)\n }\n }\n \n-void qemu_chr_fe_set_open(CharBackend *be, int fe_open)\n+void qemu_chr_fe_set_open(CharBackend *be, bool is_open)\n {\n Chardev *chr = be->chr;\n \n@@ -344,12 +344,12 @@ void qemu_chr_fe_set_open(CharBackend *be, int fe_open)\n return;\n }\n \n- if (be->fe_open == fe_open) {\n+ if (be->fe_is_open == is_open) {\n return;\n }\n- be->fe_open = fe_open;\n+ be->fe_is_open = is_open;\n if (CHARDEV_GET_CLASS(chr)->chr_set_fe_open) {\n- CHARDEV_GET_CLASS(chr)->chr_set_fe_open(chr, fe_open);\n+ CHARDEV_GET_CLASS(chr)->chr_set_fe_open(chr, is_open);\n }\n }\n \ndiff --git a/chardev/char.c b/chardev/char.c\nindex 996a024c7a2..0653b112e92 100644\n--- a/chardev/char.c\n+++ b/chardev/char.c\n@@ -750,7 +750,7 @@ static int qmp_query_chardev_foreach(Object *obj, void *data)\n \n value->label = g_strdup(chr->label);\n value->filename = g_strdup(chr->filename);\n- value->frontend_open = chr->be && chr->be->fe_open;\n+ value->frontend_open = chr->be && chr->be->fe_is_open;\n \n QAPI_LIST_PREPEND(*list, value);\n \n","prefixes":["v2","04/43"]}