{"id":1850814,"url":"http://patchwork.ozlabs.org/api/patches/1850814/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20231018130716.286638-24-thuth@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20231018130716.286638-24-thuth@redhat.com>","list_archive_url":null,"date":"2023-10-18T13:07:14","name":"[PULL,23/25] target/s390x/kvm: Turn KVM_CAP_SYNC_REGS into a hard requirement","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2ea78edb2eb1593c60bcdf081b9f5111213d7999","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/?format=json","name":"Thomas Huth","email":"thuth@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20231018130716.286638-24-thuth@redhat.com/mbox/","series":[{"id":378180,"url":"http://patchwork.ozlabs.org/api/series/378180/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=378180","date":"2023-10-18T13:06:52","name":"[PULL,01/25] qapi: machine.json: change docs regarding CPU topology","version":1,"mbox":"http://patchwork.ozlabs.org/series/378180/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1850814/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1850814/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=H+DQXkza;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4S9WVw5vW1z20cx\n\tfor ; Thu, 19 Oct 2023 00:13:12 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qt6IJ-0007F3-N6; Wed, 18 Oct 2023 09:09:03 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qt6HO-0004YU-Og\n for qemu-devel@nongnu.org; Wed, 18 Oct 2023 09:08:12 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qt6HI-00080o-Mx\n for qemu-devel@nongnu.org; Wed, 18 Oct 2023 09:08:03 -0400","from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-592-zr7iORA8PPi2Q-_WSYLg4w-1; Wed, 18 Oct 2023 09:07:58 -0400","from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA0781020203;\n Wed, 18 Oct 2023 13:07:57 +0000 (UTC)","from thuth-p1g4.redhat.com (unknown [10.39.192.109])\n by smtp.corp.redhat.com (Postfix) with ESMTP id DE26220268C8;\n Wed, 18 Oct 2023 13:07:56 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1697634480;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=oQAUStExdwPZFM614DvnkC/Yix30Ravls5bcvZOKzk8=;\n b=H+DQXkza2DDBxOssAXbx63ulHhjX4Bx3qy3wnqPz1so8YN6S20FW5kzCrdPqyVSBzOCOPE\n bArX+xTuzjXd03ukQIDwU36WYMHmQlHpMxQGzWeFayusFQQyavfku77K0kdaKfLIHfJjV7\n JcXGkbYTdZgBecH6271zRElsYXIPFMk=","X-MC-Unique":"zr7iORA8PPi2Q-_WSYLg4w-1","From":"Thomas Huth ","To":"qemu-devel@nongnu.org","Cc":"Stefan Hajnoczi , qemu-s390x@nongnu.org,\n Nina Schoetterl-Glausch ","Subject":"[PULL 23/25] target/s390x/kvm: Turn KVM_CAP_SYNC_REGS into a hard\n requirement","Date":"Wed, 18 Oct 2023 15:07:14 +0200","Message-ID":"<20231018130716.286638-24-thuth@redhat.com>","In-Reply-To":"<20231018130716.286638-1-thuth@redhat.com>","References":"<20231018130716.286638-1-thuth@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.11.54.4","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Since we already require at least kernel 3.15 in the s390x KVM code,\nwe can assume that the KVM_CAP_SYNC_REGS capability is always there.\nThus turn this into a hard requirement now.\n\nReviewed-by: Christian Borntraeger \nMessage-ID: <20231011080538.796999-2-thuth@redhat.com>\nSigned-off-by: Thomas Huth \n---\n target/s390x/kvm/kvm.c | 20 ++++++++++++++------\n 1 file changed, 14 insertions(+), 6 deletions(-)","diff":"diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c\nindex 2e43dc746f..068e9826e1 100644\n--- a/target/s390x/kvm/kvm.c\n+++ b/target/s390x/kvm/kvm.c\n@@ -338,21 +338,29 @@ int kvm_arch_get_default_type(MachineState *ms)\n \n int kvm_arch_init(MachineState *ms, KVMState *s)\n {\n+ int required_caps[] = {\n+ KVM_CAP_DEVICE_CTRL,\n+ KVM_CAP_SYNC_REGS,\n+ };\n+\n+ for (int i = 0; i < ARRAY_SIZE(required_caps); i++) {\n+ if (!kvm_check_extension(s, required_caps[i])) {\n+ error_report(\"KVM is missing capability #%d - \"\n+ \"please use kernel 3.15 or newer\", required_caps[i]);\n+ return -1;\n+ }\n+ }\n+\n object_class_foreach(ccw_machine_class_foreach, TYPE_S390_CCW_MACHINE,\n false, NULL);\n \n- if (!kvm_check_extension(kvm_state, KVM_CAP_DEVICE_CTRL)) {\n- error_report(\"KVM is missing capability KVM_CAP_DEVICE_CTRL - \"\n- \"please use kernel 3.15 or newer\");\n- return -1;\n- }\n if (!kvm_check_extension(s, KVM_CAP_S390_COW)) {\n error_report(\"KVM is missing capability KVM_CAP_S390_COW - \"\n \"unsupported environment\");\n return -1;\n }\n \n- cap_sync_regs = kvm_check_extension(s, KVM_CAP_SYNC_REGS);\n+ cap_sync_regs = true;\n cap_async_pf = kvm_check_extension(s, KVM_CAP_ASYNC_PF);\n cap_mem_op = kvm_check_extension(s, KVM_CAP_S390_MEM_OP);\n cap_mem_op_extension = kvm_check_extension(s, KVM_CAP_S390_MEM_OP_EXTENSION);\n","prefixes":["PULL","23/25"]}