{"id":1850812,"url":"http://patchwork.ozlabs.org/api/patches/1850812/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20231018130716.286638-23-thuth@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20231018130716.286638-23-thuth@redhat.com>","list_archive_url":null,"date":"2023-10-18T13:07:13","name":"[PULL,22/25] hw/s390x: Clean up global variable shadowing in quiesce_powerdown_req()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"800e69416a345a7435c8a772fec03c816813ba27","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/?format=json","name":"Thomas Huth","email":"thuth@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20231018130716.286638-23-thuth@redhat.com/mbox/","series":[{"id":378180,"url":"http://patchwork.ozlabs.org/api/series/378180/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=378180","date":"2023-10-18T13:06:52","name":"[PULL,01/25] qapi: machine.json: change docs regarding CPU topology","version":1,"mbox":"http://patchwork.ozlabs.org/series/378180/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1850812/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1850812/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NldHcAKb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4S9WT965RRz23jS\n\tfor ; Thu, 19 Oct 2023 00:11:41 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qt6IE-0006du-W5; Wed, 18 Oct 2023 09:08:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qt6HT-0004eJ-V4\n for qemu-devel@nongnu.org; Wed, 18 Oct 2023 09:08:14 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qt6HR-00083a-5u\n for qemu-devel@nongnu.org; Wed, 18 Oct 2023 09:08:10 -0400","from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-572-geX-YYx7NH-BRoFRG_0yVg-1; Wed, 18 Oct 2023 09:07:57 -0400","from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7F07788B7A6;\n Wed, 18 Oct 2023 13:07:56 +0000 (UTC)","from thuth-p1g4.redhat.com (unknown [10.39.192.109])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 083CD20268C8;\n Wed, 18 Oct 2023 13:07:54 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1697634488;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=GdJoVYhU7RQIhJeFF6OrBxeBGJUQ6x9Gmhs3GG8upeI=;\n b=NldHcAKbY2GML0F50KkJhxilLWz+iKoLg3H/Qg5OHIjLGrwecRMSBAbAJpFbV6wcXU6sBW\n Y/5A4tIvoW158qaaXtO7/5wB9iQiIymjmc6ZmMkYPGj9dpHiEDCEBKC5S08z0SKzy3/tar\n N7ddVJEgboCRkQM5ODszrx63xclOha0=","X-MC-Unique":"geX-YYx7NH-BRoFRG_0yVg-1","From":"Thomas Huth ","To":"qemu-devel@nongnu.org","Cc":"Stefan Hajnoczi , qemu-s390x@nongnu.org,\n Nina Schoetterl-Glausch ","Subject":"[PULL 22/25] hw/s390x: Clean up global variable shadowing in\n quiesce_powerdown_req()","Date":"Wed, 18 Oct 2023 15:07:13 +0200","Message-ID":"<20231018130716.286638-23-thuth@redhat.com>","In-Reply-To":"<20231018130716.286638-1-thuth@redhat.com>","References":"<20231018130716.286638-1-thuth@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.11.54.4","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Philippe Mathieu-Daudé \n\nFix:\n\n hw/s390x/sclpquiesce.c:90:22: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]\n QuiesceNotifier *qn = container_of(n, QuiesceNotifier, notifier);\n ^\n hw/s390x/sclpquiesce.c:86:3: note: previous declaration is here\n } qn;\n ^\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Eric Farman \nReviewed-by: David Hildenbrand \nReviewed-by: Thomas Huth \nMessage-ID: <20231009094747.54240-7-philmd@linaro.org>\nSigned-off-by: Thomas Huth \n---\n hw/s390x/sclpquiesce.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/s390x/sclpquiesce.c b/hw/s390x/sclpquiesce.c\nindex ce07b16884..a641089929 100644\n--- a/hw/s390x/sclpquiesce.c\n+++ b/hw/s390x/sclpquiesce.c\n@@ -78,12 +78,10 @@ static const VMStateDescription vmstate_sclpquiesce = {\n }\n };\n \n-typedef struct QuiesceNotifier QuiesceNotifier;\n-\n-static struct QuiesceNotifier {\n+typedef struct QuiesceNotifier {\n Notifier notifier;\n SCLPEvent *event;\n-} qn;\n+} QuiesceNotifier;\n \n static void quiesce_powerdown_req(Notifier *n, void *opaque)\n {\n@@ -97,6 +95,8 @@ static void quiesce_powerdown_req(Notifier *n, void *opaque)\n \n static int quiesce_init(SCLPEvent *event)\n {\n+ static QuiesceNotifier qn;\n+\n qn.notifier.notify = quiesce_powerdown_req;\n qn.event = event;\n \n","prefixes":["PULL","22/25"]}