{"id":1839941,"url":"http://patchwork.ozlabs.org/api/patches/1839941/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926201532.221152-7-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20230926201532.221152-7-vsementsov@yandex-team.ru>","list_archive_url":null,"date":"2023-09-26T20:15:30","name":"[v2,6/8] block/nvme: nvme_process_completion() fix bound for cid","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"453069e9f2e89f332ef120263bf21be55e967da4","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926201532.221152-7-vsementsov@yandex-team.ru/mbox/","series":[{"id":375000,"url":"http://patchwork.ozlabs.org/api/series/375000/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=375000","date":"2023-09-26T20:15:27","name":"coverity fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/375000/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1839941/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1839941/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=OMdfoqqR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Rw9yf4cf0z1yqV\n\tfor ; Wed, 27 Sep 2023 06:17:29 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlETb-0000Yj-2K; Tue, 26 Sep 2023 16:16:11 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlETY-0000XG-PW; Tue, 26 Sep 2023 16:16:08 -0400","from forwardcorp1b.mail.yandex.net ([178.154.239.136])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlETT-0002hc-N1; Tue, 26 Sep 2023 16:16:08 -0400","from mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net\n [IPv6:2a02:6b8:c12:550b:0:640:d49b:0])\n by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id 7B269607AC;\n Tue, 26 Sep 2023 23:16:00 +0300 (MSK)","from vsementsov-lin.. (unknown [2a02:6b8:b081:b41d::1:39])\n by mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id ZFWwvr0Oc0U0-s9ITwPhm; Tue, 26 Sep 2023 23:15:59 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1695759359;\n bh=Qr88yzO2svS1+rGVJi/Il3bOpU2quKc+o4WQ98vjCDU=;\n h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=OMdfoqqRbClO+a0Lxh+qA555LExXZUz1kW+44v3ZJ6KtgLi6YzFWGFWeNU6+OCaRZ\n KtKvYYC94GKbUSshOBe1sSPCHkYSbunGVoQQrznHHhJBKWYQ/3hPXPH7pE2ZgT49ll\n yUlYqzMF0EpP071m+W9PNJEQgkAYrT0gMtF5j0ec=","From":"Vladimir Sementsov-Ogievskiy ","To":"qemu-devel@nongnu.org","Cc":"pbonzini@redhat.com, vsementsov@yandex-team.ru, peter.maydell@linaro.org,\n yc-core@yandex-team.ru, davydov-max@yandex-team.ru, stefanha@redhat.com,\n alex.chen@huawei.com, euler.robot@huawei.com, Fam Zheng ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Kevin Wolf , Hanna Reitz ,\n qemu-block@nongnu.org (open list:NVMe Block Driver)","Subject":"[PATCH v2 6/8] block/nvme: nvme_process_completion() fix bound for\n cid","Date":"Tue, 26 Sep 2023 23:15:30 +0300","Message-Id":"<20230926201532.221152-7-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230926201532.221152-1-vsementsov@yandex-team.ru>","References":"<20230926201532.221152-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.154.239.136;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"NVMeQueuePair::reqs has length NVME_NUM_REQS, which less than\nNVME_QUEUE_SIZE by 1.\n\nFixes: 1086e95da17050 (\"block/nvme: switch to a NVMeRequest freelist\")\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n\nCc: stefanha@redhat.com\nCc: alex.chen@huawei.com\nCc: euler.robot@huawei.com\n\nNote, that there was similar patch in the past:\n https://patchew.org/QEMU/20201208144452.91172-1-alex.chen@huawei.com/\nI still think, that using NVME_NUM_REQS is better here.\n\n block/nvme.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/block/nvme.c b/block/nvme.c\nindex b6e95f0b7e..0faedf3072 100644\n--- a/block/nvme.c\n+++ b/block/nvme.c\n@@ -416,9 +416,10 @@ static bool nvme_process_completion(NVMeQueuePair *q)\n q->cq_phase = !q->cq_phase;\n }\n cid = le16_to_cpu(c->cid);\n- if (cid == 0 || cid > NVME_QUEUE_SIZE) {\n- warn_report(\"NVMe: Unexpected CID in completion queue: %\"PRIu32\", \"\n- \"queue size: %u\", cid, NVME_QUEUE_SIZE);\n+ if (cid == 0 || cid > NVME_NUM_REQS) {\n+ warn_report(\"NVMe: Unexpected CID in completion queue: %\" PRIu32\n+ \", should be within: 1..%u inclusively\", cid,\n+ NVME_NUM_REQS);\n continue;\n }\n trace_nvme_complete_command(s, q->index, cid);\n","prefixes":["v2","6/8"]}