{"id":1839937,"url":"http://patchwork.ozlabs.org/api/patches/1839937/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926201532.221152-9-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20230926201532.221152-9-vsementsov@yandex-team.ru>","list_archive_url":null,"date":"2023-09-26T20:15:32","name":"[v2,8/8] io/channel-socket: qio_channel_socket_flush(): improve msg validation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2c8657046ddf270f725e18731d981d3b5c18bcb6","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926201532.221152-9-vsementsov@yandex-team.ru/mbox/","series":[{"id":375000,"url":"http://patchwork.ozlabs.org/api/series/375000/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=375000","date":"2023-09-26T20:15:27","name":"coverity fixes","version":2,"mbox":"http://patchwork.ozlabs.org/series/375000/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1839937/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1839937/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=mZM5/tXe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Rw9yf4WTRz1ypM\n\tfor ; Wed, 27 Sep 2023 06:17:29 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlETe-0000Zf-Du; Tue, 26 Sep 2023 16:16:15 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlETZ-0000Y4-NT\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:16:09 -0400","from forwardcorp1b.mail.yandex.net ([178.154.239.136])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1qlETU-0002jI-VX\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 16:16:09 -0400","from mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net\n [IPv6:2a02:6b8:c12:550b:0:640:d49b:0])\n by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id 7D9F96071F;\n Tue, 26 Sep 2023 23:16:02 +0300 (MSK)","from vsementsov-lin.. (unknown [2a02:6b8:b081:b41d::1:39])\n by mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id ZFWwvr0Oc0U0-y1u5B3CV; Tue, 26 Sep 2023 23:16:01 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1695759361;\n bh=ou8GZudm1QVqrgm1YLFWVUTc0Kur2k7RwKAHeFH0CfY=;\n h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=mZM5/tXe7cjK24YfsmPSl0eoQ+fJXBWeooqSuTBntaZeseLzWaLyIw/1JpMuuPqPv\n Ko18HD7wMSIy37ebpf4jxS4/3w89kZAph3dMYITZIrzrVDqZxZi6DsQZ4PSYF+TtHr\n qi0zGetElc/TqXwFOXSz+0YtAnLBDfQHZ7yrSoPY=","From":"Vladimir Sementsov-Ogievskiy ","To":"qemu-devel@nongnu.org","Cc":"pbonzini@redhat.com, vsementsov@yandex-team.ru, peter.maydell@linaro.org,\n yc-core@yandex-team.ru, davydov-max@yandex-team.ru, =?utf-8?q?Daniel_P=2E_B?=\n\t=?utf-8?q?errang=C3=A9?= ","Subject":"[PATCH v2 8/8] io/channel-socket: qio_channel_socket_flush(): improve\n msg validation","Date":"Tue, 26 Sep 2023 23:15:32 +0300","Message-Id":"<20230926201532.221152-9-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20230926201532.221152-1-vsementsov@yandex-team.ru>","References":"<20230926201532.221152-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.154.239.136;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"For SO_EE_ORIGIN_ZEROCOPY the 32-bit notification range is encoded\nas [ee_info, ee_data] inclusively, so ee_info should be less or\nequal to ee_data.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n io/channel-socket.c | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/io/channel-socket.c b/io/channel-socket.c\nindex 02ffb51e99..3a899b0608 100644\n--- a/io/channel-socket.c\n+++ b/io/channel-socket.c\n@@ -782,6 +782,11 @@ static int qio_channel_socket_flush(QIOChannel *ioc,\n \"Error not from zero copy\");\n return -1;\n }\n+ if (serr->ee_data < serr->ee_info) {\n+ error_setg_errno(errp, serr->ee_origin,\n+ \"Wrong notification bounds\");\n+ return -1;\n+ }\n \n /* No errors, count successfully finished sendmsg()*/\n sioc->zero_copy_sent += serr->ee_data - serr->ee_info + 1;\n","prefixes":["v2","8/8"]}