{"id":1839906,"url":"http://patchwork.ozlabs.org/api/patches/1839906/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926185738.277351-6-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20230926185738.277351-6-david@redhat.com>","list_archive_url":null,"date":"2023-09-26T18:57:25","name":"[v4,05/18] vhost: Return number of free memslots","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2359cab9481eff2046c6f6e9081c66e4846f007a","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926185738.277351-6-david@redhat.com/mbox/","series":[{"id":374991,"url":"http://patchwork.ozlabs.org/api/series/374991/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=374991","date":"2023-09-26T18:57:23","name":"virtio-mem: Expose device memory through multiple memslots","version":4,"mbox":"http://patchwork.ozlabs.org/series/374991/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1839906/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1839906/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cWDt9JaP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Rw8DZ0V8Wz1ypD\n\tfor ; Wed, 27 Sep 2023 04:59:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlDGo-00071I-Pu; Tue, 26 Sep 2023 14:58:54 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qlDGm-00070l-CC\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 14:58:53 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qlDGk-000328-UR\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 14:58:52 -0400","from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-257-mwRYvnN1NQ-DqiTJUuZQ_A-1; Tue, 26 Sep 2023 14:58:47 -0400","from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7DD852815E28;\n Tue, 26 Sep 2023 18:58:46 +0000 (UTC)","from t14s.fritz.box (unknown [10.39.192.33])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 71D102026D4B;\n Tue, 26 Sep 2023 18:58:38 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1695754730;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Rwy8XG8etvevYx4+uyycYPxkPB6mvZoERehXXpRCdCg=;\n b=cWDt9JaPNux2BT6Zn8QiM/0RWlFiDR5WrhFYkCRFGQQ0ylR79j6PWVxbg6CMDIuAXogxLh\n sGk4K3tlvKqAjhwVxgRMppKwXGW2oI2ICfG4cbkdalUb1pYm2LLfVDSB/z2l5MC3cnwL9/\n dB2S4f1t4cJZEhYsSZrSpAfVzC7s3OM=","X-MC-Unique":"mwRYvnN1NQ-DqiTJUuZQ_A-1","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Cc":"David Hildenbrand , Paolo Bonzini ,\n Igor Mammedov ,\n Xiao Guangrong ,\n \"Michael S. Tsirkin\" , Peter Xu ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Eduardo Habkost ,\n Marcel Apfelbaum ,\n Yanan Wang , Michal Privoznik ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Gavin Shan , Alex Williamson ,\n Stefan Hajnoczi ,\n \"Maciej S . Szmigiero\" , kvm@vger.kernel.org,\n \"Maciej S . Szmigiero\" ","Subject":"[PATCH v4 05/18] vhost: Return number of free memslots","Date":"Tue, 26 Sep 2023 20:57:25 +0200","Message-ID":"<20230926185738.277351-6-david@redhat.com>","In-Reply-To":"<20230926185738.277351-1-david@redhat.com>","References":"<20230926185738.277351-1-david@redhat.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.1 on 10.11.54.4","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=david@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"12","X-Spam_score":"1.2","X-Spam_bar":"+","X-Spam_report":"(1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Let's return the number of free slots instead of only checking if there\nis a free slot. Required to support memory devices that consume multiple\nmemslots.\n\nThis is a preparation for memory devices that consume multiple memslots.\n\nReviewed-by: Maciej S. Szmigiero \nSigned-off-by: David Hildenbrand \n---\n hw/mem/memory-device.c | 2 +-\n hw/virtio/vhost-stub.c | 4 ++--\n hw/virtio/vhost.c | 4 ++--\n include/hw/virtio/vhost.h | 2 +-\n 4 files changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c\nindex 98e355c960..e09960744d 100644\n--- a/hw/mem/memory-device.c\n+++ b/hw/mem/memory-device.c\n@@ -63,7 +63,7 @@ static void memory_device_check_addable(MachineState *ms, MemoryRegion *mr,\n error_setg(errp, \"hypervisor has no free memory slots left\");\n return;\n }\n- if (!vhost_has_free_slot()) {\n+ if (!vhost_get_free_memslots()) {\n error_setg(errp, \"a used vhost backend has no free memory slots left\");\n return;\n }\ndiff --git a/hw/virtio/vhost-stub.c b/hw/virtio/vhost-stub.c\nindex aa858ef3fb..d53dd9d288 100644\n--- a/hw/virtio/vhost-stub.c\n+++ b/hw/virtio/vhost-stub.c\n@@ -2,9 +2,9 @@\n #include \"hw/virtio/vhost.h\"\n #include \"hw/virtio/vhost-user.h\"\n \n-bool vhost_has_free_slot(void)\n+unsigned int vhost_get_free_memslots(void)\n {\n- return true;\n+ return UINT_MAX;\n }\n \n bool vhost_user_init(VhostUserState *user, CharBackend *chr, Error **errp)\ndiff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex c16ad14535..8e84dca246 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -54,7 +54,7 @@ static unsigned int used_shared_memslots;\n static QLIST_HEAD(, vhost_dev) vhost_devices =\n QLIST_HEAD_INITIALIZER(vhost_devices);\n \n-bool vhost_has_free_slot(void)\n+unsigned int vhost_get_free_memslots(void)\n {\n unsigned int free = UINT_MAX;\n struct vhost_dev *hdev;\n@@ -71,7 +71,7 @@ bool vhost_has_free_slot(void)\n }\n free = MIN(free, cur_free);\n }\n- return free > 0;\n+ return free;\n }\n \n static void vhost_dev_sync_region(struct vhost_dev *dev,\ndiff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h\nindex 6a173cb9fa..603bf834be 100644\n--- a/include/hw/virtio/vhost.h\n+++ b/include/hw/virtio/vhost.h\n@@ -315,7 +315,7 @@ uint64_t vhost_get_features(struct vhost_dev *hdev, const int *feature_bits,\n */\n void vhost_ack_features(struct vhost_dev *hdev, const int *feature_bits,\n uint64_t features);\n-bool vhost_has_free_slot(void);\n+unsigned int vhost_get_free_memslots(void);\n \n int vhost_net_set_backend(struct vhost_dev *hdev,\n struct vhost_vring_file *file);\n","prefixes":["v4","05/18"]}