{"id":1839901,"url":"http://patchwork.ozlabs.org/api/patches/1839901/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926185738.277351-4-david@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20230926185738.277351-4-david@redhat.com>","list_archive_url":null,"date":"2023-09-26T18:57:23","name":"[v4,03/18] softmmu/physmem: Fixup qemu_ram_block_from_host() documentation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"af8d60a946441346fdf53ed5c9d02b3f05be6449","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/?format=json","name":"David Hildenbrand","email":"david@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20230926185738.277351-4-david@redhat.com/mbox/","series":[{"id":374991,"url":"http://patchwork.ozlabs.org/api/series/374991/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=374991","date":"2023-09-26T18:57:23","name":"virtio-mem: Expose device memory through multiple memslots","version":4,"mbox":"http://patchwork.ozlabs.org/series/374991/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1839901/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1839901/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=RnHz7iZ3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4Rw8DK2hvkz1ypM\n\tfor ; Wed, 27 Sep 2023 04:59:13 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1qlDGZ-0006rC-W5; Tue, 26 Sep 2023 14:58:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qlDGX-0006qo-RQ\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 14:58:38 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1qlDGW-0002xu-AB\n for qemu-devel@nongnu.org; Tue, 26 Sep 2023 14:58:37 -0400","from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-144-fT9mbBPmMxGc39bmmIY2Vw-1; Tue, 26 Sep 2023 14:58:30 -0400","from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1200800962;\n Tue, 26 Sep 2023 18:58:27 +0000 (UTC)","from t14s.fritz.box (unknown [10.39.192.33])\n by smtp.corp.redhat.com (Postfix) with ESMTP id B27692026D4B;\n Tue, 26 Sep 2023 18:58:19 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1695754714;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Q/KeM+cRvn3GHTg7YjBM909At/Q8zVrNV7vc1/nVhPQ=;\n b=RnHz7iZ3ft+SxD4b8PrYQkM36znkg9QSboSQpiI/IlVstwKlc3zdboWlsWYPmKRXpLkmKo\n 7+T1q+zMWIgbjjvOoHiLXTm2//toD4sws+Nar7yqBu/FvGCbsydr3sGE1IOEEcYiaAavOm\n v71ykGiQIa8GNoP5oGjADK59F266Df4=","X-MC-Unique":"fT9mbBPmMxGc39bmmIY2Vw-1","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","Cc":"David Hildenbrand , Paolo Bonzini ,\n Igor Mammedov ,\n Xiao Guangrong ,\n \"Michael S. Tsirkin\" , Peter Xu ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Eduardo Habkost ,\n Marcel Apfelbaum ,\n Yanan Wang , Michal Privoznik ,\n\t=?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= ,\n Gavin Shan , Alex Williamson ,\n Stefan Hajnoczi ,\n \"Maciej S . Szmigiero\" , kvm@vger.kernel.org","Subject":"[PATCH v4 03/18] softmmu/physmem: Fixup qemu_ram_block_from_host()\n documentation","Date":"Tue, 26 Sep 2023 20:57:23 +0200","Message-ID":"<20230926185738.277351-4-david@redhat.com>","In-Reply-To":"<20230926185738.277351-1-david@redhat.com>","References":"<20230926185738.277351-1-david@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.1 on 10.11.54.4","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=david@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Let's fixup the documentation (e.g., removing traces of the ram_addr\nparameter that no longer exists) and move it to the header file while at\nit.\n\nSuggested-by: Igor Mammedov \nAcked-by: Igor Mammedov \nReviewed-by: Peter Xu \nReviewed-by: Philippe Mathieu-Daudé \nSigned-off-by: David Hildenbrand \n---\n include/exec/cpu-common.h | 15 +++++++++++++++\n softmmu/physmem.c | 17 -----------------\n 2 files changed, 15 insertions(+), 17 deletions(-)","diff":"diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h\nindex 41788c0bdd..e29b13dc70 100644\n--- a/include/exec/cpu-common.h\n+++ b/include/exec/cpu-common.h\n@@ -76,6 +76,21 @@ void qemu_ram_remap(ram_addr_t addr, ram_addr_t length);\n ram_addr_t qemu_ram_addr_from_host(void *ptr);\n ram_addr_t qemu_ram_addr_from_host_nofail(void *ptr);\n RAMBlock *qemu_ram_block_by_name(const char *name);\n+\n+/*\n+ * Translates a host ptr back to a RAMBlock and an offset in that RAMBlock.\n+ *\n+ * @ptr: The host pointer to translate.\n+ * @round_offset: Whether to round the result offset down to a target page\n+ * @offset: Will be set to the offset within the returned RAMBlock.\n+ *\n+ * Returns: RAMBlock (or NULL if not found)\n+ *\n+ * By the time this function returns, the returned pointer is not protected\n+ * by RCU anymore. If the caller is not within an RCU critical section and\n+ * does not hold the iothread lock, it must have other means of protecting the\n+ * pointer, such as a reference to the memory region that owns the RAMBlock.\n+ */\n RAMBlock *qemu_ram_block_from_host(void *ptr, bool round_offset,\n ram_addr_t *offset);\n ram_addr_t qemu_ram_block_host_offset(RAMBlock *rb, void *host);\ndiff --git a/softmmu/physmem.c b/softmmu/physmem.c\nindex 4f6ca653b3..40105d558d 100644\n--- a/softmmu/physmem.c\n+++ b/softmmu/physmem.c\n@@ -2221,23 +2221,6 @@ ram_addr_t qemu_ram_block_host_offset(RAMBlock *rb, void *host)\n return res;\n }\n \n-/*\n- * Translates a host ptr back to a RAMBlock, a ram_addr and an offset\n- * in that RAMBlock.\n- *\n- * ptr: Host pointer to look up\n- * round_offset: If true round the result offset down to a page boundary\n- * *ram_addr: set to result ram_addr\n- * *offset: set to result offset within the RAMBlock\n- *\n- * Returns: RAMBlock (or NULL if not found)\n- *\n- * By the time this function returns, the returned pointer is not protected\n- * by RCU anymore. If the caller is not within an RCU critical section and\n- * does not hold the iothread lock, it must have other means of protecting the\n- * pointer, such as a reference to the region that includes the incoming\n- * ram_addr_t.\n- */\n RAMBlock *qemu_ram_block_from_host(void *ptr, bool round_offset,\n ram_addr_t *offset)\n {\n","prefixes":["v4","03/18"]}