{"id":1745930,"url":"http://patchwork.ozlabs.org/api/patches/1745930/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-26-pali@kernel.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20230221201925.9644-26-pali@kernel.org>","list_archive_url":null,"date":"2023-02-21T20:18:51","name":"[RFC,u-boot-mvebu,25/59] cmd: mvebu/bubt: Do not modify image in A8K check_image_header()","commit_ref":"7d9c083844cec1cbbd72494210af20f17b3b7642","pull_url":null,"state":"accepted","archived":false,"hash":"6f55ff01a341f25a8d2efb9944c18384e9aa85b7","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/?format=json","name":"Pali Rohár","email":"pali@kernel.org"},"delegate":{"id":1696,"url":"http://patchwork.ozlabs.org/api/users/1696/?format=json","username":"stroese","first_name":"Stefan","last_name":"Roese","email":"sr@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-26-pali@kernel.org/mbox/","series":[{"id":343058,"url":"http://patchwork.ozlabs.org/api/series/343058/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=343058","date":"2023-02-21T20:18:27","name":"arm: mvebu: Various fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/343058/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1745930/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1745930/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Zg1gczrh;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"Zg1gczrh\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLry468VJz23j7\n\tfor ; Wed, 22 Feb 2023 07:49:48 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6FF5185AB2;\n\tTue, 21 Feb 2023 21:49:11 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 934EE85AAC; Tue, 21 Feb 2023 21:48:45 +0100 (CET)","from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 503C285AB0\n for ; Tue, 21 Feb 2023 21:22:42 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id D2AEA611CB;\n Tue, 21 Feb 2023 20:22:32 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 0342FC4339E;\n Tue, 21 Feb 2023 20:22:32 +0000 (UTC)","by pali.im (Postfix)\n id B388EAC9; Tue, 21 Feb 2023 21:22:31 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677010952;\n bh=HBsFTLc2YqmacQm6J0ksn5ln5HrtI7BdIIXEf7jNsfM=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Zg1gczrhFvMLy9YXOwntJS2i2uMNoOogsghlfvFGyigCD5K6Khhg5nc8uEqDf5cQ2\n xhXK2JgJoJblQJsenSQt+K4iTwswx79LX2lnD+sw21Fle0yEo/r7Km2ILKOQLnnXVc\n /fg9Kj3VGjy7e83EVOq8M7bJJnSS+4QT+mQ6DFkK8Cru02tYgtiXfOUHxkg2S2m5Zu\n A5Y0U2PJdIBlGKKemXpOFZ8FujsCLd/ZXSPZ4EsgUUpVEdEL6+6pwZ0yQM++2SDrZS\n 7zDNZOSLE9WDRmPuQa5mCbLaoO0ssQ1XdE2KTnR0s3cegKX0FPjfSbCBMhFNyIYq9q\n g8QHBbtVz63eQ==","From":"=?utf-8?q?Pali_Roh=C3=A1r?= ","To":"u-boot@lists.denx.de","Cc":"Stefan Roese , Tony Dinh ,\n Josua Mayer ","Subject":"[PATCH RFC u-boot-mvebu 25/59] cmd: mvebu/bubt: Do not modify image\n in A8K check_image_header()","Date":"Tue, 21 Feb 2023 21:18:51 +0100","Message-Id":"<20230221201925.9644-26-pali@kernel.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20230221201925.9644-1-pali@kernel.org>","References":"<20230221201925.9644-1-pali@kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Change checksum verification code so it does require to modify image.\n\nSigned-off-by: Pali Rohár \n---\n cmd/mvebu/bubt.c | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)","diff":"diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c\nindex 820d342ae100..1b08ca9298c2 100644\n--- a/cmd/mvebu/bubt.c\n+++ b/cmd/mvebu/bubt.c\n@@ -739,18 +739,14 @@ static int check_image_header(void)\n \t\treturn -ENOEXEC;\n \t}\n \n-\t/* The checksum value is discarded from checksum calculation */\n-\thdr->prolog_checksum = 0;\n-\n \tchecksum = do_checksum32((u32 *)hdr, header_len);\n+\tchecksum -= hdr->prolog_checksum;\n \tif (checksum != checksum_ref) {\n \t\tprintf(\"Error: Bad Image checksum. 0x%x != 0x%x\\n\",\n \t\t checksum, checksum_ref);\n \t\treturn -ENOEXEC;\n \t}\n \n-\t/* Restore the checksum before writing */\n-\thdr->prolog_checksum = checksum_ref;\n \tprintf(\"Image checksum...OK!\\n\");\n \n \treturn 0;\n","prefixes":["RFC","u-boot-mvebu","25/59"]}