{"id":1745903,"url":"http://patchwork.ozlabs.org/api/patches/1745903/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-48-pali@kernel.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20230221201925.9644-48-pali@kernel.org>","list_archive_url":null,"date":"2023-02-21T20:19:13","name":"[RFC,u-boot-mvebu,47/59] tools: mkimage: Print human readable error when -d is not specified","commit_ref":"2f6855a6aa8d55d8341f454f87cabc784a890193","pull_url":null,"state":"accepted","archived":false,"hash":"15c202ddd14dc98e25191178f911c561ec2a8395","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/?format=json","name":"Pali Rohár","email":"pali@kernel.org"},"delegate":{"id":1696,"url":"http://patchwork.ozlabs.org/api/users/1696/?format=json","username":"stroese","first_name":"Stefan","last_name":"Roese","email":"sr@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-48-pali@kernel.org/mbox/","series":[{"id":343058,"url":"http://patchwork.ozlabs.org/api/series/343058/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=343058","date":"2023-02-21T20:18:27","name":"arm: mvebu: Various fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/343058/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1745903/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1745903/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=X5jnZcS7;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"X5jnZcS7\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLrZm1B1hz23j7\n\tfor ; Wed, 22 Feb 2023 07:33:04 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8CE6985B7E;\n\tTue, 21 Feb 2023 21:24:41 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id B1C3685A7B; Tue, 21 Feb 2023 21:23:57 +0100 (CET)","from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D3C6585AFD\n for ; Tue, 21 Feb 2023 21:22:44 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id D124FB810D1;\n Tue, 21 Feb 2023 20:22:38 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 6292AC433D2;\n Tue, 21 Feb 2023 20:22:37 +0000 (UTC)","by pali.im (Postfix)\n id 5E7C8AC9; Tue, 21 Feb 2023 21:22:35 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677010957;\n bh=y+0vFyQUIHl1yNi34tleuYqAyw3lgSQGe4HS7MWertk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=X5jnZcS718Y29gQMmCdRfS9C1tzyR0AVRnwC8bxZOAiqkm0G8uDW16PzTUESaxlgE\n ZGbZCuWrHQL9/urWBgbR878nSafH0Pf01UUo+g/XlRTb0WQhgJiPAb8VJSM1mv6bWw\n AoV7VscpO9t26GQ0RBGIhCQ7GIQcDZAHOqx+LcegJmTBlWcH8nrxzyr0pqUlvPexrw\n Q+qvY2WzgozWf6Fl2J/mdeNqPWU3OU7vXJel2dTDCnoVgOlz1TM35wcoSvxXLWE6wz\n FUFWBLm3wKtA01ZAw/YvYsRZdnonRKWxqoTwATt7uT/NYmlE8muFNvZiHF2fxQbIxK\n v7m8vc4u7BFGg==","From":"=?utf-8?q?Pali_Roh=C3=A1r?= ","To":"u-boot@lists.denx.de","Cc":"Stefan Roese , Tony Dinh ,\n Josua Mayer ","Subject":"[PATCH RFC u-boot-mvebu 47/59] tools: mkimage: Print human readable\n error when -d is not specified","Date":"Tue, 21 Feb 2023 21:19:13 +0100","Message-Id":"<20230221201925.9644-48-pali@kernel.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20230221201925.9644-1-pali@kernel.org>","References":"<20230221201925.9644-1-pali@kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"When asking mkimage to create a new image file and option -d is not\nspecified then mkimage show human unfriendly error message:\n\n mkimage: Can't open (null): Bad address\n\nWithout debugger it is hard to debug what is the issue. Function open() is\nbeing called with file name set to NULL. So add a check for this and if it\nhappens then show human readable message that option -d was not specified.\n\nSigned-off-by: Pali Rohár \n---\n tools/mkimage.c | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/tools/mkimage.c b/tools/mkimage.c\nindex 955a1f39a419..c53768f8d8de 100644\n--- a/tools/mkimage.c\n+++ b/tools/mkimage.c\n@@ -568,6 +568,11 @@ int main(int argc, char **argv)\n \t}\n \n \tif ((params.type != IH_TYPE_MULTI) && (params.type != IH_TYPE_SCRIPT)) {\n+\t\tif (!params.datafile) {\n+\t\t\tfprintf(stderr, \"%s: Option -d with image data file was not specified\\n\",\n+\t\t\t\tparams.cmdname);\n+\t\t\texit(EXIT_FAILURE);\n+\t\t}\n \t\tdfd = open(params.datafile, O_RDONLY | O_BINARY);\n \t\tif (dfd < 0) {\n \t\t\tfprintf(stderr, \"%s: Can't open %s: %s\\n\",\n","prefixes":["RFC","u-boot-mvebu","47/59"]}