{"id":1745881,"url":"http://patchwork.ozlabs.org/api/patches/1745881/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-5-pali@kernel.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20230221201925.9644-5-pali@kernel.org>","list_archive_url":null,"date":"2023-02-21T20:18:30","name":"[RFC,u-boot-mvebu,04/59] cmd: mvebu/bubt: Fix parsing SDIO kwbimage","commit_ref":"eb2c8f3805082955a95485911962b2baa8ab54ce","pull_url":null,"state":"accepted","archived":false,"hash":"e04abe5f2775331086d2c7a9c5ef9b169506e66e","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/?format=json","name":"Pali Rohár","email":"pali@kernel.org"},"delegate":{"id":1696,"url":"http://patchwork.ozlabs.org/api/users/1696/?format=json","username":"stroese","first_name":"Stefan","last_name":"Roese","email":"sr@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-5-pali@kernel.org/mbox/","series":[{"id":343058,"url":"http://patchwork.ozlabs.org/api/series/343058/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=343058","date":"2023-02-21T20:18:27","name":"arm: mvebu: Various fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/343058/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1745881/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1745881/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=TsrnO43Z;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"TsrnO43Z\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLrQq2b3cz23yr\n\tfor ; Wed, 22 Feb 2023 07:26:11 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6977385A8E;\n\tTue, 21 Feb 2023 21:23:16 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id C80F685B19; Tue, 21 Feb 2023 21:22:45 +0100 (CET)","from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 3C04C85A55\n for ; Tue, 21 Feb 2023 21:22:32 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id B2B60B81098;\n Tue, 21 Feb 2023 20:22:31 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 4E608C4339E;\n Tue, 21 Feb 2023 20:22:30 +0000 (UTC)","by pali.im (Postfix)\n id 1DECBAA6; Tue, 21 Feb 2023 21:22:28 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677010950;\n bh=Zu9dbCdFn5cJMU7SSqpjTlpVedDuBZK/ldwahWA/N7U=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=TsrnO43Z+taAkFfaax7Y58kDYybG7a1GzEz8BHE+n5zdqp309s7GSj6ysslsMynT0\n ZMNJvlAJ3jKuMrAq/5N+zrCbWhmFd5FOZ62XCNGQpL78eSRxFrBQcmfZxZwkxJ8qon\n 7X3cjCCuEe5SkFZVdgwxBa5BjhH9ImUN7n5JAI0YX2EjJZFGEwzQz2vZ2S5SjamCjr\n Z9zKlAHnCPkuqWeeAZ2YXnWKEs7u2yjszTe4ECCaBZ5A9pjB6rn3/SfIwey5d/pJgL\n hjPWuvVuD1AtTeswWt7DmhNrg45NK0VOVTQysmyr1+qCn33X5DjGuixUUPszwmtLfd\n jANQ5IYJnTXnQ==","From":"=?utf-8?q?Pali_Roh=C3=A1r?= ","To":"u-boot@lists.denx.de","Cc":"Stefan Roese , Tony Dinh ,\n Josua Mayer ","Subject":"[PATCH RFC u-boot-mvebu 04/59] cmd: mvebu/bubt: Fix parsing SDIO\n kwbimage","Date":"Tue, 21 Feb 2023 21:18:30 +0100","Message-Id":"<20230221201925.9644-5-pali@kernel.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20230221201925.9644-1-pali@kernel.org>","References":"<20230221201925.9644-1-pali@kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Despite the official specification, Marvell BootROM does not interpret\nsrcaddr from SDIO image as offset in number of sectors (like for SATA\nimage), but as offset in bytes (like for all other images except SATA).\n\nTo ensure that we do not store invalid SDIO image to the boot location\n(read by the Marvell BootROM), we need to check that image is valid\nand srcaddr is intepreted in bytes, in the same way as it is done by\nMarvell BootROM.\n\nThis fixes rejecting valid and accepting invalid SDIO images by bubt command.\n\nFixes: 5a0653493307 (\"cmd: mvebu/bubt: Check for A38x image data checksum\")\nSigned-off-by: Pali Rohár \n---\n cmd/mvebu/bubt.c | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c\nindex 1efbe2e607ca..6bb84da03ed6 100644\n--- a/cmd/mvebu/bubt.c\n+++ b/cmd/mvebu/bubt.c\n@@ -747,9 +747,6 @@ static int check_image_header(void)\n \t\toffset *= 512;\n \t}\n \n-\tif (hdr->blockid == 0xAE) /* SDIO id */\n-\t\toffset *= 512;\n-\n \tif (offset % 4 != 0 || size < 4 || size % 4 != 0) {\n \t\tprintf(\"Error: Bad A38x image blocksize.\\n\");\n \t\treturn -ENOEXEC;\n","prefixes":["RFC","u-boot-mvebu","04/59"]}