{"id":1745879,"url":"http://patchwork.ozlabs.org/api/patches/1745879/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-9-pali@kernel.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20230221201925.9644-9-pali@kernel.org>","list_archive_url":null,"date":"2023-02-21T20:18:34","name":"[RFC,u-boot-mvebu,08/59] cmd: mvebu/bubt: Fix parsing SATA kwbimage","commit_ref":"a2cd076b7f5ad3017fc8a2b22687cd58d02e85db","pull_url":null,"state":"accepted","archived":false,"hash":"b01a2fb92e5a63d8e6f10b196a383e96919fdca8","submitter":{"id":78810,"url":"http://patchwork.ozlabs.org/api/people/78810/?format=json","name":"Pali Rohár","email":"pali@kernel.org"},"delegate":{"id":1696,"url":"http://patchwork.ozlabs.org/api/users/1696/?format=json","username":"stroese","first_name":"Stefan","last_name":"Roese","email":"sr@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20230221201925.9644-9-pali@kernel.org/mbox/","series":[{"id":343058,"url":"http://patchwork.ozlabs.org/api/series/343058/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=343058","date":"2023-02-21T20:18:27","name":"arm: mvebu: Various fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/343058/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1745879/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1745879/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=)","legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=jRdAgS4n;\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"jRdAgS4n\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org","phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (P-384))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4PLrPd5ChSz23yr\n\tfor ; Wed, 22 Feb 2023 07:25:09 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B106E859FF;\n\tTue, 21 Feb 2023 21:22:55 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 3F2EC85B0F; Tue, 21 Feb 2023 21:22:45 +0100 (CET)","from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9993385A83\n for ; Tue, 21 Feb 2023 21:22:32 +0100 (CET)","from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id 40B31B810C2;\n Tue, 21 Feb 2023 20:22:32 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id C92FBC433A1;\n Tue, 21 Feb 2023 20:22:30 +0000 (UTC)","by pali.im (Postfix)\n id D86F0AFB; Tue, 21 Feb 2023 21:22:28 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1677010951;\n bh=7f7S0Z4TcM3BxBtRNgKCRVjyqbAHMMiD1H4Mhh6E0/A=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=jRdAgS4nPUN3X8js9LfNYdhJR/dTg/E0vgBBw1O1qA1ALgaH/M75xUZvlPzib41FD\n /Iom3Kp1pPMEbSdHsOvV08GUzZpSmYqhaIb4ELk8H/jBqKEHvakLARhRXoAiCffrid\n HuzIY6ADu7zg02q7jGVtYwVkzsqt+AXsp3Ia4f8iE1mRymyU4/dgtT+F4uYF1f64Il\n 2fYCaFL9EsWZWp43FLrt9X2bPYJ+Ol4bGrh0fVjL1dN3MiS1q10wcL4XPMf3ElpHKE\n RO/Wwy3Tnhk/YlMf8HHZDR1tkTCBS+oC3eYcjnQL94kv3FoA4TtNKUC/Pe/R34ad1q\n aCwCMlIXGIUGQ==","From":"=?utf-8?q?Pali_Roh=C3=A1r?= ","To":"u-boot@lists.denx.de","Cc":"Stefan Roese , Tony Dinh ,\n Josua Mayer ","Subject":"[PATCH RFC u-boot-mvebu 08/59] cmd: mvebu/bubt: Fix parsing SATA\n kwbimage","Date":"Tue, 21 Feb 2023 21:18:34 +0100","Message-Id":"<20230221201925.9644-9-pali@kernel.org>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20230221201925.9644-1-pali@kernel.org>","References":"<20230221201925.9644-1-pali@kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.6 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Despite the official specification, Marvell BootROM does not interpret\nsrcaddr from SATA image as number of sectors the beginning of the hard\ndrive, but as number of sectors relative to the main header.\n\nReject invalid and accept valid SATA images.\n\nFixes: 5a0653493307 (\"cmd: mvebu/bubt: Check for A38x image data checksum\")\nSigned-off-by: Pali Rohár \n---\n cmd/mvebu/bubt.c | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)","diff":"diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c\nindex 6bb84da03ed6..2bcdf145f64a 100644\n--- a/cmd/mvebu/bubt.c\n+++ b/cmd/mvebu/bubt.c\n@@ -738,14 +738,8 @@ static int check_image_header(void)\n \toffset = le32_to_cpu(hdr->srcaddr);\n \tsize = le32_to_cpu(hdr->blocksize);\n \n-\tif (hdr->blockid == 0x78) { /* SATA id */\n-\t\tif (offset < 1) {\n-\t\t\tprintf(\"Error: Bad A38x image srcaddr.\\n\");\n-\t\t\treturn -ENOEXEC;\n-\t\t}\n-\t\toffset -= 1;\n+\tif (hdr->blockid == 0x78) /* SATA id */\n \t\toffset *= 512;\n-\t}\n \n \tif (offset % 4 != 0 || size < 4 || size % 4 != 0) {\n \t\tprintf(\"Error: Bad A38x image blocksize.\\n\");\n","prefixes":["RFC","u-boot-mvebu","08/59"]}