{"id":1658303,"url":"http://patchwork.ozlabs.org/api/patches/1658303/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-25-xuanzhuo@linux.alibaba.com/","project":{"id":60,"url":"http://patchwork.ozlabs.org/api/projects/60/?format=json","name":"User-mode Linux Development","link_name":"linux-um","list_id":"linux-um.lists.infradead.org","list_email":"linux-um@lists.infradead.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20220720030436.79520-25-xuanzhuo@linux.alibaba.com>","list_archive_url":null,"date":"2022-07-20T03:04:20","name":"[v12,24/40] virtio: allow to unbreak/break virtqueue individually","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"d5a69248cd310db78c28a59a0e1c0a7250040185","submitter":{"id":80519,"url":"http://patchwork.ozlabs.org/api/people/80519/?format=json","name":"Xuan Zhuo","email":"xuanzhuo@linux.alibaba.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-25-xuanzhuo@linux.alibaba.com/mbox/","series":[{"id":310331,"url":"http://patchwork.ozlabs.org/api/series/310331/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-um/list/?series=310331","date":"2022-07-20T03:03:59","name":"virtio pci support VIRTIO_F_RING_RESET","version":12,"mbox":"http://patchwork.ozlabs.org/series/310331/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1658303/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1658303/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=W6jIesYK;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LngZ522wfz9s2R\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 20 Jul 2022 13:05:49 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01v-00HF3a-9e; Wed, 20 Jul 2022 03:05:43 +0000","from out30-133.freemail.mail.aliyun.com ([115.124.30.133])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01s-00HExu-8Z\n\tfor linux-um@lists.infradead.org; Wed, 20 Jul 2022 03:05:41 +0000","from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VJuw0YI_1658286334)\n          by smtp.aliyun-inc.com;\n          Wed, 20 Jul 2022 11:05:35 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=DJ66eGYX444k5E+lgJpnF4y6q9nJloql3Wxnwr1D4DM=; b=W6jIesYKaI9IiC\n\tOsk9nx0UC+MhOOEA9UcmkewM/wGRN0DbpvclQPyCMk4a7CmdUAuRXUOXeE0nOvCC+oO0YX7091Pb7\n\tai8D06zONyZeGGgRixRziTrrymVxkJ0mgZASP5g/DA/tZD+LJYYR3utYVht0yZXJA3fKYLwelwjVx\n\t0TMK7m4OMm4EnPptq1m0UX0G/htvjhpJe5lA87N2NiLqhKS5Alw9AH3va408uuX/Ah/0FdLc3As8f\n\txCbOR28GX9MNe7VmCq9dlBteG8OeF4bkY5eq0psbggrw1xwhxXxsioI12n175AzBWRxB4/rhnDJkd\n\teIgK0oAg5bj7NTE2tvVA==;","X-Alimail-AntiSpam":"\n AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0VJuw0YI_1658286334;","From":"Xuan Zhuo <xuanzhuo@linux.alibaba.com>","To":"virtualization@lists.linux-foundation.org","Cc":"Richard Weinberger <richard@nod.at>,\n\tAnton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tJason Wang <jasowang@redhat.com>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tEric Dumazet <edumazet@google.com>,\n\tJakub Kicinski <kuba@kernel.org>,\n\tPaolo Abeni <pabeni@redhat.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tMark Gross <markgross@kernel.org>,\n\tVadim Pasternak <vadimp@nvidia.com>,\n\tBjorn Andersson <bjorn.andersson@linaro.org>,\n\tMathieu Poirier <mathieu.poirier@linaro.org>,\n\tCornelia Huck <cohuck@redhat.com>,\n\tHalil Pasic <pasic@linux.ibm.com>,\n\tEric Farman <farman@linux.ibm.com>,\n\tHeiko Carstens <hca@linux.ibm.com>,\n\tVasily Gorbik <gor@linux.ibm.com>,\n\tAlexander Gordeev <agordeev@linux.ibm.com>,\n\tChristian Borntraeger <borntraeger@linux.ibm.com>,\n\tSven Schnelle <svens@linux.ibm.com>,\n\tAlexei Starovoitov <ast@kernel.org>,\n\tDaniel Borkmann <daniel@iogearbox.net>,\n\tJesper Dangaard Brouer <hawk@kernel.org>,\n\tJohn Fastabend <john.fastabend@gmail.com>,\n\tXuan Zhuo <xuanzhuo@linux.alibaba.com>,\n\tVincent Whitchurch <vincent.whitchurch@axis.com>,\n\tlinux-um@lists.infradead.org,\n\tnetdev@vger.kernel.org,\n\tplatform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tkvm@vger.kernel.org,\n\tbpf@vger.kernel.org,\n\tkangjie.xu@linux.alibaba.com","Subject":"[PATCH v12 24/40] virtio: allow to unbreak/break virtqueue\n individually","Date":"Wed, 20 Jul 2022 11:04:20 +0800","Message-Id":"<20220720030436.79520-25-xuanzhuo@linux.alibaba.com>","X-Mailer":"git-send-email 2.31.0","In-Reply-To":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>","MIME-Version":"1.0","X-Git-Hash":"366032b2ffac","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220719_200540_496770_22BF1241 ","X-CRM114-Status":"UNSURE (   8.57  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-8.0 (--------)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam.  The original\n message has been attached to this so you can view it or label\n similar future email.  If you have any questions, see\n the administrator of that system for details.\n Content preview:  This patch allows the new introduced\n __virtqueue_break()/__virtqueue_unbreak()\n    to break/unbreak the virtqueue. Signed-off-by: Xuan Zhuo\n <xuanzhuo@linux.alibaba.com>\n    --- drivers/virtio/virtio_ring.c | 24 ++++++++++++++++++++++++\n include/linux/virtio.h\n    | 3 +++ 2 files changed, 27 insertions(+)\n Content analysis details:   (-8.0 points, 5.0 required)\n  pts rule name              description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,\n                              no trust\n                             [115.124.30.133 listed in list.dnswl.org]\n -0.0 SPF_PASS               SPF: sender matches SPF record\n  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL     From: address is in the default SPF\n                             white-list\n -0.5 ENV_AND_HDR_SPF_MATCH  Env and Hdr From used in default SPF WL\n                             Match\n  0.0 UNPARSEABLE_RELAY      Informational: message has unparseable relay\n                             lines","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"<linux-um.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-um/>","List-Post":"<mailto:linux-um@lists.infradead.org>","List-Help":"<mailto:linux-um-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-um\" <linux-um-bounces@lists.infradead.org>","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"This patch allows the new introduced\n__virtqueue_break()/__virtqueue_unbreak() to break/unbreak the\nvirtqueue.\n\nSigned-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>\n---\n drivers/virtio/virtio_ring.c | 24 ++++++++++++++++++++++++\n include/linux/virtio.h       |  3 +++\n 2 files changed, 27 insertions(+)","diff":"diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\nindex cf4379175163..bf666dad9904 100644\n--- a/drivers/virtio/virtio_ring.c\n+++ b/drivers/virtio/virtio_ring.c\n@@ -2730,6 +2730,30 @@ unsigned int virtqueue_get_vring_size(struct virtqueue *_vq)\n }\n EXPORT_SYMBOL_GPL(virtqueue_get_vring_size);\n \n+/*\n+ * This function should only be called by the core, not directly by the driver.\n+ */\n+void __virtqueue_break(struct virtqueue *_vq)\n+{\n+\tstruct vring_virtqueue *vq = to_vvq(_vq);\n+\n+\t/* Pairs with READ_ONCE() in virtqueue_is_broken(). */\n+\tWRITE_ONCE(vq->broken, true);\n+}\n+EXPORT_SYMBOL_GPL(__virtqueue_break);\n+\n+/*\n+ * This function should only be called by the core, not directly by the driver.\n+ */\n+void __virtqueue_unbreak(struct virtqueue *_vq)\n+{\n+\tstruct vring_virtqueue *vq = to_vvq(_vq);\n+\n+\t/* Pairs with READ_ONCE() in virtqueue_is_broken(). */\n+\tWRITE_ONCE(vq->broken, false);\n+}\n+EXPORT_SYMBOL_GPL(__virtqueue_unbreak);\n+\n bool virtqueue_is_broken(struct virtqueue *_vq)\n {\n \tstruct vring_virtqueue *vq = to_vvq(_vq);\ndiff --git a/include/linux/virtio.h b/include/linux/virtio.h\nindex 62e31bca5602..d45ee82a4470 100644\n--- a/include/linux/virtio.h\n+++ b/include/linux/virtio.h\n@@ -138,6 +138,9 @@ bool is_virtio_device(struct device *dev);\n void virtio_break_device(struct virtio_device *dev);\n void __virtio_unbreak_device(struct virtio_device *dev);\n \n+void __virtqueue_break(struct virtqueue *_vq);\n+void __virtqueue_unbreak(struct virtqueue *_vq);\n+\n void virtio_config_changed(struct virtio_device *dev);\n #ifdef CONFIG_PM_SLEEP\n int virtio_device_freeze(struct virtio_device *dev);\n","prefixes":["v12","24/40"]}