{"id":1658301,"url":"http://patchwork.ozlabs.org/api/patches/1658301/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-23-xuanzhuo@linux.alibaba.com/","project":{"id":60,"url":"http://patchwork.ozlabs.org/api/projects/60/?format=json","name":"User-mode Linux Development","link_name":"linux-um","list_id":"linux-um.lists.infradead.org","list_email":"linux-um@lists.infradead.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20220720030436.79520-23-xuanzhuo@linux.alibaba.com>","list_archive_url":null,"date":"2022-07-20T03:04:18","name":"[v12,22/40] virtio_ring: introduce virtqueue_resize()","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"747fc1d91ea4f142f331f039c4d0cabc5e1ff9a2","submitter":{"id":80519,"url":"http://patchwork.ozlabs.org/api/people/80519/?format=json","name":"Xuan Zhuo","email":"xuanzhuo@linux.alibaba.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-23-xuanzhuo@linux.alibaba.com/mbox/","series":[{"id":310331,"url":"http://patchwork.ozlabs.org/api/series/310331/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-um/list/?series=310331","date":"2022-07-20T03:03:59","name":"virtio pci support VIRTIO_F_RING_RESET","version":12,"mbox":"http://patchwork.ozlabs.org/series/310331/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1658301/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1658301/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=MF03RGBi;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LngZ41Lf1z9s2R\n\tfor ; Wed, 20 Jul 2022 13:05:48 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01u-00HF2U-3E; Wed, 20 Jul 2022 03:05:42 +0000","from out30-57.freemail.mail.aliyun.com ([115.124.30.57])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01q-00HEv8-TI\n\tfor linux-um@lists.infradead.org; Wed, 20 Jul 2022 03:05:40 +0000","from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VJuw0Wb_1658286329)\n by smtp.aliyun-inc.com;\n Wed, 20 Jul 2022 11:05:30 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=qJEiobNgzsQROHUNsvd4+3wthEaLaV+1Gv5sIqsCGDc=; b=MF03RGBibsct36\n\t3dJ4WDT+Udy3C269/jhZcmK74YMGCgUCKOnmx1SFvJeMO2o/zjGMWH0mxGqOuH6Us8euEplLSbNBj\n\tVUueynUnBQ8Mm70beZ8f66HwhydwWXQHELTK6V14XSLLcboB+A4nyT4xfYad1pOdTHWER2hgDdXe0\n\ty1siioPAWWLNamUpGWNd1dQYGm30ieyI9w6EVxO2xCmoBOGtHI069Gd07Xqizfn04ihuD+sUVDmRd\n\tFAFUAwynYpExA0tRgMCi95XeEanWwCJju6oejkCHuTFZu1kHV+izQ5rbAZmm4xsso96PvhkKyvr//\n\t2ZlM6a0xluOIHTLx/0iw==;","X-Alimail-AntiSpam":"\n AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0VJuw0Wb_1658286329;","From":"Xuan Zhuo ","To":"virtualization@lists.linux-foundation.org","Cc":"Richard Weinberger ,\n\tAnton Ivanov ,\n\tJohannes Berg ,\n\t\"Michael S. Tsirkin\" ,\n\tJason Wang ,\n\t\"David S. Miller\" ,\n\tEric Dumazet ,\n\tJakub Kicinski ,\n\tPaolo Abeni ,\n\tHans de Goede ,\n\tMark Gross ,\n\tVadim Pasternak ,\n\tBjorn Andersson ,\n\tMathieu Poirier ,\n\tCornelia Huck ,\n\tHalil Pasic ,\n\tEric Farman ,\n\tHeiko Carstens ,\n\tVasily Gorbik ,\n\tAlexander Gordeev ,\n\tChristian Borntraeger ,\n\tSven Schnelle ,\n\tAlexei Starovoitov ,\n\tDaniel Borkmann ,\n\tJesper Dangaard Brouer ,\n\tJohn Fastabend ,\n\tXuan Zhuo ,\n\tVincent Whitchurch ,\n\tlinux-um@lists.infradead.org,\n\tnetdev@vger.kernel.org,\n\tplatform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tkvm@vger.kernel.org,\n\tbpf@vger.kernel.org,\n\tkangjie.xu@linux.alibaba.com","Subject":"[PATCH v12 22/40] virtio_ring: introduce virtqueue_resize()","Date":"Wed, 20 Jul 2022 11:04:18 +0800","Message-Id":"<20220720030436.79520-23-xuanzhuo@linux.alibaba.com>","X-Mailer":"git-send-email 2.31.0","In-Reply-To":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>","MIME-Version":"1.0","X-Git-Hash":"366032b2ffac","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220719_200539_143980_6DE1B803 ","X-CRM114-Status":"GOOD ( 14.42 )","X-Spam-Score":"-8.0 (--------)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Introduce virtqueue_resize() to implement the resize of\n vring.\n Based on these, the driver can dynamically adjust the size of the vring.\n For example: ethtool -G. virtqueue_resize() implements resize based on the\n vq reset function. In case of failure to allocate a new vring,\n it will give\n up resize and use the original vring.\n Content analysis details: (-8.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,\n no trust\n [115.124.30.57 listed in list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF\n white-list\n -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL\n Match\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Introduce virtqueue_resize() to implement the resize of vring.\nBased on these, the driver can dynamically adjust the size of the vring.\nFor example: ethtool -G.\n\nvirtqueue_resize() implements resize based on the vq reset function. In\ncase of failure to allocate a new vring, it will give up resize and use\nthe original vring.\n\nDuring this process, if the re-enable reset vq fails, the vq can no\nlonger be used. Although the probability of this situation is not high.\n\nThe parameter recycle is used to recycle the buffer that is no longer\nused.\n\nSigned-off-by: Xuan Zhuo \n---\n drivers/virtio/virtio_ring.c | 69 ++++++++++++++++++++++++++++++++++++\n include/linux/virtio.h | 3 ++\n 2 files changed, 72 insertions(+)","diff":"diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\nindex b092914e9dcd..cf4379175163 100644\n--- a/drivers/virtio/virtio_ring.c\n+++ b/drivers/virtio/virtio_ring.c\n@@ -2545,6 +2545,75 @@ struct virtqueue *vring_create_virtqueue(\n }\n EXPORT_SYMBOL_GPL(vring_create_virtqueue);\n \n+/**\n+ * virtqueue_resize - resize the vring of vq\n+ * @_vq: the struct virtqueue we're talking about.\n+ * @num: new ring num\n+ * @recycle: callback for recycle the useless buffer\n+ *\n+ * When it is really necessary to create a new vring, it will set the current vq\n+ * into the reset state. Then call the passed callback to recycle the buffer\n+ * that is no longer used. Only after the new vring is successfully created, the\n+ * old vring will be released.\n+ *\n+ * Caller must ensure we don't call this with other virtqueue operations\n+ * at the same time (except where noted).\n+ *\n+ * Returns zero or a negative error.\n+ * 0: success.\n+ * -ENOMEM: Failed to allocate a new ring, fall back to the original ring size.\n+ * vq can still work normally\n+ * -EBUSY: Failed to sync with device, vq may not work properly\n+ * -ENOENT: Transport or device not supported\n+ * -E2BIG/-EINVAL: num error\n+ * -EPERM: Operation not permitted\n+ *\n+ */\n+int virtqueue_resize(struct virtqueue *_vq, u32 num,\n+\t\t void (*recycle)(struct virtqueue *vq, void *buf))\n+{\n+\tstruct vring_virtqueue *vq = to_vvq(_vq);\n+\tstruct virtio_device *vdev = vq->vq.vdev;\n+\tvoid *buf;\n+\tint err;\n+\n+\tif (!vq->we_own_ring)\n+\t\treturn -EPERM;\n+\n+\tif (num > vq->vq.num_max)\n+\t\treturn -E2BIG;\n+\n+\tif (!num)\n+\t\treturn -EINVAL;\n+\n+\tif ((vq->packed_ring ? vq->packed.vring.num : vq->split.vring.num) == num)\n+\t\treturn 0;\n+\n+\tif (!vdev->config->disable_vq_and_reset)\n+\t\treturn -ENOENT;\n+\n+\tif (!vdev->config->enable_vq_after_reset)\n+\t\treturn -ENOENT;\n+\n+\terr = vdev->config->disable_vq_and_reset(_vq);\n+\tif (err)\n+\t\treturn err;\n+\n+\twhile ((buf = virtqueue_detach_unused_buf(_vq)) != NULL)\n+\t\trecycle(_vq, buf);\n+\n+\tif (vq->packed_ring)\n+\t\terr = virtqueue_resize_packed(_vq, num);\n+\telse\n+\t\terr = virtqueue_resize_split(_vq, num);\n+\n+\tif (vdev->config->enable_vq_after_reset(_vq))\n+\t\treturn -EBUSY;\n+\n+\treturn err;\n+}\n+EXPORT_SYMBOL_GPL(virtqueue_resize);\n+\n /* Only available for split ring */\n struct virtqueue *vring_new_virtqueue(unsigned int index,\n \t\t\t\t unsigned int num,\ndiff --git a/include/linux/virtio.h b/include/linux/virtio.h\nindex 129bde7521e3..62e31bca5602 100644\n--- a/include/linux/virtio.h\n+++ b/include/linux/virtio.h\n@@ -91,6 +91,9 @@ dma_addr_t virtqueue_get_desc_addr(struct virtqueue *vq);\n dma_addr_t virtqueue_get_avail_addr(struct virtqueue *vq);\n dma_addr_t virtqueue_get_used_addr(struct virtqueue *vq);\n \n+int virtqueue_resize(struct virtqueue *vq, u32 num,\n+\t\t void (*recycle)(struct virtqueue *vq, void *buf));\n+\n /**\n * virtio_device - representation of a device using virtio\n * @index: unique position on the virtio bus\n","prefixes":["v12","22/40"]}