{"id":1658299,"url":"http://patchwork.ozlabs.org/api/patches/1658299/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-19-xuanzhuo@linux.alibaba.com/","project":{"id":60,"url":"http://patchwork.ozlabs.org/api/projects/60/?format=json","name":"User-mode Linux Development","link_name":"linux-um","list_id":"linux-um.lists.infradead.org","list_email":"linux-um@lists.infradead.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20220720030436.79520-19-xuanzhuo@linux.alibaba.com>","list_archive_url":null,"date":"2022-07-20T03:04:14","name":"[v12,18/40] virtio_ring: packed: extract the logic of attach vring","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"c5e2f31a2eb2498f4a8c33bf6626a70dde9b03e0","submitter":{"id":80519,"url":"http://patchwork.ozlabs.org/api/people/80519/?format=json","name":"Xuan Zhuo","email":"xuanzhuo@linux.alibaba.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-um/patch/20220720030436.79520-19-xuanzhuo@linux.alibaba.com/mbox/","series":[{"id":310331,"url":"http://patchwork.ozlabs.org/api/series/310331/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-um/list/?series=310331","date":"2022-07-20T03:03:59","name":"virtio pci support VIRTIO_F_RING_RESET","version":12,"mbox":"http://patchwork.ozlabs.org/series/310331/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1658299/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1658299/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=mixOvC9W;\n\tdkim-atps=neutral","ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4LngYt66Jxz9s2R\n\tfor ; Wed, 20 Jul 2022 13:05:38 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01l-00HEsT-1Y; Wed, 20 Jul 2022 03:05:33 +0000","from out199-13.us.a.mail.aliyun.com ([47.90.199.13])\n\tby bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))\n\tid 1oE01i-00HEjL-AT\n\tfor linux-um@lists.infradead.org; Wed, 20 Jul 2022 03:05:32 +0000","from localhost(mailfrom:xuanzhuo@linux.alibaba.com\n fp:SMTPD_---0VJuvIdk_1658286319)\n by smtp.aliyun-inc.com;\n Wed, 20 Jul 2022 11:05:20 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=NuE6OKNBmvSoagsyrWpziwc3GLLsZKC8M3qURP/86Pw=; b=mixOvC9WKoKBNp\n\t+W6V6+o6+Auw8fqOAwr+4YdUK6tVdxDhlxl33F28BDn74Zr9Nb3JiQYaKlbF4Q38mSbxJasNCJnN5\n\tx6jq8Qdo6ssiOHjpCnuXSPhwgfKzxW598YIug6KWf3Cf6s9CGwMkHtIFDKUgHMcEIFC/VEsmYziwM\n\t0v+WjnxwBfrtmCMcIeZ3e7C9PdcxHmtmlJl3Ib9PlxoFVDcpZb8LbUNdCxgxjrwM+85gxuZEmwito\n\t+ORiygVhrW64mF63j6dFBfSxTn4EyTfY/U669+h4LimtzFgkIXp7uzmmOBdXnQBUJeDb+dfIKsRFn\n\t9W/kRDvqqHKTCfOAx8yQ==;","X-Alimail-AntiSpam":"\n AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0VJuvIdk_1658286319;","From":"Xuan Zhuo ","To":"virtualization@lists.linux-foundation.org","Cc":"Richard Weinberger ,\n\tAnton Ivanov ,\n\tJohannes Berg ,\n\t\"Michael S. Tsirkin\" ,\n\tJason Wang ,\n\t\"David S. Miller\" ,\n\tEric Dumazet ,\n\tJakub Kicinski ,\n\tPaolo Abeni ,\n\tHans de Goede ,\n\tMark Gross ,\n\tVadim Pasternak ,\n\tBjorn Andersson ,\n\tMathieu Poirier ,\n\tCornelia Huck ,\n\tHalil Pasic ,\n\tEric Farman ,\n\tHeiko Carstens ,\n\tVasily Gorbik ,\n\tAlexander Gordeev ,\n\tChristian Borntraeger ,\n\tSven Schnelle ,\n\tAlexei Starovoitov ,\n\tDaniel Borkmann ,\n\tJesper Dangaard Brouer ,\n\tJohn Fastabend ,\n\tXuan Zhuo ,\n\tVincent Whitchurch ,\n\tlinux-um@lists.infradead.org,\n\tnetdev@vger.kernel.org,\n\tplatform-driver-x86@vger.kernel.org,\n\tlinux-remoteproc@vger.kernel.org,\n\tlinux-s390@vger.kernel.org,\n\tkvm@vger.kernel.org,\n\tbpf@vger.kernel.org,\n\tkangjie.xu@linux.alibaba.com","Subject":"[PATCH v12 18/40] virtio_ring: packed: extract the logic of attach\n vring","Date":"Wed, 20 Jul 2022 11:04:14 +0800","Message-Id":"<20220720030436.79520-19-xuanzhuo@linux.alibaba.com>","X-Mailer":"git-send-email 2.31.0","In-Reply-To":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>","References":"<20220720030436.79520-1-xuanzhuo@linux.alibaba.com>","MIME-Version":"1.0","X-Git-Hash":"366032b2ffac","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20220719_200530_676268_B5B6F995 ","X-CRM114-Status":"UNSURE ( 8.62 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-8.0 (--------)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Separate the logic of attach vring,\n the subsequent patch will\n call it separately. Signed-off-by: Xuan Zhuo \n --- drivers/virtio/virtio_ring.c | 29 +++++++++++++++++ 1 file changed, 17\n insertions(+), 12 deletions(-)\n Content analysis details: (-8.0 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF\n white-list\n -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL\n Match\n 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n lines","X-BeenThere":"linux-um@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-um\" ","Errors-To":"linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Separate the logic of attach vring, the subsequent patch will call it\nseparately.\n\nSigned-off-by: Xuan Zhuo \n---\n drivers/virtio/virtio_ring.c | 29 +++++++++++++++++------------\n 1 file changed, 17 insertions(+), 12 deletions(-)","diff":"diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c\nindex 1f8d6417b46a..19ed20d7d433 100644\n--- a/drivers/virtio/virtio_ring.c\n+++ b/drivers/virtio/virtio_ring.c\n@@ -1932,6 +1932,22 @@ static int vring_alloc_state_extra_packed(struct vring_virtqueue_packed *vring_p\n \treturn -ENOMEM;\n }\n \n+static void virtqueue_vring_attach_packed(struct vring_virtqueue *vq,\n+\t\t\t\t\t struct vring_virtqueue_packed *vring_packed)\n+{\n+\tvq->packed.ring_dma_addr = vring_packed->ring_dma_addr;\n+\tvq->packed.driver_event_dma_addr = vring_packed->driver_event_dma_addr;\n+\tvq->packed.device_event_dma_addr = vring_packed->device_event_dma_addr;\n+\n+\tvq->packed.ring_size_in_bytes = vring_packed->ring_size_in_bytes;\n+\tvq->packed.event_size_in_bytes = vring_packed->event_size_in_bytes;\n+\n+\tvq->packed.vring = vring_packed->vring;\n+\n+\tvq->packed.desc_state = vring_packed->desc_state;\n+\tvq->packed.desc_extra = vring_packed->desc_extra;\n+}\n+\n static struct virtqueue *vring_create_virtqueue_packed(\n \tunsigned int index,\n \tunsigned int num,\n@@ -1972,15 +1988,6 @@ static struct virtqueue *vring_create_virtqueue_packed(\n \tvq->indirect = virtio_has_feature(vdev, VIRTIO_RING_F_INDIRECT_DESC) &&\n \t\t!context;\n \n-\tvq->packed.ring_dma_addr = vring_packed.ring_dma_addr;\n-\tvq->packed.driver_event_dma_addr = vring_packed.driver_event_dma_addr;\n-\tvq->packed.device_event_dma_addr = vring_packed.device_event_dma_addr;\n-\n-\tvq->packed.ring_size_in_bytes = vring_packed.ring_size_in_bytes;\n-\tvq->packed.event_size_in_bytes = vring_packed.event_size_in_bytes;\n-\n-\tvq->packed.vring = vring_packed.vring;\n-\n \tvq->packed.next_avail_idx = 0;\n \tvq->packed.avail_wrap_counter = 1;\n \tvq->packed.event_flags_shadow = 0;\n@@ -1990,10 +1997,8 @@ static struct virtqueue *vring_create_virtqueue_packed(\n \tif (err)\n \t\tgoto err_state_extra;\n \n-\tvq->packed.desc_state = vring.desc_state;\n-\tvq->packed.desc_extra = vring.desc_extra;\n-\n \tvirtqueue_init(vq, num);\n+\tvirtqueue_vring_attach_packed(vq, &vring_packed);\n \n \t/* No callback? Tell other side not to bother us. */\n \tif (!callback) {\n","prefixes":["v12","18/40"]}