{"id":1585803,"url":"http://patchwork.ozlabs.org/api/patches/1585803/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20220128153009.2467560-22-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20220128153009.2467560-22-peter.maydell@linaro.org>","list_archive_url":null,"date":"2022-01-28T15:29:58","name":"[PULL,21/32] hw/intc/arm_gicv3_its: Don't clear GITS_CWRITER on writes to GITS_CBASER","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6fc9aef16928aeee9948553e9c48b7fd3389c8f7","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20220128153009.2467560-22-peter.maydell@linaro.org/mbox/","series":[{"id":283405,"url":"http://patchwork.ozlabs.org/api/series/283405/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=283405","date":"2022-01-28T15:29:53","name":"[PULL,01/32] Update copyright dates to 2022","version":1,"mbox":"http://patchwork.ozlabs.org/series/283405/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1585803/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1585803/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=bo0akB3w;\n\tdkim-atps=neutral","ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4JljyX0QPSz9t6g\n\tfor ; Sat, 29 Jan 2022 03:46:12 +1100 (AEDT)","from localhost ([::1]:51608 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1nDUO1-0000U9-Oy\n\tfor incoming@patchwork.ozlabs.org; Fri, 28 Jan 2022 11:46:09 -0500","from eggs.gnu.org ([209.51.188.92]:58118)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1nDTDP-0002IF-BM\n for qemu-devel@nongnu.org; Fri, 28 Jan 2022 10:31:07 -0500","from [2a00:1450:4864:20::430] (port=42597\n helo=mail-wr1-x430.google.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1nDTDK-0006QL-SM\n for qemu-devel@nongnu.org; Fri, 28 Jan 2022 10:31:06 -0500","by mail-wr1-x430.google.com with SMTP id a13so11560961wrh.9\n for ; Fri, 28 Jan 2022 07:30:36 -0800 (PST)","from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2])\n by smtp.gmail.com with ESMTPSA id j3sm4749485wrb.57.2022.01.28.07.30.34\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 28 Jan 2022 07:30:34 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:subject:date:message-id:in-reply-to:references:mime-version\n :content-transfer-encoding;\n bh=3BkzG1qOW+DZvKNI+SKdgFHpMvjgidL5omXaK1z9mCE=;\n b=bo0akB3wq5pnFDEW6AnGmzJ87UklTvgknuayv2eawh/yc1TBBSWO/bo53k07Y2NrSo\n YsPY5z9q6impbuO+u8DzC7Qe21dTmulS3G0pDiKWJrBzzFSAvFaleV+MaRui4vXf3473\n Nb5uOQ0tjKSBe8Nb+VEp/c4zfXwdHKveXAXDSdW3egum9DyOQrFlnQuJhyFBxkHVGvdk\n 3JdjetnD7LhhdyggVaZbPdVFNBW9eIWiHNPFho4krMD0Z+kt/snZf2cwyau/G5/aWHDI\n pkaMRf4ZAfV3kKd5hxgi/gfCFdDD/0zUiGLwzayVv5Fv0YR2WsIXNjNdf80AwB6gN5vZ\n YOaA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=3BkzG1qOW+DZvKNI+SKdgFHpMvjgidL5omXaK1z9mCE=;\n b=BE+ctVZIY8LSTGVmrSseqFNr+b2gI/RqbP7m3IuiYWL2FTz9dzhaSo6VdvsnWSLkpP\n vBbP0recjFxCSEr0hPk9L5vC5oAlwOjG9Cl4qbXRWf4sDeYZeg86hZSiIkc7a72T+/9z\n 7KQ7+FO0AHQHfyC1iw6W695sTaJc8HMhDMKsb/HvdMWgxSjzuWH0wo/hc7b0dnjbTita\n x9aoa3KHB7fUvocsCzNjfsF4Rtoe8gPRlJcqkpp+u4gzKzDyX+T4AAQUaABmK2qBtzcK\n r27DgeToURsfHluXuEmmW4xob+U//C9XO/9udmwKxAZSMx5AnIfvk8te4cKcjrCgs/k3\n eEMw==","X-Gm-Message-State":"AOAM533rSsmL2OuPOFVIRF8fLRVAyCjHVZ8rDKOvTkAvO6e96oUk1bU/\n 5CzGe3pq25VuemZgjBfw+pSrvoS3QIm+sA==","X-Google-Smtp-Source":"\n ABdhPJw53kWjNxDXZO8c/uXdEwBQaZJnIoJu0b1xI4NYLPlx5GJ1OINpbhitZXvxLdT9Pouwa55dpw==","X-Received":"by 2002:a5d:5343:: with SMTP id t3mr7686417wrv.521.1643383835205;\n Fri, 28 Jan 2022 07:30:35 -0800 (PST)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Subject":"[PULL 21/32] hw/intc/arm_gicv3_its: Don't clear GITS_CWRITER on\n writes to GITS_CBASER","Date":"Fri, 28 Jan 2022 15:29:58 +0000","Message-Id":"<20220128153009.2467560-22-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220128153009.2467560-1-peter.maydell@linaro.org>","References":"<20220128153009.2467560-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Host-Lookup-Failed":"Reverse DNS lookup failed for 2a00:1450:4864:20::430\n (failed)","Received-SPF":"pass client-ip=2a00:1450:4864:20::430;\n envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x430.google.com","X-Spam_score_int":"-12","X-Spam_score":"-1.3","X-Spam_bar":"-","X-Spam_report":"(-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "},"content":"The ITS specification says that when the guest writes to GITS_CBASER\nthis causes GITS_CREADR to be cleared. However it does not have an\nequivalent clause for GITS_CWRITER. (This is because GITS_CREADR is\nread-only, but GITS_CWRITER is writable and the guest can initialize\nit.) Remove the code that clears GITS_CWRITER on GITS_CBASER writes.\n\nSigned-off-by: Peter Maydell \nReviewed-by: Richard Henderson \nMessage-id: 20220122182444.724087-6-peter.maydell@linaro.org\n---\n hw/intc/arm_gicv3_its.c | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c\nindex 1763ba4a671..d9ff7b88492 100644\n--- a/hw/intc/arm_gicv3_its.c\n+++ b/hw/intc/arm_gicv3_its.c\n@@ -866,7 +866,6 @@ static bool its_writel(GICv3ITSState *s, hwaddr offset,\n if (!(s->ctlr & R_GITS_CTLR_ENABLED_MASK)) {\n s->cbaser = deposit64(s->cbaser, 0, 32, value);\n s->creadr = 0;\n- s->cwriter = s->creadr;\n }\n break;\n case GITS_CBASER + 4:\n@@ -877,7 +876,6 @@ static bool its_writel(GICv3ITSState *s, hwaddr offset,\n if (!(s->ctlr & R_GITS_CTLR_ENABLED_MASK)) {\n s->cbaser = deposit64(s->cbaser, 32, 32, value);\n s->creadr = 0;\n- s->cwriter = s->creadr;\n }\n break;\n case GITS_CWRITER:\n@@ -1027,7 +1025,6 @@ static bool its_writell(GICv3ITSState *s, hwaddr offset,\n if (!(s->ctlr & R_GITS_CTLR_ENABLED_MASK)) {\n s->cbaser = value;\n s->creadr = 0;\n- s->cwriter = s->creadr;\n }\n break;\n case GITS_CWRITER:\n","prefixes":["PULL","21/32"]}