{"id":1585790,"url":"http://patchwork.ozlabs.org/api/patches/1585790/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20220128153009.2467560-21-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20220128153009.2467560-21-peter.maydell@linaro.org>","list_archive_url":null,"date":"2022-01-28T15:29:57","name":"[PULL,20/32] hw/intc/arm_gicv3_its: Don't clear GITS_CREADR when GITS_CTLR.ENABLED is set","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"396b7a5f014a116d251fb4c5452a61ee2b58e844","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20220128153009.2467560-21-peter.maydell@linaro.org/mbox/","series":[{"id":283405,"url":"http://patchwork.ozlabs.org/api/series/283405/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=283405","date":"2022-01-28T15:29:53","name":"[PULL,01/32] Update copyright dates to 2022","version":1,"mbox":"http://patchwork.ozlabs.org/series/283405/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1585790/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1585790/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ERp3rE+N;\n\tdkim-atps=neutral","ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4JljVB2yw3z9t3b\n\tfor ; Sat, 29 Jan 2022 03:25:06 +1100 (AEDT)","from localhost ([::1]:45060 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1nDU3c-00017y-7A\n\tfor incoming@patchwork.ozlabs.org; Fri, 28 Jan 2022 11:25:04 -0500","from eggs.gnu.org ([209.51.188.92]:58072)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1nDTDN-0002Fz-S7\n for qemu-devel@nongnu.org; Fri, 28 Jan 2022 10:31:06 -0500","from [2a00:1450:4864:20::32a] (port=51037\n helo=mail-wm1-x32a.google.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1nDTDK-0006QH-SJ\n for qemu-devel@nongnu.org; Fri, 28 Jan 2022 10:31:05 -0500","by mail-wm1-x32a.google.com with SMTP id m26so2236644wms.0\n for ; Fri, 28 Jan 2022 07:30:35 -0800 (PST)","from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2])\n by smtp.gmail.com with ESMTPSA id j3sm4749485wrb.57.2022.01.28.07.30.33\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 28 Jan 2022 07:30:34 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:subject:date:message-id:in-reply-to:references:mime-version\n :content-transfer-encoding;\n bh=OdtIkV/XqQbri3TA1b5zl/FnINW56thqfzKkEfK6UQo=;\n b=ERp3rE+NPQ5I6tC38USzx29S2c9NyMEUnopuxMRhpLazGp2RLMwrA1ZMVzIA2uYNai\n giafQVnmkYSBzC5gQ7BFe61vgSXEn1PpOi2CVouXndyEJOIoEcYpOwtseX2lr0I8rj6z\n yTz0lcRuH9uB9itcr3+D/xnUkRw3Hd8XxoY1RnCn9Ag4EujpwQvujGnrIQv+ohaeJa18\n ldcxeMlECKGhsAUT64psOuof9U2Futng4K4TxzOUfMo+pi+UbPnPxrduJ1CKZk/erp/u\n AOVi18W0pNZbSIfbRHn12vfcmBwFFfyr+Qz35VmANBQPNpFUIe+IluY2/ckNcblRfZap\n qHsQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=OdtIkV/XqQbri3TA1b5zl/FnINW56thqfzKkEfK6UQo=;\n b=cTT641qHiblAuYTV7uN+9Ik22Y0nvc0dK4qca6tYv8qfpON6nK2SNBDCaRsEHE0ktA\n pfvdW82n/VCgE2ye1iHP3Y161ewSNyT4xYX6hnLWxjlU+irQ+oJ5TW7VFLldBtLrXHgR\n I3xZ1JqoGHY6gTlsLMmY60zkMtYMh96O8x4hSrpwnG3HDhNDjsCPPxx3iAaSiIjeCySW\n R4toHqdlHoajR4XwvEO993+wtdnwzecX/R1mxLv84YeZnn0eYh3RegEdk+9BV8oBmucK\n 7LQNY+0IUCS45pyQ7VEg1QGFxDD+qCQd4uzwn9F5bSZJ4xVAoE38jmOwGd1dqSnv+V8x\n u+Cg==","X-Gm-Message-State":"AOAM533pV/ZFqMmMXM2Mfo+DeOENwoA5pcnss+QIBzPoKCYoTjxuH4iB\n XQPn2vM/M1PbuGsBNVCmSlrWd2ikfyx5jQ==","X-Google-Smtp-Source":"\n ABdhPJxDQk6nhiUQ90LPgqd8/+b5K9CBPlKQK26kUzad6+5/MlyvWY6x66zI7HhxwXf9XIqPfKSr/A==","X-Received":"by 2002:a1c:4455:: with SMTP id r82mr7704132wma.103.1643383834380;\n Fri, 28 Jan 2022 07:30:34 -0800 (PST)","From":"Peter Maydell ","To":"qemu-devel@nongnu.org","Subject":"[PULL 20/32] hw/intc/arm_gicv3_its: Don't clear GITS_CREADR when\n GITS_CTLR.ENABLED is set","Date":"Fri, 28 Jan 2022 15:29:57 +0000","Message-Id":"<20220128153009.2467560-21-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220128153009.2467560-1-peter.maydell@linaro.org>","References":"<20220128153009.2467560-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Host-Lookup-Failed":"Reverse DNS lookup failed for 2a00:1450:4864:20::32a\n (failed)","Received-SPF":"pass client-ip=2a00:1450:4864:20::32a;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32a.google.com","X-Spam_score_int":"-12","X-Spam_score":"-1.3","X-Spam_bar":"-","X-Spam_report":"(-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "},"content":"The current ITS code clears GITS_CREADR when GITS_CTLR.ENABLED is set.\nThis is not correct -- guest code can validly clear ENABLED and then\nset it again and expect the ITS to continue processing where it left\noff. Remove the erroneous assignment.\n\nSigned-off-by: Peter Maydell \nReviewed-by: Richard Henderson \nMessage-id: 20220122182444.724087-5-peter.maydell@linaro.org\n---\n hw/intc/arm_gicv3_its.c | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c\nindex 67f12d98af3..1763ba4a671 100644\n--- a/hw/intc/arm_gicv3_its.c\n+++ b/hw/intc/arm_gicv3_its.c\n@@ -853,7 +853,6 @@ static bool its_writel(GICv3ITSState *s, hwaddr offset,\n s->ctlr |= R_GITS_CTLR_ENABLED_MASK;\n extract_table_params(s);\n extract_cmdq_params(s);\n- s->creadr = 0;\n process_cmdq(s);\n } else {\n s->ctlr &= ~R_GITS_CTLR_ENABLED_MASK;\n","prefixes":["PULL","20/32"]}