{"id":1571486,"url":"http://patchwork.ozlabs.org/api/patches/1571486/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20211221065855.142578-16-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20211221065855.142578-16-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2021-12-21T06:58:34","name":"[PULL,v2,15/36] ui: dispatch GL events to all listeners","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"695762c30311412ed80d1202ee6f6df7558db405","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20211221065855.142578-16-marcandre.lureau@redhat.com/mbox/","series":[{"id":277865,"url":"http://patchwork.ozlabs.org/api/series/277865/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=277865","date":"2021-12-21T06:58:19","name":"[PULL,v2,01/36] ui/vdagent: add CHECK_SPICE_PROTOCOL_VERSION","version":2,"mbox":"http://patchwork.ozlabs.org/series/277865/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1571486/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1571486/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=IU3L6S9j;\n\tdkim-atps=neutral","ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4JJ7Xt2kMPz9s3q\n\tfor ; Tue, 21 Dec 2021 18:35:42 +1100 (AEDT)","from localhost ([::1]:39410 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1mzZgR-0006hX-GK\n\tfor incoming@patchwork.ozlabs.org; Tue, 21 Dec 2021 02:35:39 -0500","from eggs.gnu.org ([209.51.188.92]:58640)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1mzZAq-0005aJ-2O\n for qemu-devel@nongnu.org; Tue, 21 Dec 2021 02:03:00 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47565)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1mzZAo-00025O-Dv\n for qemu-devel@nongnu.org; Tue, 21 Dec 2021 02:02:59 -0500","from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-166-Bt9Gs-qFMLKvki92VgYbww-1; Tue, 21 Dec 2021 02:02:54 -0500","from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com\n [10.5.11.14])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8E4A71006AA7;\n Tue, 21 Dec 2021 07:02:53 +0000 (UTC)","from localhost (unknown [10.39.208.37])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 10E3F7A426;\n Tue, 21 Dec 2021 07:02:44 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1640070177;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=0CTOXlzpGeLk5q64FnEbOBtZCYbNColSGZ3DvHQlAUo=;\n b=IU3L6S9jGsgPCm9aC0bkOxHYj5/j/S2cC0ifaLP3/053hTNlgUCNBHu6rgEjqDFnO8qbko\n gUEeRJqY9vWrxQonA9mH+9Gh6xLRlm8EKfnrnsDkK60zIKHUfvJvJ6l5BTJcK1zTJUf9F3\n 1Cz1aXivarRMC+JR6TPCygWwHecZBQI=","X-MC-Unique":"Bt9Gs-qFMLKvki92VgYbww-1","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Subject":"[PULL v2 15/36] ui: dispatch GL events to all listeners","Date":"Tue, 21 Dec 2021 10:58:34 +0400","Message-Id":"<20211221065855.142578-16-marcandre.lureau@redhat.com>","In-Reply-To":"<20211221065855.142578-1-marcandre.lureau@redhat.com>","References":"<20211221065855.142578-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-29","X-Spam_score":"-3.0","X-Spam_bar":"---","X-Spam_report":"(-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.203,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"peter.maydell@linaro.org, richard.henderson@linaro.org, =?utf-8?q?Marc-A?=\n\t=?utf-8?q?ndr=C3=A9_Lureau?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "},"content":"From: Marc-André Lureau \n\nFor now, only one listener can receive GL events. Let's dispatch to all\nlisteners. (preliminary check ensure there is a single listener now\nduring regitration, and in next patches, compatible listeners only)\n\nSigned-off-by: Marc-André Lureau \nAcked-by: Gerd Hoffmann \n---\n ui/console.c | 58 +++++++++++++++++++++++++++++++++++++---------------\n 1 file changed, 42 insertions(+), 16 deletions(-)","diff":"diff --git a/ui/console.c b/ui/console.c\nindex 6f21007737e5..13c0d001c096 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -1824,8 +1824,12 @@ int dpy_gl_ctx_make_current(QemuConsole *con, QEMUGLContext ctx)\n \n void dpy_gl_scanout_disable(QemuConsole *con)\n {\n- assert(con->gl);\n- con->gl->ops->dpy_gl_scanout_disable(con->gl);\n+ DisplayState *s = con->ds;\n+ DisplayChangeListener *dcl;\n+\n+ QLIST_FOREACH(dcl, &s->listeners, next) {\n+ dcl->ops->dpy_gl_scanout_disable(dcl);\n+ }\n }\n \n void dpy_gl_scanout_texture(QemuConsole *con,\n@@ -1836,58 +1840,80 @@ void dpy_gl_scanout_texture(QemuConsole *con,\n uint32_t x, uint32_t y,\n uint32_t width, uint32_t height)\n {\n- assert(con->gl);\n- con->gl->ops->dpy_gl_scanout_texture(con->gl, backing_id,\n+ DisplayState *s = con->ds;\n+ DisplayChangeListener *dcl;\n+\n+ QLIST_FOREACH(dcl, &s->listeners, next) {\n+ dcl->ops->dpy_gl_scanout_texture(dcl, backing_id,\n backing_y_0_top,\n backing_width, backing_height,\n x, y, width, height);\n+ }\n }\n \n void dpy_gl_scanout_dmabuf(QemuConsole *con,\n QemuDmaBuf *dmabuf)\n {\n- assert(con->gl);\n- con->gl->ops->dpy_gl_scanout_dmabuf(con->gl, dmabuf);\n+ DisplayState *s = con->ds;\n+ DisplayChangeListener *dcl;\n+\n+ QLIST_FOREACH(dcl, &s->listeners, next) {\n+ dcl->ops->dpy_gl_scanout_dmabuf(dcl, dmabuf);\n+ }\n }\n \n void dpy_gl_cursor_dmabuf(QemuConsole *con, QemuDmaBuf *dmabuf,\n bool have_hot, uint32_t hot_x, uint32_t hot_y)\n {\n- assert(con->gl);\n+ DisplayState *s = con->ds;\n+ DisplayChangeListener *dcl;\n \n- if (con->gl->ops->dpy_gl_cursor_dmabuf) {\n- con->gl->ops->dpy_gl_cursor_dmabuf(con->gl, dmabuf,\n+ QLIST_FOREACH(dcl, &s->listeners, next) {\n+ if (dcl->ops->dpy_gl_cursor_dmabuf) {\n+ dcl->ops->dpy_gl_cursor_dmabuf(dcl, dmabuf,\n have_hot, hot_x, hot_y);\n+ }\n }\n }\n \n void dpy_gl_cursor_position(QemuConsole *con,\n uint32_t pos_x, uint32_t pos_y)\n {\n- assert(con->gl);\n+ DisplayState *s = con->ds;\n+ DisplayChangeListener *dcl;\n \n- if (con->gl->ops->dpy_gl_cursor_position) {\n- con->gl->ops->dpy_gl_cursor_position(con->gl, pos_x, pos_y);\n+ QLIST_FOREACH(dcl, &s->listeners, next) {\n+ if (dcl->ops->dpy_gl_cursor_position) {\n+ dcl->ops->dpy_gl_cursor_position(dcl, pos_x, pos_y);\n+ }\n }\n }\n \n void dpy_gl_release_dmabuf(QemuConsole *con,\n QemuDmaBuf *dmabuf)\n {\n- assert(con->gl);\n+ DisplayState *s = con->ds;\n+ DisplayChangeListener *dcl;\n \n- if (con->gl->ops->dpy_gl_release_dmabuf) {\n- con->gl->ops->dpy_gl_release_dmabuf(con->gl, dmabuf);\n+ QLIST_FOREACH(dcl, &s->listeners, next) {\n+ if (dcl->ops->dpy_gl_release_dmabuf) {\n+ dcl->ops->dpy_gl_release_dmabuf(dcl, dmabuf);\n+ }\n }\n }\n \n void dpy_gl_update(QemuConsole *con,\n uint32_t x, uint32_t y, uint32_t w, uint32_t h)\n {\n+ DisplayState *s = con->ds;\n+ DisplayChangeListener *dcl;\n+\n assert(con->gl);\n \n graphic_hw_gl_block(con, true);\n- con->gl->ops->dpy_gl_update(con->gl, x, y, w, h);\n+ QLIST_FOREACH(dcl, &s->listeners, next) {\n+ dcl->ops->dpy_gl_update(dcl, x, y, w, h);\n+ }\n graphic_hw_gl_block(con, false);\n }\n \n","prefixes":["PULL","v2","15/36"]}