{"id":1571406,"url":"http://patchwork.ozlabs.org/api/patches/1571406/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20211221065855.142578-11-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20211221065855.142578-11-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2021-12-21T06:58:29","name":"[PULL,v2,10/36] ui: factor out qemu_console_set_display_gl_ctx()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4289b07f2e4c917a8a6920e912e17bcb87854810","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20211221065855.142578-11-marcandre.lureau@redhat.com/mbox/","series":[{"id":277865,"url":"http://patchwork.ozlabs.org/api/series/277865/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=277865","date":"2021-12-21T06:58:19","name":"[PULL,v2,01/36] ui/vdagent: add CHECK_SPICE_PROTOCOL_VERSION","version":2,"mbox":"http://patchwork.ozlabs.org/series/277865/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1571406/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1571406/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=fDxXZqaL;\n\tdkim-atps=neutral","ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4JJ7CN4lgMz9s3q\n\tfor ; Tue, 21 Dec 2021 18:20:32 +1100 (AEDT)","from localhost ([::1]:49506 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1mzZRm-0002ED-Ef\n\tfor incoming@patchwork.ozlabs.org; Tue, 21 Dec 2021 02:20:30 -0500","from eggs.gnu.org ([209.51.188.92]:58486)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1mzZA1-0003rm-PA\n for qemu-devel@nongnu.org; Tue, 21 Dec 2021 02:02:09 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59424)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1mzZA0-00021e-39\n for qemu-devel@nongnu.org; Tue, 21 Dec 2021 02:02:09 -0500","from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-648-aKw7BnK-OJKy4qszrlgxig-1; Tue, 21 Dec 2021 02:02:06 -0500","from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com\n [10.5.11.23])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 64C82802C92;\n Tue, 21 Dec 2021 07:02:05 +0000 (UTC)","from localhost (unknown [10.39.208.37])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 2ED0538E09;\n Tue, 21 Dec 2021 07:01:58 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1640070127;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Yy7mIZIXs4aytO347LRaT/OfoSNmk0dCfOOTskWgU68=;\n b=fDxXZqaLxjEcAO0WvnVAe2nETmScfFgfqmiGN7qLwySQJ+qxn5oCceFD2Ns1p3UwQE7bjW\n EjGADdunxiik60UpGoUhTP6Gp6KSE548y/6/3rhMR1yS6c4RHpugAc7YO1T5gaqmwSWY7d\n KzoTMgHn5RutBe7pL+jIq4j/ywkiOoY=","X-MC-Unique":"aKw7BnK-OJKy4qszrlgxig-1","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Subject":"[PULL v2 10/36] ui: factor out qemu_console_set_display_gl_ctx()","Date":"Tue, 21 Dec 2021 10:58:29 +0400","Message-Id":"<20211221065855.142578-11-marcandre.lureau@redhat.com>","In-Reply-To":"<20211221065855.142578-1-marcandre.lureau@redhat.com>","References":"<20211221065855.142578-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.84 on 10.5.11.23","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-29","X-Spam_score":"-3.0","X-Spam_bar":"---","X-Spam_report":"(-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.203,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"peter.maydell@linaro.org, richard.henderson@linaro.org, =?utf-8?q?Marc-A?=\n\t=?utf-8?q?ndr=C3=A9_Lureau?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "},"content":"From: Marc-André Lureau \n\nThe next patch will make use of this function to dissociate\nDisplayChangeListener from GL context.\n\nSigned-off-by: Marc-André Lureau \nAcked-by: Gerd Hoffmann \nReviewed-by: Philippe Mathieu-Daudé \n---\n include/ui/console.h | 3 +++\n ui/console.c | 22 ++++++++++++++--------\n 2 files changed, 17 insertions(+), 8 deletions(-)","diff":"diff --git a/include/ui/console.h b/include/ui/console.h\nindex 65e6bbcab8ae..fb10e6d60cd7 100644\n--- a/include/ui/console.h\n+++ b/include/ui/console.h\n@@ -411,6 +411,9 @@ void graphic_hw_gl_flushed(QemuConsole *con);\n \n void qemu_console_early_init(void);\n \n+void qemu_console_set_display_gl_ctx(QemuConsole *con,\n+ DisplayChangeListener *dcl);\n+\n QemuConsole *qemu_console_lookup_by_index(unsigned int index);\n QemuConsole *qemu_console_lookup_by_device(DeviceState *dev, uint32_t head);\n QemuConsole *qemu_console_lookup_by_device_name(const char *device_id,\ndiff --git a/ui/console.c b/ui/console.c\nindex dcc21eb5b244..7b83e6cdea77 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -1443,6 +1443,19 @@ static bool dpy_compatible_with(QemuConsole *con,\n return true;\n }\n \n+void qemu_console_set_display_gl_ctx(QemuConsole *con,\n+ DisplayChangeListener *dcl)\n+{\n+ /* display has opengl support */\n+ assert(dcl->con);\n+ if (dcl->con->gl) {\n+ fprintf(stderr, \"can't register two opengl displays (%s, %s)\\n\",\n+ dcl->ops->dpy_name, dcl->con->gl->ops->dpy_name);\n+ exit(1);\n+ }\n+ dcl->con->gl = dcl;\n+}\n+\n void register_displaychangelistener(DisplayChangeListener *dcl)\n {\n static const char nodev[] =\n@@ -1453,14 +1466,7 @@ void register_displaychangelistener(DisplayChangeListener *dcl)\n assert(!dcl->ds);\n \n if (dcl->ops->dpy_gl_ctx_create) {\n- /* display has opengl support */\n- assert(dcl->con);\n- if (dcl->con->gl) {\n- fprintf(stderr, \"can't register two opengl displays (%s, %s)\\n\",\n- dcl->ops->dpy_name, dcl->con->gl->ops->dpy_name);\n- exit(1);\n- }\n- dcl->con->gl = dcl;\n+ qemu_console_set_display_gl_ctx(dcl->con, dcl);\n }\n \n if (dcl->con) {\n","prefixes":["PULL","v2","10/36"]}