{"id":1571400,"url":"http://patchwork.ozlabs.org/api/patches/1571400/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20211221065855.142578-14-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20211221065855.142578-14-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2021-12-21T06:58:32","name":"[PULL,v2,13/36] ui: add a gl-unblock warning timer","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9109b1469dea695e131f719180dbc4d35151dfa0","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20211221065855.142578-14-marcandre.lureau@redhat.com/mbox/","series":[{"id":277865,"url":"http://patchwork.ozlabs.org/api/series/277865/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=277865","date":"2021-12-21T06:58:19","name":"[PULL,v2,01/36] ui/vdagent: add CHECK_SPICE_PROTOCOL_VERSION","version":2,"mbox":"http://patchwork.ozlabs.org/series/277865/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1571400/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1571400/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=XneTgXDw;\n\tdkim-atps=neutral","ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4JJ6yr2Thnz9s3q\n\tfor ; Tue, 21 Dec 2021 18:09:40 +1100 (AEDT)","from localhost ([::1]:37542 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1mzZHE-0001nx-BN\n\tfor incoming@patchwork.ozlabs.org; Tue, 21 Dec 2021 02:09:36 -0500","from eggs.gnu.org ([209.51.188.92]:58582)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1mzZAR-0004fN-Vv\n for qemu-devel@nongnu.org; Tue, 21 Dec 2021 02:02:36 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:39169)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1mzZAQ-00024Q-CG\n for qemu-devel@nongnu.org; Tue, 21 Dec 2021 02:02:35 -0500","from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-333-IQobmik0NIWdplQnIxvY7g-1; Tue, 21 Dec 2021 02:02:30 -0500","from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9982F2F46;\n Tue, 21 Dec 2021 07:02:29 +0000 (UTC)","from localhost (unknown [10.39.208.37])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D3B0C7E8EF;\n Tue, 21 Dec 2021 07:02:28 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1640070153;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=zVIEwc4U/GyNxdlw3OLMiafyh68EowCHnLZunJbM8js=;\n b=XneTgXDw7yYn2E0CW7bRtfz/LAKy2GRQDHmpKQtrh4GD/NGlMQy00MiMy/Lm7lwRQ65tFg\n JxxrNXSwddrjGckKHnVT0OXqgyX3aLlzT7YtzvTWCUOmnL0CKvW8PnwqUQx23pB4of/pkA\n 1blIT7diIpIz2QeG5ttbVl64XHV9dmg=","X-MC-Unique":"IQobmik0NIWdplQnIxvY7g-1","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Subject":"[PULL v2 13/36] ui: add a gl-unblock warning timer","Date":"Tue, 21 Dec 2021 10:58:32 +0400","Message-Id":"<20211221065855.142578-14-marcandre.lureau@redhat.com>","In-Reply-To":"<20211221065855.142578-1-marcandre.lureau@redhat.com>","References":"<20211221065855.142578-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-29","X-Spam_score":"-3.0","X-Spam_bar":"---","X-Spam_report":"(-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.203,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"peter.maydell@linaro.org, richard.henderson@linaro.org, =?utf-8?q?Marc-A?=\n\t=?utf-8?q?ndr=C3=A9_Lureau?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "},"content":"From: Marc-André Lureau \n\nSimilar to the one that exists for Spice, so we can investigate if\nsomething is locked.\n\nSigned-off-by: Marc-André Lureau \nAcked-by: Gerd Hoffmann \n---\n ui/console.c | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)","diff":"diff --git a/ui/console.c b/ui/console.c\nindex 39f7b66baf54..fcc4fe6a0aa0 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -80,6 +80,7 @@ struct QemuConsole {\n int dcls;\n DisplayChangeListener *gl;\n int gl_block;\n+ QEMUTimer *gl_unblock_timer;\n int window_id;\n \n /* Graphic console state. */\n@@ -233,8 +234,14 @@ void graphic_hw_update(QemuConsole *con)\n }\n }\n \n+static void graphic_hw_gl_unblock_timer(void *opaque)\n+{\n+ warn_report(\"console: no gl-unblock within one second\");\n+}\n+\n void graphic_hw_gl_block(QemuConsole *con, bool block)\n {\n+ uint64_t timeout;\n assert(con != NULL);\n \n if (block) {\n@@ -250,6 +257,14 @@ void graphic_hw_gl_block(QemuConsole *con, bool block)\n return;\n }\n con->hw_ops->gl_block(con->hw, block);\n+\n+ if (block) {\n+ timeout = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);\n+ timeout += 1000; /* one sec */\n+ timer_mod(con->gl_unblock_timer, timeout);\n+ } else {\n+ timer_del(con->gl_unblock_timer);\n+ }\n }\n \n void graphic_hw_gl_flushed(QemuConsole *con)\n@@ -1966,6 +1981,8 @@ QemuConsole *graphic_console_init(DeviceState *dev, uint32_t head,\n \n surface = qemu_create_placeholder_surface(width, height, noinit);\n dpy_gfx_replace_surface(s, surface);\n+ s->gl_unblock_timer = timer_new_ms(QEMU_CLOCK_REALTIME,\n+ graphic_hw_gl_unblock_timer, s);\n return s;\n }\n \n","prefixes":["PULL","v2","13/36"]}