{"id":1571398,"url":"http://patchwork.ozlabs.org/api/patches/1571398/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20211221065855.142578-3-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20211221065855.142578-3-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2021-12-21T06:58:21","name":"[PULL,v2,02/36] ui/vdagent: replace #if 0 with protocol version check","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"393d72f95740d075ad5952c378fc718c70c6f919","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20211221065855.142578-3-marcandre.lureau@redhat.com/mbox/","series":[{"id":277865,"url":"http://patchwork.ozlabs.org/api/series/277865/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=277865","date":"2021-12-21T06:58:19","name":"[PULL,v2,01/36] ui/vdagent: add CHECK_SPICE_PROTOCOL_VERSION","version":2,"mbox":"http://patchwork.ozlabs.org/series/277865/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1571398/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1571398/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=iBjMyPHp;\n\tdkim-atps=neutral","ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4JJ6t34ZcYz9s3q\n\tfor ; Tue, 21 Dec 2021 18:05:31 +1100 (AEDT)","from localhost ([::1]:60604 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1mzZDF-0006T4-CB\n\tfor incoming@patchwork.ozlabs.org; Tue, 21 Dec 2021 02:05:29 -0500","from eggs.gnu.org ([209.51.188.92]:58052)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1mzZ7f-0001dB-NK\n for qemu-devel@nongnu.org; Tue, 21 Dec 2021 01:59:43 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37196)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1mzZ7e-0001fO-8D\n for qemu-devel@nongnu.org; Tue, 21 Dec 2021 01:59:43 -0500","from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-416-Uhkzp8O_ORiWhDlIU8D2Ww-1; Tue, 21 Dec 2021 01:59:40 -0500","from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com\n [10.5.11.23])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3C0A801B31;\n Tue, 21 Dec 2021 06:59:39 +0000 (UTC)","from localhost (unknown [10.39.208.37])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 15FED38E02;\n Tue, 21 Dec 2021 06:59:28 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1640069981;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1NPxNJl2P8NzMZgu63BRXG6ySBfg6/iOpK/WPgt+1bc=;\n b=iBjMyPHpXt2grXKZvaES/v1AOT7fe2vTb0nCBjdXmRnMMccEiNwnRhXAFOf0KI0EmrTw8t\n pKUp33J4IMd3c3FFCZCQA006XrlTD0sf/dYi65vlDMQ2L9SCEYGglP7+76ZhyGZqwN59CY\n sreTTS69rSnuVsfUH+vSxb/uwTVTkqg=","X-MC-Unique":"Uhkzp8O_ORiWhDlIU8D2Ww-1","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Subject":"[PULL v2 02/36] ui/vdagent: replace #if 0 with protocol version check","Date":"Tue, 21 Dec 2021 10:58:21 +0400","Message-Id":"<20211221065855.142578-3-marcandre.lureau@redhat.com>","In-Reply-To":"<20211221065855.142578-1-marcandre.lureau@redhat.com>","References":"<20211221065855.142578-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.84 on 10.5.11.23","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-29","X-Spam_score":"-3.0","X-Spam_bar":"---","X-Spam_report":"(-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.203,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"peter.maydell@linaro.org, richard.henderson@linaro.org, =?utf-8?q?Marc-A?=\n\t=?utf-8?q?ndr=C3=A9_Lureau?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "},"content":"From: Marc-André Lureau \n\nSigned-off-by: Marc-André Lureau \nAcked-by: Gerd Hoffmann \n---\n ui/vdagent.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)","diff":"diff --git a/ui/vdagent.c b/ui/vdagent.c\nindex 1f8fc77ee8f3..64e00170017f 100644\n--- a/ui/vdagent.c\n+++ b/ui/vdagent.c\n@@ -87,8 +87,10 @@ static const char *cap_name[] = {\n [VD_AGENT_CAP_MONITORS_CONFIG_POSITION] = \"monitors-config-position\",\n [VD_AGENT_CAP_FILE_XFER_DISABLED] = \"file-xfer-disabled\",\n [VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS] = \"file-xfer-detailed-errors\",\n-#if 0\n+#if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 0)\n [VD_AGENT_CAP_GRAPHICS_DEVICE_INFO] = \"graphics-device-info\",\n+#endif\n+#if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 1)\n [VD_AGENT_CAP_CLIPBOARD_NO_RELEASE_ON_REGRAB] = \"clipboard-no-release-on-regrab\",\n [VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL] = \"clipboard-grab-serial\",\n #endif\n@@ -110,7 +112,7 @@ static const char *msg_name[] = {\n [VD_AGENT_CLIENT_DISCONNECTED] = \"client-disconnected\",\n [VD_AGENT_MAX_CLIPBOARD] = \"max-clipboard\",\n [VD_AGENT_AUDIO_VOLUME_SYNC] = \"audio-volume-sync\",\n-#if 0\n+#if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 0)\n [VD_AGENT_GRAPHICS_DEVICE_INFO] = \"graphics-device-info\",\n #endif\n };\n@@ -128,7 +130,7 @@ static const char *type_name[] = {\n [VD_AGENT_CLIPBOARD_IMAGE_BMP] = \"bmp\",\n [VD_AGENT_CLIPBOARD_IMAGE_TIFF] = \"tiff\",\n [VD_AGENT_CLIPBOARD_IMAGE_JPG] = \"jpg\",\n-#if 0\n+#if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 3)\n [VD_AGENT_CLIPBOARD_FILE_LIST] = \"files\",\n #endif\n };\n","prefixes":["PULL","v2","02/36"]}