{"id":1571395,"url":"http://patchwork.ozlabs.org/api/patches/1571395/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20211221065855.142578-10-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20211221065855.142578-10-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2021-12-21T06:58:28","name":"[PULL,v2,09/36] ui: do not delay further remote resize","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"565a3569d3f67ebb5621b66978dd20477e99930e","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20211221065855.142578-10-marcandre.lureau@redhat.com/mbox/","series":[{"id":277865,"url":"http://patchwork.ozlabs.org/api/series/277865/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=277865","date":"2021-12-21T06:58:19","name":"[PULL,v2,01/36] ui/vdagent: add CHECK_SPICE_PROTOCOL_VERSION","version":2,"mbox":"http://patchwork.ozlabs.org/series/277865/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1571395/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1571395/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=IZZs3ElG;\n\tdkim-atps=neutral","ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4JJ6q91HqGz9s3q\n\tfor ; Tue, 21 Dec 2021 18:03:01 +1100 (AEDT)","from localhost ([::1]:57096 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1mzZAo-0003sz-SF\n\tfor incoming@patchwork.ozlabs.org; Tue, 21 Dec 2021 02:02:58 -0500","from eggs.gnu.org ([209.51.188.92]:58474)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1mzZA0-0003pR-JJ\n for qemu-devel@nongnu.org; Tue, 21 Dec 2021 02:02:08 -0500","from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:40461)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1mzZ9v-00021U-2p\n for qemu-devel@nongnu.org; Tue, 21 Dec 2021 02:02:08 -0500","from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-297-g8UtPxARPmmHg4cOAdNKjA-1; Tue, 21 Dec 2021 02:01:56 -0500","from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 918551006AA5;\n Tue, 21 Dec 2021 07:01:55 +0000 (UTC)","from localhost (unknown [10.39.208.37])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8D484838E4;\n Tue, 21 Dec 2021 07:01:54 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1640070122;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=hE9YWsmTm38tqLhb1PCblibvG6EgJPixnrLwcacfk3s=;\n b=IZZs3ElGUnLJJ1VOop5yDtG6A+npK08WOdWePiVYG+gjbFdi/cA/7OwPf3ni5B6y6h++Y7\n 80z4KS1qS2gGKHyVbijl5C+FTvYA6vzmR4xYOPt8qg8Kd1dYEq4JaNjNvodTFSSnoj5+uh\n PviGR0PVoi1E3idLucSrqEbx8/8MGv0=","X-MC-Unique":"g8UtPxARPmmHg4cOAdNKjA-1","From":"marcandre.lureau@redhat.com","To":"qemu-devel@nongnu.org","Subject":"[PULL v2 09/36] ui: do not delay further remote resize","Date":"Tue, 21 Dec 2021 10:58:28 +0400","Message-Id":"<20211221065855.142578-10-marcandre.lureau@redhat.com>","In-Reply-To":"<20211221065855.142578-1-marcandre.lureau@redhat.com>","References":"<20211221065855.142578-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-29","X-Spam_score":"-3.0","X-Spam_bar":"---","X-Spam_report":"(-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.203,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"peter.maydell@linaro.org, richard.henderson@linaro.org, =?utf-8?q?Marc-A?=\n\t=?utf-8?q?ndr=C3=A9_Lureau?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "},"content":"From: Marc-André Lureau \n\nA remote client, such as Spice, will already avoid flooding the stream\nby delaying the resize requests.\n\nSigned-off-by: Marc-André Lureau \nAcked-by: Gerd Hoffmann \n---\n include/ui/console.h | 2 +-\n ui/console.c | 5 +++--\n ui/gtk.c | 2 +-\n ui/sdl2.c | 2 +-\n ui/spice-display.c | 2 +-\n ui/vnc.c | 2 +-\n ui/cocoa.m | 2 +-\n 7 files changed, 9 insertions(+), 8 deletions(-)","diff":"diff --git a/include/ui/console.h b/include/ui/console.h\nindex 6d678924f6fd..65e6bbcab8ae 100644\n--- a/include/ui/console.h\n+++ b/include/ui/console.h\n@@ -292,7 +292,7 @@ void unregister_displaychangelistener(DisplayChangeListener *dcl);\n \n bool dpy_ui_info_supported(QemuConsole *con);\n const QemuUIInfo *dpy_get_ui_info(const QemuConsole *con);\n-int dpy_set_ui_info(QemuConsole *con, QemuUIInfo *info);\n+int dpy_set_ui_info(QemuConsole *con, QemuUIInfo *info, bool delay);\n \n void dpy_gfx_update(QemuConsole *con, int x, int y, int w, int h);\n void dpy_gfx_update_full(QemuConsole *con);\ndiff --git a/ui/console.c b/ui/console.c\nindex 29a3e3f0f51c..dcc21eb5b244 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -1538,7 +1538,7 @@ const QemuUIInfo *dpy_get_ui_info(const QemuConsole *con)\n return &con->ui_info;\n }\n \n-int dpy_set_ui_info(QemuConsole *con, QemuUIInfo *info)\n+int dpy_set_ui_info(QemuConsole *con, QemuUIInfo *info, bool delay)\n {\n if (con == NULL) {\n con = active_console;\n@@ -1558,7 +1558,8 @@ int dpy_set_ui_info(QemuConsole *con, QemuUIInfo *info)\n * go notify the guest.\n */\n con->ui_info = *info;\n- timer_mod(con->ui_timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + 1000);\n+ timer_mod(con->ui_timer,\n+ qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + (delay ? 1000 : 0));\n return 0;\n }\n \ndiff --git a/ui/gtk.c b/ui/gtk.c\nindex 428f02f2dfe1..c0d8a9f061ee 100644\n--- a/ui/gtk.c\n+++ b/ui/gtk.c\n@@ -698,7 +698,7 @@ static void gd_set_ui_info(VirtualConsole *vc, gint width, gint height)\n memset(&info, 0, sizeof(info));\n info.width = width;\n info.height = height;\n- dpy_set_ui_info(vc->gfx.dcl.con, &info);\n+ dpy_set_ui_info(vc->gfx.dcl.con, &info, true);\n }\n \n #if defined(CONFIG_OPENGL)\ndiff --git a/ui/sdl2.c b/ui/sdl2.c\nindex 17c0ec30ebff..9ba3bc49e798 100644\n--- a/ui/sdl2.c\n+++ b/ui/sdl2.c\n@@ -561,7 +561,7 @@ static void handle_windowevent(SDL_Event *ev)\n memset(&info, 0, sizeof(info));\n info.width = ev->window.data1;\n info.height = ev->window.data2;\n- dpy_set_ui_info(scon->dcl.con, &info);\n+ dpy_set_ui_info(scon->dcl.con, &info, true);\n }\n sdl2_redraw(scon);\n break;\ndiff --git a/ui/spice-display.c b/ui/spice-display.c\nindex f59c69882d91..52d9f3260aab 100644\n--- a/ui/spice-display.c\n+++ b/ui/spice-display.c\n@@ -692,7 +692,7 @@ static int interface_client_monitors_config(QXLInstance *sin,\n }\n \n trace_qemu_spice_ui_info(ssd->qxl.id, info.width, info.height);\n- dpy_set_ui_info(ssd->dcl.con, &info);\n+ dpy_set_ui_info(ssd->dcl.con, &info, false);\n return 1;\n }\n \ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex 9b603382e75e..1ed1c7efc688 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -2596,7 +2596,7 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len)\n memset(&info, 0, sizeof(info));\n info.width = w;\n info.height = h;\n- dpy_set_ui_info(vs->vd->dcl.con, &info);\n+ dpy_set_ui_info(vs->vd->dcl.con, &info, false);\n vnc_desktop_resize_ext(vs, 4 /* Request forwarded */);\n } else {\n vnc_desktop_resize_ext(vs, 3 /* Invalid screen layout */);\ndiff --git a/ui/cocoa.m b/ui/cocoa.m\nindex 7ca429fa8078..69745c483b45 100644\n--- a/ui/cocoa.m\n+++ b/ui/cocoa.m\n@@ -552,7 +552,7 @@ QemuCocoaView *cocoaView;\n info.width = frameSize.width;\n info.height = frameSize.height;\n \n- dpy_set_ui_info(dcl.con, &info);\n+ dpy_set_ui_info(dcl.con, &info, TRUE);\n }\n \n - (void)viewDidMoveToWindow\n","prefixes":["PULL","v2","09/36"]}