{"id":1460184,"url":"http://patchwork.ozlabs.org/api/patches/1460184/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/0c80a08ad4cf788c75043c1615c05bad893f4fde.1617126961.git.danielwa@cisco.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<0c80a08ad4cf788c75043c1615c05bad893f4fde.1617126961.git.danielwa@cisco.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/0c80a08ad4cf788c75043c1615c05bad893f4fde.1617126961.git.danielwa@cisco.com/","date":"2021-03-30T17:56:58","name":"[3/8] powerpc: convert strcpy to strlcpy in prom_init","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"080ba59b05063ce3ee7e20b048c489d09b31ff4e","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/?format=json","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/0c80a08ad4cf788c75043c1615c05bad893f4fde.1617126961.git.danielwa@cisco.com/mbox/","series":[{"id":236583,"url":"http://patchwork.ozlabs.org/api/series/236583/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=236583","date":"2021-03-30T17:56:56","name":"[1/8] CMDLINE: add generic builtin command line","version":1,"mbox":"http://patchwork.ozlabs.org/series/236583/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1460184/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/1460184/checks/","tags":{},"related":[{"id":1461762,"url":"http://patchwork.ozlabs.org/api/patches/1461762/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/03c0b931557967876abcebc7d0e3c6537eb6ab89.1617375802.git.christophe.leroy@csgroup.eu/","msgid":"<03c0b931557967876abcebc7d0e3c6537eb6ab89.1617375802.git.christophe.leroy@csgroup.eu>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/03c0b931557967876abcebc7d0e3c6537eb6ab89.1617375802.git.christophe.leroy@csgroup.eu/","date":"2021-04-02T15:18:07","name":"[v4,06/20] powerpc: convert strcpy to strlcpy in prom_init","mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/03c0b931557967876abcebc7d0e3c6537eb6ab89.1617375802.git.christophe.leroy@csgroup.eu/mbox/"}],"headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=DsMaiuHY;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=DsMaiuHY;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.86.78; helo=rcdn-iport-7.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=DsMaiuHY; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F8xyK3D6cz9sVq\n\tfor ; Wed, 31 Mar 2021 04:58:33 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F8xyK1vNxz3cTP\n\tfor ; Wed, 31 Mar 2021 04:58:33 +1100 (AEDT)","from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F8xwq49qPz3bp5\n for ; Wed, 31 Mar 2021 04:57:14 +1100 (AEDT)","from rcdn-core-2.cisco.com ([173.37.93.153])\n by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 30 Mar 2021 17:57:11 +0000","from zorba.cisco.com ([10.24.8.123])\n by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTP id 12UHv6CG024502;\n Tue, 30 Mar 2021 17:57:09 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=1834; q=dns/txt; s=iport;\n t=1617127035; x=1618336635;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=+iehyumbVkfLozRt/wihMfSdEK+81ZluPnT+4IxME2U=;\n b=DsMaiuHYeXJg8pxjXTqilOXNtaJrqSwJF69xSJR1/6eJFJelbw8wP06i\n wWz5t83puimBr4RaWyA6PzwDYN1E8UK6G+l3bJruM2Y+R1Oe0RFlimhgf\n bTyQWTYkC+9TgNLk6NUuvsNUG7Ru0WqVYDH/m3NJKJ6pQNJuEdZ+K4Ymx M=;","IronPort-HdrOrdr":"\n A9a23:prIAGKp9/k4nNGkSrZAhj+AaV5t2L9V00zAX/kB9WHVpW+aT/vrDoN0w0xjohDENHEw6kdebN6WaBV/a/5h54Y4eVI3SODXOlWO0IOhZg7fK7CbnH0TFnNJ19aAlSKRmDc21MF4St7eY3CCdM/INhOaK67qpg+C29QYJcShPZ7t75wl0TiaXe3cWeCB8CZA0FIWR66N8zlLKRV0tYsu2HXUDVeTYzue79q7OWwIMBBIs9WC14g+A1biSKXWl9yZbey9Tx/MY/XLdlQvi6uGYr+ij0RPHzQbonvNrseqk7tNCAcCW4/J0FhzcziC1eY9mR7qO+Bcyre3H0idSrPD85zE9Is9093TdOluQnCKo8Qzh3DEygkWSr2OlvQ==","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"\n A0ANAAAXZmNg/5ldJa1aGwEBAQEBAQEBBQEBARIBAQEDAwEBAYF8BgEBAQsBgiqBTAE5MYxlpBKBfAsBAQEPNAQBAYRQAoF6AiU0CQ4CAwEBDAEBBQEBAQIBBgRxhW6GRQYyAUYQUVcGARKFeKs0gimJC4FEFIElAYhjdINyJhyBSUKBRYMnijYEgkeBDoJxApB4jT6cIoMRgSObRSKkUi2UWp4tX4QogVQ6gVkzGggbFYMkUBkNjisWjWoBWyEDLzgCBgoBAQMJiR8BAQ","X-IronPort-AV":"E=Sophos;i=\"5.81,291,1610409600\"; d=\"scan'208\";a=\"865117068\"","From":"Daniel Walker ","To":"Will Deacon ,\n Christophe Leroy ,\n ob Herring ,\n Daniel Gimpelevich ,\n Andrew Morton , x86@kernel.org,\n linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH 3/8] powerpc: convert strcpy to strlcpy in prom_init","Date":"Tue, 30 Mar 2021 10:56:58 -0700","Message-Id":"\n <0c80a08ad4cf788c75043c1615c05bad893f4fde.1617126961.git.danielwa@cisco.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"\n <41021d66db2ab427c14255d2a24bb4517c8b58fd.1617126961.git.danielwa@cisco.com>","References":"\n <41021d66db2ab427c14255d2a24bb4517c8b58fd.1617126961.git.danielwa@cisco.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Auto-Response-Suppress":"DR, OOF, AutoReply","X-Outbound-SMTP-Client":"10.24.8.123, [10.24.8.123]","X-Outbound-Node":"rcdn-core-2.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"linux-kernel@vger.kernel.org, Paul Mackerras ,\n xe-linux-external@cisco.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "},"content":"There's only two users of strcpy and one is the command\nline handling. The generic command line handling uses strlcpy\nand it makes sense to convert this one other user to strlcpy to\nkeep prom_init size consistent.\n\nCc: xe-linux-external@cisco.com\nSigned-off-by: Daniel Walker \n---\n arch/powerpc/kernel/prom_init.c | 25 +++++++++++++++----------\n 1 file changed, 15 insertions(+), 10 deletions(-)","diff":"diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c\nindex ccf77b985c8f..2c2f33155317 100644\n--- a/arch/powerpc/kernel/prom_init.c\n+++ b/arch/powerpc/kernel/prom_init.c\n@@ -242,15 +242,6 @@ static int __init prom_strcmp(const char *cs, const char *ct)\n \treturn 0;\n }\n \n-static char __init *prom_strcpy(char *dest, const char *src)\n-{\n-\tchar *tmp = dest;\n-\n-\twhile ((*dest++ = *src++) != '\\0')\n-\t\t/* nothing */;\n-\treturn tmp;\n-}\n-\n static int __init prom_strncmp(const char *cs, const char *ct, size_t count)\n {\n \tunsigned char c1, c2;\n@@ -276,6 +267,20 @@ static size_t __init prom_strlen(const char *s)\n \treturn sc - s;\n }\n \n+static size_t __init prom_strlcpy(char *dest, const char *src, size_t size)\n+{\n+\tsize_t ret = prom_strlen(src);\n+\n+\tif (size) {\n+\t\tsize_t len = (ret >= size) ? size - 1 : ret;\n+\n+\t\tmemcpy(dest, src, len);\n+\t\tdest[len] = '\\0';\n+\t}\n+\treturn ret;\n+}\n+\n+\n static int __init prom_memcmp(const void *cs, const void *ct, size_t count)\n {\n \tconst unsigned char *su1, *su2;\n@@ -2702,7 +2707,7 @@ static void __init flatten_device_tree(void)\n \n \t/* Add \"phandle\" in there, we'll need it */\n \tnamep = make_room(&mem_start, &mem_end, 16, 1);\n-\tprom_strcpy(namep, \"phandle\");\n+\tprom_strlcpy(namep, \"phandle\", 8);\n \tmem_start = (unsigned long)namep + prom_strlen(namep) + 1;\n \n \t/* Build string array */\n","prefixes":["3/8"]}