{"id":1460183,"url":"http://patchwork.ozlabs.org/api/patches/1460183/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/0c4b839f023f87c451c8aa3c4f7a8d92729c2f02.1617126961.git.danielwa@cisco.com/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<0c4b839f023f87c451c8aa3c4f7a8d92729c2f02.1617126961.git.danielwa@cisco.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/0c4b839f023f87c451c8aa3c4f7a8d92729c2f02.1617126961.git.danielwa@cisco.com/","date":"2021-03-30T17:56:57","name":"[2/8] CMDLINE: drivers: of: ifdef out cmdline section","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"a3d4da36db2ef798021e2ad970ea15b752e4c5e5","submitter":{"id":67374,"url":"http://patchwork.ozlabs.org/api/people/67374/?format=json","name":"Daniel Walker (danielwa)","email":"danielwa@cisco.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/0c4b839f023f87c451c8aa3c4f7a8d92729c2f02.1617126961.git.danielwa@cisco.com/mbox/","series":[{"id":236583,"url":"http://patchwork.ozlabs.org/api/series/236583/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=236583","date":"2021-03-30T17:56:56","name":"[1/8] CMDLINE: add generic builtin command line","version":1,"mbox":"http://patchwork.ozlabs.org/series/236583/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1460183/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/1460183/checks/","tags":{},"related":[{"id":1449475,"url":"http://patchwork.ozlabs.org/api/patches/1449475/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210308235319.2988609-3-danielwa@cisco.com/","msgid":"<20210308235319.2988609-3-danielwa@cisco.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20210308235319.2988609-3-danielwa@cisco.com/","date":"2021-03-08T23:53:10","name":"[v2,2/7] CMDLINE: drivers: of: ifdef out cmdline section","mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210308235319.2988609-3-danielwa@cisco.com/mbox/"},{"id":1449483,"url":"http://patchwork.ozlabs.org/api/patches/1449483/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210309000247.2989531-3-danielwa@cisco.com/","msgid":"<20210309000247.2989531-3-danielwa@cisco.com>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20210309000247.2989531-3-danielwa@cisco.com/","date":"2021-03-09T00:02:38","name":"[v2,2/7] CMDLINE: drivers: of: ifdef out cmdline section","mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210309000247.2989531-3-danielwa@cisco.com/mbox/"}],"headers":{"Return-Path":"\n ","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=dcXeqkry;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=dcXeqkry;\n\tdkim-atps=neutral","lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.86.73; helo=rcdn-iport-2.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=)","lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=dcXeqkry; dkim-atps=neutral"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4F8xxs3czzz9sWQ\n\tfor ; Wed, 31 Mar 2021 04:58:09 +1100 (AEDT)","from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4F8xxs2VSVz3bwG\n\tfor ; Wed, 31 Mar 2021 04:58:09 +1100 (AEDT)","from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4F8xwp1Qk1z3bsy\n for ; Wed, 31 Mar 2021 04:57:13 +1100 (AEDT)","from rcdn-core-2.cisco.com ([173.37.93.153])\n by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 30 Mar 2021 17:57:09 +0000","from zorba.cisco.com ([10.24.8.123])\n by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTP id 12UHv6CF024502;\n Tue, 30 Mar 2021 17:57:07 GMT"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=1732; q=dns/txt; s=iport;\n t=1617127034; x=1618336634;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=7VPnrz823hwL8BI8YhldOyGsN9S/SEW13dD2feyjGac=;\n b=dcXeqkry0JRa6H6FPGqA4MZUs/bANepd/1F6WRv3w1b+LG02b9tAzq8r\n 6LfPHjtaSF/vwmJyCvCZ1otHZ7BXadmVWvdT9l2lRzFygCIQgpsh7erGX\n nab5a6sDLn195Zat6uQ15hEMJzQ5hIHy8aYuCTXPZ01qcHISdTMeqy+s7 I=;","IronPort-HdrOrdr":"\n A9a23:2uCtjqNekWosXMBcT5z155DYdL4zR+YMi2QD/UoZc3BoW+afkN2jm+le6AT9jywfVGpltdeLPqSBRn20z+8Q3aA9NaqvNTOJhEKGN4dnhLGJ/xTBHGnE+vdZxeNcdcFFeb7NJHxbqeq/3wWiCdYnx7C8gcWVrMPT1W1kQw0vS6wI1WZEIz2WGEF3WwVKbKBRfPGhz/FKqDa6dXMcYt7TPAhmY8H4u9bJmJj6CCRoOzcb7mC14A+A2frTDwWfmiwTSSpIxq0vtVLYihXj6r+42svLrSP05iv255RSlMCJ8Lt+Lf3JrNQJITPxjQvtQ4JtV9S5zUkIidDqzko2m9/RpBplBeBP0jf6e2G4pgaF4XiH7AoT","X-IronPort-Anti-Spam-Filtered":"true","X-IronPort-Anti-Spam-Result":"\n A0AEAAAYZWNg/5ldJa1aGgEBAQEBAQEBAQEDAQEBARIBAQEBAgIBAQEBgXwFAQEBAQsBgiqBTAE5MYxlpBKBfAsBAQEPNAQBAYRQAoF6AiU0CQ4CAwEBDAEBBQEBAQIBBgRxhW6GRQYyAUYQUVcGARKFeKsvgimJC4FEFIElAYhjdINyJhyBSUKBEjODJ4o2BIJAB4EOgigSnm+cIoMRgSObRSKkUpUHozSBVDqBWTMaCBsVgyRQGQ2cKwFbIQMvOAIGCgEBAwmJHwEB","X-IronPort-AV":"E=Sophos;i=\"5.81,291,1610409600\"; d=\"scan'208\";a=\"881996333\"","From":"Daniel Walker ","To":"Will Deacon ,\n Christophe Leroy ,\n ob Herring ,\n Daniel Gimpelevich ,\n Andrew Morton , x86@kernel.org,\n linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n Rob Herring , Frank Rowand ","Subject":"[PATCH 2/8] CMDLINE: drivers: of: ifdef out cmdline section","Date":"Tue, 30 Mar 2021 10:56:57 -0700","Message-Id":"\n <0c4b839f023f87c451c8aa3c4f7a8d92729c2f02.1617126961.git.danielwa@cisco.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"\n <41021d66db2ab427c14255d2a24bb4517c8b58fd.1617126961.git.danielwa@cisco.com>","References":"\n <41021d66db2ab427c14255d2a24bb4517c8b58fd.1617126961.git.danielwa@cisco.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Auto-Response-Suppress":"DR, OOF, AutoReply","X-Outbound-SMTP-Client":"10.24.8.123, [10.24.8.123]","X-Outbound-Node":"rcdn-core-2.cisco.com","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"devicetree@vger.kernel.org, Ruslan Ruslichenko ,\n linux-kernel@vger.kernel.org, xe-linux-external@cisco.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n "},"content":"It looks like there's some seepage of cmdline stuff into\nthe generic device tree code. This conflicts with the\ngeneric cmdline implementation so I remove it in the case\nwhen that's enabled.\n\nCc: xe-linux-external@cisco.com\nSigned-off-by: Ruslan Ruslichenko \nSigned-off-by: Daniel Walker \n---\n drivers/of/fdt.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)","diff":"diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c\nindex dcc1dd96911a..d8805cd9717a 100644\n--- a/drivers/of/fdt.c\n+++ b/drivers/of/fdt.c\n@@ -25,6 +25,7 @@\n #include \n #include \n #include \n+#include \n \n #include /* for COMMAND_LINE_SIZE */\n #include \n@@ -1050,6 +1051,18 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname,\n \n \t/* Retrieve command line */\n \tp = of_get_flat_dt_prop(node, \"bootargs\", &l);\n+\n+#if defined(CONFIG_GENERIC_CMDLINE) && defined(CONFIG_GENERIC_CMDLINE_OF)\n+\t/*\n+\t * The builtin command line will be added here, or it can override\n+\t * with the DT bootargs.\n+\t */\n+\tcmdline_add_builtin(data,\n+\t\t\t (l > 0 ? p : NULL), /* This is sanity checking */\n+\t\t\t COMMAND_LINE_SIZE);\n+#elif defined(CONFIG_GENERIC_CMDLINE)\n+\tstrlcpy(data, p, COMMAND_LINE_SIZE);\n+#else\n \tif (p != NULL && l > 0)\n \t\tstrlcpy(data, p, min(l, COMMAND_LINE_SIZE));\n \n@@ -1070,6 +1083,7 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname,\n \t\tstrlcpy(data, CONFIG_CMDLINE, COMMAND_LINE_SIZE);\n #endif\n #endif /* CONFIG_CMDLINE */\n+#endif /* CONFIG_GENERIC_CMDLINE */\n \n \tpr_debug(\"Command line is: %s\\n\", (char *)data);\n \n","prefixes":["2/8"]}