{"id":1447381,"url":"http://patchwork.ozlabs.org/api/patches/1447381/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20210304144651.310037-3-alistair.francis@wdc.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20210304144651.310037-3-alistair.francis@wdc.com>","list_archive_url":null,"date":"2021-03-04T14:46:34","name":"[PULL,v2,02/19] hw/misc: sifive_u_otp: Use error_report() when block operation fails","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e1705d546afc96c1a34b4a3820ccc8f0e8460630","submitter":{"id":74007,"url":"http://patchwork.ozlabs.org/api/people/74007/?format=json","name":"Alistair Francis","email":"alistair.francis@wdc.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20210304144651.310037-3-alistair.francis@wdc.com/mbox/","series":[{"id":232161,"url":"http://patchwork.ozlabs.org/api/series/232161/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=232161","date":"2021-03-04T14:46:33","name":"[PULL,v2,01/19] target/riscv: Declare csr_ops[] with a known size","version":2,"mbox":"http://patchwork.ozlabs.org/series/232161/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1447381/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1447381/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256\n header.s=dkim.wdc.com header.b=Xg/+tdHb;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4Drv320qk2z9sSC\n\tfor ; Fri, 5 Mar 2021 01:51:58 +1100 (AEDT)","from localhost ([::1]:38484 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1lHpKW-0004wl-1D\n\tfor incoming@patchwork.ozlabs.org; Thu, 04 Mar 2021 09:51:56 -0500","from eggs.gnu.org ([2001:470:142:3::10]:60102)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1)\n (envelope-from )\n id 1lHpGg-0001Pk-VC\n for qemu-devel@nongnu.org; Thu, 04 Mar 2021 09:47:58 -0500","from esa5.hgst.iphmx.com ([216.71.153.144]:11004)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1)\n (envelope-from )\n id 1lHpGf-0007n8-33\n for qemu-devel@nongnu.org; Thu, 04 Mar 2021 09:47:58 -0500","from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com)\n ([199.255.45.15])\n by ob1.hgst.iphmx.com with ESMTP; 04 Mar 2021 22:47:55 +0800","from uls-op-cesaip01.wdc.com ([10.248.3.36])\n by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Mar 2021 06:29:08 -0800","from cnf008142.ad.shared (HELO alistair-risc6-laptop.hgst.com)\n ([10.86.48.109])\n by uls-op-cesaip01.wdc.com with ESMTP; 04 Mar 2021 06:47:51 -0800"],"DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple;\n d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com;\n t=1614869276; x=1646405276;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=oFQMpB/B62etSPvikdV10XyLOH8e8+5fOknVrGPTZXY=;\n b=Xg/+tdHbq1fIQK+qGFRRbwGTaGTLbINkdKS3rClUVdHFUhgq/WkpDRQk\n o9LLDZl5NI8F7ydv3v6LqNziPUEtKUldHqyakEfAMkHp33J+nnIkg6dyP\n msIcrogvePBLoUlAECKW+5pHxHlJoNsLqpuvcEoNSUJzd3wdHOgEOmcqh\n zdvDYtEAdXxSVwEkaI9N5zHo/o2Y5BlSk6g0jTeijcCCkedbbXNpU/PoU\n D8d7DBcdnkpeFYmqePPccQcdQ4JCvREWOa6J6IdR6k5Rug+EZtvV27gVW\n WGLEftlyDs0bgq2keRr0OBvdguq2ju0lhfm/fJ+qi2qIEemxPFizJDyMH Q==;","IronPort-SDR":["\n dR1PAEpfCuPDEkqSKH0lGo6O08ACVPYTPpEMN2iIzClrrsd/lwe8xYJdo0SWTICEC1ZwIZlrsb\n /Y7SV5FUZg2y5b0hmbPyDgJaNH+KtD50VZT1u2kWK0wENV5fFhYvL9lWgBfLUAS9jl4yHQszA8\n +u7fPX6cC8o1iXPyGd5cD9SbA1En0N2LhPONaoXy/Fahp2RYqEip9Pbo7IdQLrDCGMjTmPa1Uj\n PAiIUe3z8krkflTo7GGhx1n3XBrnpimq1EmcOyP3quXFP6sxvLPRSEo2Wrp5NypDrJ8NPdpwSV\n z2g=","\n APKwx3KDFzoYveKD/R5dS18Q8Ewxj6X9erKeYRTQ5I5VSjngH0wgfY2eVV4WXwu91bZ9zlQyVX\n ICVSAC6//+1IL5g/h3ZdMN/9dlgoH1V3pwxgJxnMwXZ+x80deRwOEJMqGcnEgnbmMIC+CmOFPg\n eHnyqqj8sJszaxJsIxha9ldtF27xCre0Zmze54uClUViEfHVO2+HZr6fZZCRoNCUDsG/cb3yuH\n 9WEigapStQSMmqvhK3jvg5jpN58ntk9uxH8me79A1k1luL7YQd1cS8yn1eiKIsjDKn92i9q1Yb\n XEEEgUSdlPqYiC4xFAgdqTah","\n lU9vmLa3Du2Pt60rjMiPZz5R0G/dk+/OGA7bFSLGohH+sP4A4EcQnIQzsdKZIksyz3lrtRE967\n 4zNf3+jgVjdsEOXu+kjgwieWJCUoLk5x7hSMtbGz45gWNEwNWWrl//ZsjUfLGd49FcdGJpdTix\n oV66g4MbB/0ziM+vU1oPk9LfpmNWppdltk/ClW0LcrtCDk2WvfzCOIVSfQ0i6xa55OvTjaBA26\n 8mTDKva+T/HyqhMJd6wy7gBaGuhsK5YvkhxZt9noW4OXJDmpxXsgloEc1CtSdc3ACpizh2y6Fw\n lKw="],"X-IronPort-AV":"E=Sophos;i=\"5.81,222,1610380800\"; d=\"scan'208\";a=\"161372229\"","WDCIronportException":"Internal","From":"Alistair Francis ","To":"peter.maydell@linaro.org","Subject":"[PULL v2 02/19] hw/misc: sifive_u_otp: Use error_report() when block\n operation fails","Date":"Thu, 4 Mar 2021 09:46:34 -0500","Message-Id":"<20210304144651.310037-3-alistair.francis@wdc.com>","X-Mailer":"git-send-email 2.30.1","In-Reply-To":"<20210304144651.310037-1-alistair.francis@wdc.com>","References":"<20210304144651.310037-1-alistair.francis@wdc.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=216.71.153.144;\n envelope-from=prvs=690dc056c=alistair.francis@wdc.com;\n helo=esa5.hgst.iphmx.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"alistair23@gmail.com, Bin Meng ,\n Alistair Francis , qemu-devel@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "},"content":"From: Bin Meng \n\nAt present when blk_pread() / blk_pwrite() fails, a guest error\nis logged, but this is not really a guest error. Change to use\nerror_report() instead.\n\nSigned-off-by: Bin Meng \nReviewed-by: Philippe Mathieu-Daudé \nReviewed-by: Alistair Francis \nMessage-id: 1611026585-29971-1-git-send-email-bmeng.cn@gmail.com\nSigned-off-by: Alistair Francis \n---\n hw/misc/sifive_u_otp.c | 13 +++++--------\n 1 file changed, 5 insertions(+), 8 deletions(-)","diff":"diff --git a/hw/misc/sifive_u_otp.c b/hw/misc/sifive_u_otp.c\nindex b8e8b9eebe..18aa0bd55d 100644\n--- a/hw/misc/sifive_u_otp.c\n+++ b/hw/misc/sifive_u_otp.c\n@@ -23,6 +23,7 @@\n #include \"hw/qdev-properties.h\"\n #include \"hw/qdev-properties-system.h\"\n #include \"hw/sysbus.h\"\n+#include \"qemu/error-report.h\"\n #include \"qemu/log.h\"\n #include \"qemu/module.h\"\n #include \"hw/misc/sifive_u_otp.h\"\n@@ -65,8 +66,7 @@ static uint64_t sifive_u_otp_read(void *opaque, hwaddr addr, unsigned int size)\n \n if (blk_pread(s->blk, s->pa * SIFIVE_U_OTP_FUSE_WORD, &buf,\n SIFIVE_U_OTP_FUSE_WORD) < 0) {\n- qemu_log_mask(LOG_GUEST_ERROR,\n- \"read error index<%d>\\n\", s->pa);\n+ error_report(\"read error index<%d>\", s->pa);\n return 0xff;\n }\n \n@@ -169,8 +169,7 @@ static void sifive_u_otp_write(void *opaque, hwaddr addr,\n if (blk_pwrite(s->blk, s->pa * SIFIVE_U_OTP_FUSE_WORD,\n &s->fuse[s->pa], SIFIVE_U_OTP_FUSE_WORD,\n 0) < 0) {\n- qemu_log_mask(LOG_GUEST_ERROR,\n- \"write error index<%d>\\n\", s->pa);\n+ error_report(\"write error index<%d>\", s->pa);\n }\n }\n \n@@ -260,15 +259,13 @@ static void sifive_u_otp_reset(DeviceState *dev)\n serial_data = s->serial;\n if (blk_pwrite(s->blk, index * SIFIVE_U_OTP_FUSE_WORD,\n &serial_data, SIFIVE_U_OTP_FUSE_WORD, 0) < 0) {\n- qemu_log_mask(LOG_GUEST_ERROR,\n- \"write error index<%d>\\n\", index);\n+ error_report(\"write error index<%d>\", index);\n }\n \n serial_data = ~(s->serial);\n if (blk_pwrite(s->blk, (index + 1) * SIFIVE_U_OTP_FUSE_WORD,\n &serial_data, SIFIVE_U_OTP_FUSE_WORD, 0) < 0) {\n- qemu_log_mask(LOG_GUEST_ERROR,\n- \"write error index<%d>\\n\", index + 1);\n+ error_report(\"write error index<%d>\", index + 1);\n }\n }\n \n","prefixes":["PULL","v2","02/19"]}