{"id":1375812,"url":"http://patchwork.ozlabs.org/api/patches/1375812/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/c7a48fba3a80ac9362c27272cd869cc251539290.1601648734.git.lorenzo@kernel.org/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<c7a48fba3a80ac9362c27272cd869cc251539290.1601648734.git.lorenzo@kernel.org>","list_archive_url":null,"date":"2020-10-02T14:42:09","name":"[v4,bpf-next,11/13] bpf: add xdp multi-buffer selftest","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"9d641c62da2c68a49770bdbab0199cf5bb8bb5b4","submitter":{"id":76007,"url":"http://patchwork.ozlabs.org/api/people/76007/?format=json","name":"Lorenzo Bianconi","email":"lorenzo@kernel.org"},"delegate":{"id":77147,"url":"http://patchwork.ozlabs.org/api/users/77147/?format=json","username":"bpf","first_name":"BPF","last_name":"Maintainers","email":"bpf@iogearbox.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/c7a48fba3a80ac9362c27272cd869cc251539290.1601648734.git.lorenzo@kernel.org/mbox/","series":[{"id":205635,"url":"http://patchwork.ozlabs.org/api/series/205635/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=205635","date":"2020-10-02T14:41:58","name":"mvneta: introduce XDP multi-buffer support","version":4,"mbox":"http://patchwork.ozlabs.org/series/205635/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1375812/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1375812/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming-netdev@ozlabs.org","Delivered-To":"patchwork-incoming-netdev@ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=kernel.org","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=default header.b=OIds9OuU;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 4C2t5Z2K50z9sSC\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n Sat,  3 Oct 2020 00:43:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n        id S2388237AbgJBOnN (ORCPT\n        <rfc822;patchwork-incoming-netdev@ozlabs.org>);\n        Fri, 2 Oct 2020 10:43:13 -0400","from mail.kernel.org ([198.145.29.99]:32850 \"EHLO mail.kernel.org\"\n        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n        id S1726017AbgJBOnL (ORCPT <rfc822;netdev@vger.kernel.org>);\n        Fri, 2 Oct 2020 10:43:11 -0400","from lore-desk.redhat.com (unknown [176.207.245.61])\n        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n        (No client certificate requested)\n        by mail.kernel.org (Postfix) with ESMTPSA id 6E6A020708;\n        Fri,  2 Oct 2020 14:43:08 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n        s=default; t=1601649790;\n        bh=KqdOIEBWHwpdkF+8jfdovWiCtyDc6YI5ZYHE4ztCj5Y=;\n        h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n        b=OIds9OuUrNBgUDU3FEVZXGANfCKgS+sV8u4HNGhg7wykOtvZXjS2LjV4SCKYI0W0H\n         hMj4nS08yznLWsajDy98UlJurHftfa32x8J+RjAuRohG0L9A11cn9JkPaXZZozz3Vj\n         CeeyQfGfg6C5fJz1KsT21oJvvc5x8LbnEgY6XXL4=","From":"Lorenzo Bianconi <lorenzo@kernel.org>","To":"bpf@vger.kernel.org, netdev@vger.kernel.org","Cc":"davem@davemloft.net, kuba@kernel.org, ast@kernel.org,\n        daniel@iogearbox.net, shayagr@amazon.com, sameehj@amazon.com,\n        john.fastabend@gmail.com, dsahern@kernel.org, brouer@redhat.com,\n        lorenzo.bianconi@redhat.com, echaudro@redhat.com","Subject":"[PATCH v4 bpf-next 11/13] bpf: add xdp multi-buffer selftest","Date":"Fri,  2 Oct 2020 16:42:09 +0200","Message-Id":"\n <c7a48fba3a80ac9362c27272cd869cc251539290.1601648734.git.lorenzo@kernel.org>","X-Mailer":"git-send-email 2.26.2","In-Reply-To":"<cover.1601648734.git.lorenzo@kernel.org>","References":"<cover.1601648734.git.lorenzo@kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Introduce xdp multi-buffer selftest for the following ebpf helpers:\n- bpf_xdp_get_frags_total_size\n- bpf_xdp_get_frags_count\n\nCo-developed-by: Eelco Chaudron <echaudro@redhat.com>\nSigned-off-by: Eelco Chaudron <echaudro@redhat.com>\nSigned-off-by: Lorenzo Bianconi <lorenzo@kernel.org>\n---\n .../testing/selftests/bpf/prog_tests/xdp_mb.c | 79 +++++++++++++++++++\n .../selftests/bpf/progs/test_xdp_multi_buff.c | 24 ++++++\n 2 files changed, 103 insertions(+)\n create mode 100644 tools/testing/selftests/bpf/prog_tests/xdp_mb.c\n create mode 100644 tools/testing/selftests/bpf/progs/test_xdp_multi_buff.c","diff":"diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_mb.c b/tools/testing/selftests/bpf/prog_tests/xdp_mb.c\nnew file mode 100644\nindex 000000000000..4b1aca2d31e5\n--- /dev/null\n+++ b/tools/testing/selftests/bpf/prog_tests/xdp_mb.c\n@@ -0,0 +1,79 @@\n+// SPDX-License-Identifier: GPL-2.0\n+\n+#include <unistd.h>\n+#include <linux/kernel.h>\n+#include <test_progs.h>\n+#include <network_helpers.h>\n+\n+#include \"test_xdp_multi_buff.skel.h\"\n+\n+static void test_xdp_mb_check_len(void)\n+{\n+\tint test_sizes[] = { 128, 4096, 9000 };\n+\tstruct test_xdp_multi_buff *pkt_skel;\n+\t__u8 *pkt_in = NULL, *pkt_out = NULL;\n+\t__u32 duration = 0, retval, size;\n+\tint err, pkt_fd, i;\n+\n+\t/* Load XDP program */\n+\tpkt_skel = test_xdp_multi_buff__open_and_load();\n+\tif (CHECK(!pkt_skel, \"pkt_skel_load\", \"test_xdp_mb skeleton failed\\n\"))\n+\t\tgoto out;\n+\n+\t/* Allocate resources */\n+\tpkt_out = malloc(test_sizes[ARRAY_SIZE(test_sizes) - 1]);\n+\tif (CHECK(!pkt_out, \"malloc\", \"Failed pkt_out malloc\\n\"))\n+\t\tgoto out;\n+\n+\tpkt_in = malloc(test_sizes[ARRAY_SIZE(test_sizes) - 1]);\n+\tif (CHECK(!pkt_in, \"malloc\", \"Failed pkt_in malloc\\n\"))\n+\t\tgoto out;\n+\n+\tpkt_fd = bpf_program__fd(pkt_skel->progs._xdp_check_mb_len);\n+\tif (pkt_fd < 0)\n+\t\tgoto out;\n+\n+\t/* Run test for specific set of packets */\n+\tfor (i = 0; i < ARRAY_SIZE(test_sizes); i++) {\n+\t\tint frags_count;\n+\n+\t\t/* Run test program */\n+\t\terr = bpf_prog_test_run(pkt_fd, 1, pkt_in, test_sizes[i],\n+\t\t\t\t\tpkt_out, &size, &retval, &duration);\n+\n+\t\tif (CHECK(err || retval != XDP_PASS || size != test_sizes[i],\n+\t\t\t  \"test_run\", \"err %d errno %d retval %d size %d[%d]\\n\",\n+\t\t\t  err, errno, retval, size, test_sizes[i]))\n+\t\t\tgoto out;\n+\n+\t\t/* Verify test results */\n+\t\tfrags_count = DIV_ROUND_UP(\n+\t\t\ttest_sizes[i] - pkt_skel->data->test_result_xdp_len,\n+\t\t\tgetpagesize());\n+\n+\t\tif (CHECK(pkt_skel->data->test_result_frags_count != frags_count,\n+\t\t\t  \"result\", \"frags_count = %llu != %u\\n\",\n+\t\t\t  pkt_skel->data->test_result_frags_count, frags_count))\n+\t\t\tgoto out;\n+\n+\t\tif (CHECK(pkt_skel->data->test_result_frags_len != test_sizes[i] -\n+\t\t\t  pkt_skel->data->test_result_xdp_len,\n+\t\t\t  \"result\", \"frags_len = %llu != %llu\\n\",\n+\t\t\t  pkt_skel->data->test_result_frags_len,\n+\t\t\t  test_sizes[i] - pkt_skel->data->test_result_xdp_len))\n+\t\t\tgoto out;\n+\t}\n+out:\n+\tif (pkt_out)\n+\t\tfree(pkt_out);\n+\tif (pkt_in)\n+\t\tfree(pkt_in);\n+\n+\ttest_xdp_multi_buff__destroy(pkt_skel);\n+}\n+\n+void test_xdp_mb(void)\n+{\n+\tif (test__start_subtest(\"xdp_mb_check_len_frags\"))\n+\t\ttest_xdp_mb_check_len();\n+}\ndiff --git a/tools/testing/selftests/bpf/progs/test_xdp_multi_buff.c b/tools/testing/selftests/bpf/progs/test_xdp_multi_buff.c\nnew file mode 100644\nindex 000000000000..b7527829a3ed\n--- /dev/null\n+++ b/tools/testing/selftests/bpf/progs/test_xdp_multi_buff.c\n@@ -0,0 +1,24 @@\n+// SPDX-License-Identifier: GPL-2.0\n+\n+#include <linux/bpf.h>\n+#include <linux/if_ether.h>\n+#include <bpf/bpf_helpers.h>\n+#include <stdint.h>\n+\n+__u64 test_result_frags_count = UINT64_MAX;\n+__u64 test_result_frags_len = UINT64_MAX;\n+__u64 test_result_xdp_len = UINT64_MAX;\n+\n+SEC(\"xdp_check_mb_len\")\n+int _xdp_check_mb_len(struct xdp_md *xdp)\n+{\n+\tvoid *data_end = (void *)(long)xdp->data_end;\n+\tvoid *data = (void *)(long)xdp->data;\n+\n+\ttest_result_xdp_len = (__u64)(data_end - data);\n+\ttest_result_frags_len = bpf_xdp_get_frags_total_size(xdp);\n+\ttest_result_frags_count = bpf_xdp_get_frags_count(xdp);\n+\treturn XDP_PASS;\n+}\n+\n+char _license[] SEC(\"license\") = \"GPL\";\n","prefixes":["v4","bpf-next","11/13"]}