{"id":1375809,"url":"http://patchwork.ozlabs.org/api/patches/1375809/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/4f633a8510040b7bc9b7fc680a33b86654396e51.1601648734.git.lorenzo@kernel.org/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<4f633a8510040b7bc9b7fc680a33b86654396e51.1601648734.git.lorenzo@kernel.org>","list_archive_url":null,"date":"2020-10-02T14:42:06","name":"[v4,bpf-next,08/13] bpf: move user_size out of bpf_test_init","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"4184d03cc0b477f8be2cf0832acae3b283cc0529","submitter":{"id":76007,"url":"http://patchwork.ozlabs.org/api/people/76007/?format=json","name":"Lorenzo Bianconi","email":"lorenzo@kernel.org"},"delegate":{"id":77147,"url":"http://patchwork.ozlabs.org/api/users/77147/?format=json","username":"bpf","first_name":"BPF","last_name":"Maintainers","email":"bpf@iogearbox.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/4f633a8510040b7bc9b7fc680a33b86654396e51.1601648734.git.lorenzo@kernel.org/mbox/","series":[{"id":205635,"url":"http://patchwork.ozlabs.org/api/series/205635/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=205635","date":"2020-10-02T14:41:58","name":"mvneta: introduce XDP multi-buffer support","version":4,"mbox":"http://patchwork.ozlabs.org/series/205635/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1375809/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1375809/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming-netdev@ozlabs.org","Delivered-To":"patchwork-incoming-netdev@ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=netdev-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=kernel.org","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=default header.b=fIo4UkQH;\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 4C2t5L0zymz9sSC\n\tfor ;\n Sat, 3 Oct 2020 00:43:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S2388224AbgJBOnB (ORCPT\n );\n Fri, 2 Oct 2020 10:43:01 -0400","from mail.kernel.org ([198.145.29.99]:60970 \"EHLO mail.kernel.org\"\n rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n id S1726017AbgJBOnA (ORCPT );\n Fri, 2 Oct 2020 10:43:00 -0400","from lore-desk.redhat.com (unknown [176.207.245.61])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mail.kernel.org (Postfix) with ESMTPSA id 1A92A207DE;\n Fri, 2 Oct 2020 14:42:57 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=default; t=1601649780;\n bh=dB1yq4ULn7DJ3/BsHkzrZDjsyKFHyuueOGwuTCFAzbM=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=fIo4UkQHYEYVzKGSbQnmudflyrfXBDH6cpRDxP6IN4AQCiHmdomA3peLotqpqicD7\n X0YSEXZeeM2gVNFKY/BllxOduYuYlEVufy/p7OQIbV7ie6/X3b6KaYVFcPy5NMQ0Iq\n dGx9xTWKSw54/AFaAi9oGlEMw6dIrGUfJVtfJ1fI=","From":"Lorenzo Bianconi ","To":"bpf@vger.kernel.org, netdev@vger.kernel.org","Cc":"davem@davemloft.net, kuba@kernel.org, ast@kernel.org,\n daniel@iogearbox.net, shayagr@amazon.com, sameehj@amazon.com,\n john.fastabend@gmail.com, dsahern@kernel.org, brouer@redhat.com,\n lorenzo.bianconi@redhat.com, echaudro@redhat.com","Subject":"[PATCH v4 bpf-next 08/13] bpf: move user_size out of bpf_test_init","Date":"Fri, 2 Oct 2020 16:42:06 +0200","Message-Id":"\n <4f633a8510040b7bc9b7fc680a33b86654396e51.1601648734.git.lorenzo@kernel.org>","X-Mailer":"git-send-email 2.26.2","In-Reply-To":"","References":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Rely on data_size_in in bpf_test_init routine signature. This is a\npreliminary patch to introduce xdp multi-buff selftest\n\nSigned-off-by: Lorenzo Bianconi \n---\n net/bpf/test_run.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c\nindex c1c30a9f76f3..bd291f5f539c 100644\n--- a/net/bpf/test_run.c\n+++ b/net/bpf/test_run.c\n@@ -171,11 +171,10 @@ __diag_pop();\n \n ALLOW_ERROR_INJECTION(bpf_modify_return_test, ERRNO);\n \n-static void *bpf_test_init(const union bpf_attr *kattr, u32 size,\n-\t\t\t u32 headroom, u32 tailroom)\n+static void *bpf_test_init(const union bpf_attr *kattr, u32 user_size,\n+\t\t\t u32 size, u32 headroom, u32 tailroom)\n {\n \tvoid __user *data_in = u64_to_user_ptr(kattr->test.data_in);\n-\tu32 user_size = kattr->test.data_size_in;\n \tvoid *data;\n \n \tif (size < ETH_HLEN || size > PAGE_SIZE - headroom - tailroom)\n@@ -495,7 +494,8 @@ int bpf_prog_test_run_skb(struct bpf_prog *prog, const union bpf_attr *kattr,\n \tif (kattr->test.flags || kattr->test.cpu)\n \t\treturn -EINVAL;\n \n-\tdata = bpf_test_init(kattr, size, NET_SKB_PAD + NET_IP_ALIGN,\n+\tdata = bpf_test_init(kattr, kattr->test.data_size_in,\n+\t\t\t size, NET_SKB_PAD + NET_IP_ALIGN,\n \t\t\t SKB_DATA_ALIGN(sizeof(struct skb_shared_info)));\n \tif (IS_ERR(data))\n \t\treturn PTR_ERR(data);\n@@ -632,7 +632,8 @@ int bpf_prog_test_run_xdp(struct bpf_prog *prog, const union bpf_attr *kattr,\n \t/* XDP have extra tailroom as (most) drivers use full page */\n \tmax_data_sz = 4096 - headroom - tailroom;\n \n-\tdata = bpf_test_init(kattr, max_data_sz, headroom, tailroom);\n+\tdata = bpf_test_init(kattr, kattr->test.data_size_in,\n+\t\t\t max_data_sz, headroom, tailroom);\n \tif (IS_ERR(data))\n \t\treturn PTR_ERR(data);\n \n@@ -698,7 +699,7 @@ int bpf_prog_test_run_flow_dissector(struct bpf_prog *prog,\n \tif (size < ETH_HLEN)\n \t\treturn -EINVAL;\n \n-\tdata = bpf_test_init(kattr, size, 0, 0);\n+\tdata = bpf_test_init(kattr, kattr->test.data_size_in, size, 0, 0);\n \tif (IS_ERR(data))\n \t\treturn PTR_ERR(data);\n \n","prefixes":["v4","bpf-next","08/13"]}