{"id":135449,"url":"http://patchwork.ozlabs.org/api/patches/135449/","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20120111180504.25198.76946.stgit@ginnungagap.bsc.es/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20120111180504.25198.76946.stgit@ginnungagap.bsc.es>","list_archive_url":null,"date":"2012-01-11T18:05:04","name":"[1/6] trace: [tracetool] Do not rebuild event list in backend code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ff8c2351af5fae0d222b8b3b11fd4382594c4dc7","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20120111180504.25198.76946.stgit@ginnungagap.bsc.es/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/135449/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/135449/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from lists.gnu.org (lists.gnu.org [140.186.70.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 98091B6EFF\n\tfor ;\n\tThu, 12 Jan 2012 05:07:20 +1100 (EST)","from localhost ([::1]:47022 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1Rl2Zy-0001EQ-D9\n\tfor incoming@patchwork.ozlabs.org; Wed, 11 Jan 2012 13:07:18 -0500","from eggs.gnu.org ([140.186.70.92]:57176)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1Rl2Zk-00016l-Qx\n\tfor qemu-devel@nongnu.org; Wed, 11 Jan 2012 13:07:13 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1Rl2Zf-0006EU-TU\n\tfor qemu-devel@nongnu.org; Wed, 11 Jan 2012 13:07:04 -0500","from gw.ac.upc.edu ([147.83.30.3]:54559)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1Rl2Zf-0006EQ-K9\n\tfor qemu-devel@nongnu.org; Wed, 11 Jan 2012 13:06:59 -0500","from localhost (unknown [84.88.53.92])\n\tby gw.ac.upc.edu (Postfix) with ESMTP id E59276B0249;\n\tWed, 11 Jan 2012 19:06:57 +0100 (CET)"],"To":"qemu-devel@nongnu.org","From":"=?utf-8?b?TGx1w61z?= Vilanova ","Date":"Wed, 11 Jan 2012 19:05:04 +0100","Message-ID":"<20120111180504.25198.76946.stgit@ginnungagap.bsc.es>","User-Agent":"StGit/0.15","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)","X-Received-From":"147.83.30.3","Cc":"harsh@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com,\n\taneesh.kumar@linux.vnet.ibm.com","Subject":"[Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild event\n\tlist in backend code","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.14","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Signed-off-by: Lluís Vilanova \n---\n scripts/tracetool.py | 14 +++++++-------\n 1 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/scripts/tracetool.py b/scripts/tracetool.py\nindex 6874f66..80e5684 100755\n--- a/scripts/tracetool.py\n+++ b/scripts/tracetool.py\n@@ -171,15 +171,14 @@ def simple_c(events):\n print\n print 'TraceEvent trace_list[] = {'\n print\n- eventlist = list(events)\n- for event in eventlist:\n+ for event in events:\n print '{.tp_name = \"%(name)s\", .state=0},' % {\n 'name': event.name\n }\n print\n print '};'\n print\n- for event in eventlist:\n+ for event in events:\n argc = event.argc\n print '''void trace_%(name)s(%(args)s)\n {\n@@ -311,8 +310,7 @@ def ust_c(events):\n #undef inline\n #undef wmb\n #include \"trace.h\"'''\n- eventlist = list(events)\n- for event in eventlist:\n+ for event in events:\n argnames = event.argnames\n if event.argc > 0:\n argnames = ', ' + event.argnames\n@@ -344,7 +342,7 @@ static void ust_%(name)s_probe(%(args)s)\n print '''\n static void __attribute__((constructor)) trace_init(void)\n {'''\n- for event in eventlist:\n+ for event in events:\n print ' register_trace_ust_%(name)s(ust_%(name)s_probe);' % {\n 'name': event.name\n }\n@@ -510,14 +508,16 @@ class Event(object):\n \n # Generator that yields Event objects given a trace-events file object\n def read_events(fobj):\n+ res = []\n event_num = 0\n for line in fobj:\n if not line.strip():\n continue\n if line.lstrip().startswith('#'):\n \t continue\n-\tyield Event(event_num, line)\n+\tres.append(Event(event_num, line))\n \tevent_num += 1\n+ return res\n \n backend = \"\"\n output = \"\"\n","prefixes":["1/6"]}