{"id":1307031,"url":"http://patchwork.ozlabs.org/api/patches/1307031/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/bd18df5282c3e4b4290d38f028ac649b5bdaae7e.1591801197.git.berto@igalia.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2020-06-10T15:03:02","name":"[v8,24/34] qcow2: Add subcluster support to check_refcounts_l2()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bd7995b4ae3ab42728ed7d362da8647d816c5da7","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/?format=json","name":"Alberto Garcia","email":"berto@igalia.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/bd18df5282c3e4b4290d38f028ac649b5bdaae7e.1591801197.git.berto@igalia.com/mbox/","series":[{"id":182563,"url":"http://patchwork.ozlabs.org/api/series/182563/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=182563","date":"2020-06-10T15:02:49","name":"Add subcluster allocation to qcow2","version":8,"mbox":"http://patchwork.ozlabs.org/series/182563/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1307031/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1307031/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=none (p=none dis=none) header.from=igalia.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=igalia.com header.i=@igalia.com header.a=rsa-sha256\n header.s=20170329 header.b=Y6dzKxN5;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49hrR51fsMz9sRh\n\tfor ; Thu, 11 Jun 2020 01:25:37 +1000 (AEST)","from localhost ([::1]:58762 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1jj2be-0007l4-T7\n\tfor incoming@patchwork.ozlabs.org; Wed, 10 Jun 2020 11:25:34 -0400","from eggs.gnu.org ([2001:470:142:3::10]:36190)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1jj2H4-0002pE-NX; Wed, 10 Jun 2020 11:04:19 -0400","from fanzine.igalia.com ([178.60.130.6]:58279)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1jj2Gs-0006wr-Oa; Wed, 10 Jun 2020 11:04:16 -0400","from [81.0.38.199] (helo=perseus.local)\n by fanzine.igalia.com with esmtpsa\n (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim)\n id 1jj2GR-0007hA-OO; Wed, 10 Jun 2020 17:03:39 +0200","from berto by perseus.local with local (Exim 4.92)\n (envelope-from )\n id 1jj2GC-0007NW-Ce; Wed, 10 Jun 2020 17:03:24 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n s=20170329;\n h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;\n bh=rYtb2FYfGO+eQGiZ0oQYJSWRUo7OpthnEHRNgAuR++M=;\n b=Y6dzKxN59T24mSf5AOCApQQw/jWrRhJJhMcGdeoxIUaAoUtttc23v5J3FzWVD9PejyOryH+gcq+Tab4N0/mXd50OoAAXjkp8/Vnrta4822KIpdwUr+l9V5lg/fGAwD3pKR8/YsmntCqnnU5+cXLVjQL77OOgKjcRdlqsrofKgk/PDH71Tkjo/RW5F/eD1h0LeNpksw3XG9r+sQvyOTiNR/+aer48UodZlw49lCF+DkqYJQ04+2QbIy+u04roccN5hEPeCjnZoLBy9SSgkBIfKUVBMio1V6dajj2oHjBJ0aSNEZJt3Di1uJfeDQd+QU/8mOp1ecUafIt7YiGXCBkGCQ==;","From":"Alberto Garcia ","To":"qemu-devel@nongnu.org","Subject":"[PATCH v8 24/34] qcow2: Add subcluster support to\n check_refcounts_l2()","Date":"Wed, 10 Jun 2020 17:03:02 +0200","Message-Id":"\n ","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"","References":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.60.130.6; envelope-from=berto@igalia.com;\n helo=fanzine.igalia.com","X-detected-operating-system":"by eggs.gnu.org: First seen = 2020/06/10 11:03:39","X-ACL-Warn":"Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy]","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=_AUTOLEARN","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n Vladimir Sementsov-Ogievskiy ,\n Alberto Garcia , qemu-block@nongnu.org,\n Derek Su , Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "},"content":"Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an\nimage has subclusters. Instead, the individual 'all zeroes' bits must\nbe used.\n\nSigned-off-by: Alberto Garcia \nReviewed-by: Max Reitz \nReviewed-by: Vladimir Sementsov-Ogievskiy \nReviewed-by: Eric Blake \n---\n block/qcow2-refcount.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c\nindex 770c5dbc83..696e4dad07 100644\n--- a/block/qcow2-refcount.c\n+++ b/block/qcow2-refcount.c\n@@ -1686,8 +1686,13 @@ static int check_refcounts_l2(BlockDriverState *bs, BdrvCheckResult *res,\n int ign = active ? QCOW2_OL_ACTIVE_L2 :\n QCOW2_OL_INACTIVE_L2;\n \n- l2_entry = QCOW_OFLAG_ZERO;\n- set_l2_entry(s, l2_table, i, l2_entry);\n+ if (has_subclusters(s)) {\n+ set_l2_entry(s, l2_table, i, 0);\n+ set_l2_bitmap(s, l2_table, i,\n+ QCOW_L2_BITMAP_ALL_ZEROES);\n+ } else {\n+ set_l2_entry(s, l2_table, i, QCOW_OFLAG_ZERO);\n+ }\n ret = qcow2_pre_write_overlap_check(bs, ign,\n l2e_offset, l2_entry_size(s), false);\n if (ret < 0) {\n","prefixes":["v8","24/34"]}