{"id":1307023,"url":"http://patchwork.ozlabs.org/api/patches/1307023/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/17dc6f6519e90b2351565dc2f807f8cddc2aaa90.1591801197.git.berto@igalia.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<17dc6f6519e90b2351565dc2f807f8cddc2aaa90.1591801197.git.berto@igalia.com>","list_archive_url":null,"date":"2020-06-10T15:02:47","name":"[v8,09/34] qcow2: Add subcluster-related fields to BDRVQcow2State","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bd9048bdd05f5db82e076f2bc67d60cdd4a25d27","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/people/65704/?format=json","name":"Alberto Garcia","email":"berto@igalia.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/17dc6f6519e90b2351565dc2f807f8cddc2aaa90.1591801197.git.berto@igalia.com/mbox/","series":[{"id":182563,"url":"http://patchwork.ozlabs.org/api/series/182563/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=182563","date":"2020-06-10T15:02:49","name":"Add subcluster allocation to qcow2","version":8,"mbox":"http://patchwork.ozlabs.org/series/182563/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1307023/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1307023/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=)","ozlabs.org;\n dmarc=none (p=none dis=none) header.from=igalia.com","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=igalia.com header.i=@igalia.com header.a=rsa-sha256\n header.s=20170329 header.b=HHEFoiDu;\n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 49hrJR5pmjz9sRW\n\tfor ; Thu, 11 Jun 2020 01:19:51 +1000 (AEST)","from localhost ([::1]:41120 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1jj2W5-0007lC-GL\n\tfor incoming@patchwork.ozlabs.org; Wed, 10 Jun 2020 11:19:49 -0400","from eggs.gnu.org ([2001:470:142:3::10]:36146)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1jj2Gw-0002hk-Br; Wed, 10 Jun 2020 11:04:10 -0400","from fanzine.igalia.com ([178.60.130.6]:58032)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1jj2Gr-0006vu-6X; Wed, 10 Jun 2020 11:04:09 -0400","from [81.0.38.199] (helo=perseus.local)\n by fanzine.igalia.com with esmtpsa\n (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim)\n id 1jj2GR-0007gn-3j; Wed, 10 Jun 2020 17:03:39 +0200","from berto by perseus.local with local (Exim 4.92)\n (envelope-from )\n id 1jj2GB-0007Mm-Tv; Wed, 10 Jun 2020 17:03:23 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n s=20170329;\n h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;\n bh=zbMhjtGKVeY7EryanAE+iwZTdNLcuFqDn9UZxBryOf4=;\n b=HHEFoiDueQ/iHJeSFStNw/FYSRQtYb8ED3nAvjXleSyW/2JK3B3Scyh1FRXwhC7yBVnuLdV+rzMWvLivTbwbCe0pc9AcRBMimUxW2hIH0zuQC2T1QSANhi6caDQf8uiY9szzMlET/ErWXxv0RH1EgFC3gXjb+ocV2OqbBQD8zIfFoeLbZNOoOSrr3zPpB8G3uIWUYzfWMpsVm83BI/TTtQz/ddpbpKhxtks9fbeCKxWrkVp+tVeMYdZ97B8qiJoGKM+foygzsUQDlUGQQn/3i9jnx04TP3lQQmHFM16B8NEQtDeUdWa2G+UUX/Q6gXvVUHV5c6F8kUm3kukEwQl+wA==;","From":"Alberto Garcia ","To":"qemu-devel@nongnu.org","Subject":"[PATCH v8 09/34] qcow2: Add subcluster-related fields to\n BDRVQcow2State","Date":"Wed, 10 Jun 2020 17:02:47 +0200","Message-Id":"\n <17dc6f6519e90b2351565dc2f807f8cddc2aaa90.1591801197.git.berto@igalia.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"","References":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.60.130.6; envelope-from=berto@igalia.com;\n helo=fanzine.igalia.com","X-detected-operating-system":"by eggs.gnu.org: First seen = 2020/06/10 11:03:39","X-ACL-Warn":"Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy]","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=_AUTOLEARN","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Kevin Wolf ,\n Vladimir Sementsov-Ogievskiy ,\n Alberto Garcia , qemu-block@nongnu.org,\n Derek Su , Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n "},"content":"This patch adds the following new fields to BDRVQcow2State:\n\n- subclusters_per_cluster: Number of subclusters in a cluster\n- subcluster_size: The size of each subcluster, in bytes\n- subcluster_bits: No. of bits so 1 << subcluster_bits = subcluster_size\n\nImages without subclusters are treated as if they had exactly one\nsubcluster per cluster (i.e. subcluster_size = cluster_size).\n\nSigned-off-by: Alberto Garcia \nReviewed-by: Max Reitz \nReviewed-by: Vladimir Sementsov-Ogievskiy \n---\n block/qcow2.h | 5 +++++\n block/qcow2.c | 5 +++++\n 2 files changed, 10 insertions(+)","diff":"diff --git a/block/qcow2.h b/block/qcow2.h\nindex 2064dd3d85..eee4c8de9c 100644\n--- a/block/qcow2.h\n+++ b/block/qcow2.h\n@@ -78,6 +78,8 @@\n /* The cluster reads as all zeros */\n #define QCOW_OFLAG_ZERO (1ULL << 0)\n \n+#define QCOW_EXTL2_SUBCLUSTERS_PER_CLUSTER 32\n+\n #define MIN_CLUSTER_BITS 9\n #define MAX_CLUSTER_BITS 21\n \n@@ -295,6 +297,9 @@ typedef struct BDRVQcow2State {\n int cluster_bits;\n int cluster_size;\n int l2_slice_size;\n+ int subcluster_bits;\n+ int subcluster_size;\n+ int subclusters_per_cluster;\n int l2_bits;\n int l2_size;\n int l1_size;\ndiff --git a/block/qcow2.c b/block/qcow2.c\nindex afb00ada42..5c175a314c 100644\n--- a/block/qcow2.c\n+++ b/block/qcow2.c\n@@ -1433,6 +1433,11 @@ static int coroutine_fn qcow2_do_open(BlockDriverState *bs, QDict *options,\n }\n }\n \n+ s->subclusters_per_cluster =\n+ has_subclusters(s) ? QCOW_EXTL2_SUBCLUSTERS_PER_CLUSTER : 1;\n+ s->subcluster_size = s->cluster_size / s->subclusters_per_cluster;\n+ s->subcluster_bits = ctz32(s->subcluster_size);\n+\n /* Check support for various header values */\n if (header.refcount_order > 6) {\n error_setg(errp, \"Reference count entry width too large; may not \"\n","prefixes":["v8","09/34"]}