{"id":1296571,"url":"http://patchwork.ozlabs.org/api/patches/1296571/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20200523004049.34832-6-saeedm@mellanox.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20200523004049.34832-6-saeedm@mellanox.com>","list_archive_url":null,"date":"2020-05-23T00:40:41","name":"[net,05/13] net/mlx5e: kTLS, Destroy key object after destroying the TIS","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"70526e267f676f514099033077e0d1867225769b","submitter":{"id":65299,"url":"http://patchwork.ozlabs.org/api/people/65299/?format=json","name":"Saeed Mahameed","email":"saeedm@mellanox.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20200523004049.34832-6-saeedm@mellanox.com/mbox/","series":[{"id":178808,"url":"http://patchwork.ozlabs.org/api/series/178808/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=178808","date":"2020-05-23T00:40:36","name":"[net,01/13] net/mlx5: Add command entry handling completion","version":1,"mbox":"http://patchwork.ozlabs.org/series/178808/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1296571/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1296571/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming-netdev@ozlabs.org","Delivered-To":"patchwork-incoming-netdev@ozlabs.org","Authentication-Results":["ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=netdev-owner@vger.kernel.org; receiver=)","ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=mellanox.com","ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.a=rsa-sha256\n header.s=selector1 header.b=eKtjRd/G;\n\tdkim-atps=neutral","davemloft.net; dkim=none (message not signed)\n header.d=none;davemloft.net; dmarc=none action=none header.from=mellanox.com;"],"Received":["from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 49TPgJ25xkz9sRY\n\tfor ;\n Sat, 23 May 2020 10:41:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S2387493AbgEWAlb (ORCPT\n );\n Fri, 22 May 2020 20:41:31 -0400","from mail-eopbgr70075.outbound.protection.outlook.com\n ([40.107.7.75]:1415\n \"EHLO EUR04-HE1-obe.outbound.protection.outlook.com\"\n rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n id S2387484AbgEWAla (ORCPT );\n Fri, 22 May 2020 20:41:30 -0400","from VI1PR05MB5102.eurprd05.prod.outlook.com (2603:10a6:803:5e::23)\n by VI1PR05MB5391.eurprd05.prod.outlook.com (2603:10a6:803:95::25) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24; Sat, 23 May\n 2020 00:41:18 +0000","from VI1PR05MB5102.eurprd05.prod.outlook.com\n ([fe80::2405:4594:97a:13c]) by VI1PR05MB5102.eurprd05.prod.outlook.com\n ([fe80::2405:4594:97a:13c%2]) with mapi id 15.20.3021.026; Sat, 23 May 2020\n 00:41:17 +0000","from smtp.office365.com (73.15.39.150) by\n BYAPR08CA0042.namprd08.prod.outlook.com (2603:10b6:a03:117::19) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend\n Transport; Sat, 23 May 2020 00:41:16 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=n0nzwuSgP/3Y4yHpkiS8ilKrz1CjEGzvpfS4B8BML1Pfe23Yngn0tXU4FIaY/sKj3KiXTfCM7aBGDnMFebD7y3Pl67kszA0F2VuffcrSxtFfwUJyBpE9zYksS2Ctqf4SVsE62Jry+FQTk0nBFJvbaRnpvwCF58d07j9KHFwf1ffwPPxztHsLuTFwARq8Tg1nc/qADB4Rejlldi8bVXpzMMYdU0E+7SJIGL0TaYqkUXBS+t+Vrx9QnyIdi/69YcXgcMfrYfnc9LtJEb0CWTFipFPJfdX73yCLcaxz2meDyNeMOsrzoEs17Oq+4mYfcA2H8UomwbIunUNB2/rJE65o4Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AXSUdohoApKl2kx2/Wmz0//oLVkqZuDgXhLcuRJvKdY=;\n b=IO7GizsGqlpHJ5ordDtd8a7iuQMNwOv92dQLQ9j2H/oaWc3elQMBFvXHfCeBdTHp5BHV1sKffZa0fk1cB94MQkyxv/WYmGayFK+dLxc1an76KhvkYyyuSbh2BLfF08P87VMecocHjNs6+l9cd8YRqsTlutdFJZsguMVTtqWvOwu3i8gQLzMe62FIJ8Xaq/B3aYD8vQPVXfrYCL+PI/pOCgITV/zW6LwdQhg/eJFhu07Gjxgf7xnNYZQp/H9iFzrL2v0ZVP87BFETuiXnSk/uSokYeQs/ZtxeMArUot/8IdbPviY1cOe/u+0pMEKUPvmelpqK1sWFD/jCRnmp4GIoww==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AXSUdohoApKl2kx2/Wmz0//oLVkqZuDgXhLcuRJvKdY=;\n b=eKtjRd/G8jN6quYbOPY7+LOGPpO7iNDZvvAmAsgNXqE45mbn1gJc/vghs3rwAPITqnqOjhgSfalxX9YdvzM8dfSXdRuZbQuGCC6JCBu1YY+hz7IY46Sc2ei/6UdyltXo05Mo/qZumLWaZd+q2ICpBVjD05mJE1JWntNbpCPMxbs=","From":"Saeed Mahameed ","To":"\"David S. Miller\" , kuba@kernel.org","Cc":"netdev@vger.kernel.org, Tariq Toukan ,\n Boris Pismenny ,\n Saeed Mahameed ","Subject":"[net 05/13] net/mlx5e: kTLS,\n Destroy key object after destroying the TIS","Date":"Fri, 22 May 2020 17:40:41 -0700","Message-Id":"<20200523004049.34832-6-saeedm@mellanox.com>","X-Mailer":["git-send-email 2.25.4","git-send-email 2.25.4"],"In-Reply-To":"<20200523004049.34832-1-saeedm@mellanox.com>","References":"<20200523004049.34832-1-saeedm@mellanox.com>","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"BYAPR08CA0042.namprd08.prod.outlook.com\n (2603:10b6:a03:117::19) To VI1PR05MB5102.eurprd05.prod.outlook.com\n (2603:10a6:803:5e::23)","MIME-Version":"1.0","X-MS-Exchange-MessageSentRepresentingType":"1","X-Originating-IP":"[73.15.39.150]","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-HT":"Tenant","X-MS-Office365-Filtering-Correlation-Id":"9d4e70ff-9118-4271-6b33-08d7feb20143","X-MS-TrafficTypeDiagnostic":"VI1PR05MB5391:","X-MS-Exchange-Transport-Forked":"True","X-Microsoft-Antispam-PRVS":"\n ","X-MS-Oob-TLC-OOBClassifiers":"OLM:86;","X-Forefront-PRVS":"0412A98A59","X-MS-Exchange-SenderADCheck":"1","X-Microsoft-Antispam":"BCL:0;","X-Microsoft-Antispam-Message-Info":"\n 4z4LhdX4TC3kdC/gpRpkS4hhxRXBsCN319egISOO+uqDDdwc6T5zfN1NYgK8vX140J83TrvqkvDkFxMoBEreeXlQ5cD5hWkdJrq5O9OYMfi2GWGYDQ+u4JQMFA26VkkrZCmzVH815zr4MIfmjkAlRys14v4pBCJkmXyx1b8TAOBLrIgJijxl0GSKzXcQcUbUd7wakKr7RFGuC19k0TT8u7OXmiZZytZsvNBUNVIS7xaCaVzuuKZpWHkusE9yqxe4TsG3i6afUciYkgeC61fDKz6hxuJoTDi+U9mQtZgzTfkAQjA4g6RcyFsWiMFaBixX1QMDC15AMt6+u74bC8IVnSN5PlJ6OwMV68laKue/JJ/RvivBUQaxUBlgjOuGd+GT","X-Forefront-Antispam-Report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR05MB5102.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(366004)(396003)(39860400002)(136003)(1076003)(8676002)(2616005)(956004)(4326008)(52116002)(186003)(26005)(16526019)(478600001)(6666004)(86362001)(6506007)(6512007)(107886003)(36756003)(316002)(5660300002)(8936002)(6486002)(66946007)(54906003)(66476007)(2906002)(66556008)(54420400002);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData":"\n uog7olrfe9VYfmFsm59rQ+wgrcHy0eIq2oFxErsYjfNSJ4udryz/tALaShcGw1BkxrkmOLpz7HoOQGELyjuwkQTh4m9bdD47iLohu2KeVytKAkPpmKYRDAJVKijdW2Ek8rjOV7nlrlsNo1QmljAPk3sn8ZS0fqNeKZ5M5ttdGWKvxHqjlHGRyBr2qfS59qt3byCzyuEYMyB8D0i0tGfjsQqHnMQI26zgjZZaAVbaIkA7t3LpHStJkhynH0nUVh5Cp1dU5wxoTjrNHXtg0T0I14clyBckaS3+nCrzDm5+9AEMyE7ltWr1cUJ5MnSlEpD2lflXV6erGpvdmeUjaHL6bavhQSEmj5Nh/iaoJAOhDEBe9P/AV1vMutZQIGRDAdx1AKw6i91/liWFwlFmyf9n+qZ7LVNREM7Z/P3wZ7cyZra08WNluszpX5BdkuKNEMj1Qvp1n+SKvsvoyY96DzO+a11y1SA+JS3z2Xq7ye44fAU=","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 9d4e70ff-9118-4271-6b33-08d7feb20143","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"23 May 2020 00:41:17.8891\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n azv/8ff5MDyKXx3+pYrYSQ8tDNxMLIT3g+TnmK7vhOvJ/WRiPIM3lBKixO8BCNBKj0Cc45JE5GFGRP/4+OsX7Q==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR05MB5391","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"From: Tariq Toukan \n\nThe TLS TIS object contains the dek/key ID.\nBy destroying the key first, the TIS would contain an invalid\nnon-existing key ID.\nReverse the destroy order, this also acheives the desired assymetry\nbetween the destroy and the create flows.\n\nFixes: d2ead1f360e8 (\"net/mlx5e: Add kTLS TX HW offload support\")\nSigned-off-by: Tariq Toukan \nReviewed-by: Boris Pismenny \nSigned-off-by: Saeed Mahameed \n---\n drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c\nindex 46725cd743a3..7d1985fa0d4f 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c\n@@ -69,8 +69,8 @@ static void mlx5e_ktls_del(struct net_device *netdev,\n \tstruct mlx5e_ktls_offload_context_tx *tx_priv =\n \t\tmlx5e_get_ktls_tx_priv_ctx(tls_ctx);\n \n-\tmlx5_ktls_destroy_key(priv->mdev, tx_priv->key_id);\n \tmlx5e_destroy_tis(priv->mdev, tx_priv->tisn);\n+\tmlx5_ktls_destroy_key(priv->mdev, tx_priv->key_id);\n \tkvfree(tx_priv);\n }\n \n","prefixes":["net","05/13"]}