{"id":1238816,"url":"http://patchwork.ozlabs.org/api/patches/1238816/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/20200216193005.144157-10-jolsa@kernel.org/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20200216193005.144157-10-jolsa@kernel.org>","list_archive_url":null,"date":"2020-02-16T19:29:56","name":"[09/18] bpf: Add bpf_ksym_add/del functions","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"6b22965c77153621db36db4e6d12c505aa3810a3","submitter":{"id":73687,"url":"http://patchwork.ozlabs.org/api/people/73687/?format=json","name":"Jiri Olsa","email":"jolsa@kernel.org"},"delegate":{"id":77147,"url":"http://patchwork.ozlabs.org/api/users/77147/?format=json","username":"bpf","first_name":"BPF","last_name":"Maintainers","email":"bpf@iogearbox.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/20200216193005.144157-10-jolsa@kernel.org/mbox/","series":[{"id":158829,"url":"http://patchwork.ozlabs.org/api/series/158829/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=158829","date":"2020-02-16T19:29:47","name":"bpf: Add trampoline and dispatcher to /proc/kallsyms","version":1,"mbox":"http://patchwork.ozlabs.org/series/158829/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1238816/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1238816/checks/","tags":{},"related":[],"headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming-netdev@ozlabs.org","Delivered-To":"patchwork-incoming-netdev@ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (no SPF record)\n\tsmtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67;\n\thelo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 48LHKT6csMz9sP7\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n\tMon, 17 Feb 2020 06:31:09 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1727891AbgBPTbJ convert rfc822-to-8bit (ORCPT\n\t<rfc822;patchwork-incoming-netdev@ozlabs.org>);\n\tSun, 16 Feb 2020 14:31:09 -0500","from us-smtp-1.mimecast.com ([205.139.110.61]:24677 \"EHLO\n\tus-smtp-delivery-1.mimecast.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1726719AbgBPTbI (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 16 Feb 2020 14:31:08 -0500","from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n\t[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n\tus-mta-368-88P8VVDbP9GWfOCtG5TvUA-1; Sun, 16 Feb 2020 14:31:05 -0500","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx01.redhat.com (Postfix) with ESMTPS id 07D6C8017CC;\n\tSun, 16 Feb 2020 19:31:03 +0000 (UTC)","from krava.redhat.com (ovpn-204-28.brq.redhat.com [10.40.204.28])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E8B598AC5B;\n\tSun, 16 Feb 2020 19:30:54 +0000 (UTC)"],"From":"Jiri Olsa <jolsa@kernel.org>","To":"Alexei Starovoitov <ast@kernel.org>,\n\tDaniel Borkmann <daniel@iogearbox.net>","Cc":"netdev@vger.kernel.org, bpf@vger.kernel.org, Andrii Nakryiko\n\t<andriin@fb.com>, Yonghong Song <yhs@fb.com>, Song Liu\n\t<songliubraving@fb.com>,         Martin KaFai Lau <kafai@fb.com>,\n\tJakub Kicinski <kuba@kernel.org>, David Miller <davem@redhat.com>,\n\t=?utf-8?b?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@intel.com>,\n\tJohn Fastabend <john.fastabend@gmail.com>, Jesper Dangaard Brouer\n\t<hawk@kernel.org>,         Arnaldo Carvalho de Melo <acme@redhat.com>","Subject":"[PATCH 09/18] bpf: Add bpf_ksym_add/del functions","Date":"Sun, 16 Feb 2020 20:29:56 +0100","Message-Id":"<20200216193005.144157-10-jolsa@kernel.org>","In-Reply-To":"<20200216193005.144157-1-jolsa@kernel.org>","References":"<20200216193005.144157-1-jolsa@kernel.org>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-MC-Unique":"88P8VVDbP9GWfOCtG5TvUA-1","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"kernel.org","Content-Type":"text/plain; charset=WINDOWS-1252","Content-Transfer-Encoding":"8BIT","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Adding bpf_ksym_add/del functions as locked version\nfor __bpf_ksym_add/del. It will be used in following\npatches for bpf_trampoline and bpf_dispatcher.\n\nSigned-off-by: Jiri Olsa <jolsa@kernel.org>\n---\n include/linux/bpf.h |  3 +++\n kernel/bpf/core.c   | 14 ++++++++++++++\n 2 files changed, 17 insertions(+)","diff":"diff --git a/include/linux/bpf.h b/include/linux/bpf.h\nindex 5d6649cdc3df..76934893bccf 100644\n--- a/include/linux/bpf.h\n+++ b/include/linux/bpf.h\n@@ -573,6 +573,9 @@ struct bpf_image {\n #define BPF_IMAGE_SIZE (PAGE_SIZE - sizeof(struct bpf_image))\n bool is_bpf_image_address(unsigned long address);\n void *bpf_image_alloc(void);\n+/* Called only from code, so there's no need for stubs. */\n+void bpf_ksym_add(struct bpf_ksym *ksym);\n+void bpf_ksym_del(struct bpf_ksym *ksym);\n #else\n static inline struct bpf_trampoline *bpf_trampoline_lookup(u64 key)\n {\ndiff --git a/kernel/bpf/core.c b/kernel/bpf/core.c\nindex f361cfdf8d9e..739bef60d868 100644\n--- a/kernel/bpf/core.c\n+++ b/kernel/bpf/core.c\n@@ -655,6 +655,13 @@ static void __bpf_ksym_add(struct bpf_ksym *ksym)\n \tlatch_tree_insert(&ksym->tnode, &bpf_ksym_tree, &bpf_ksym_tree_ops);\n }\n \n+void bpf_ksym_add(struct bpf_ksym *ksym)\n+{\n+\tspin_lock_bh(&bpf_lock);\n+\t__bpf_ksym_add(ksym);\n+\tspin_unlock_bh(&bpf_lock);\n+}\n+\n static void __bpf_ksym_del(struct bpf_ksym *ksym)\n {\n \tif (list_empty(&ksym->lnode))\n@@ -664,6 +671,13 @@ static void __bpf_ksym_del(struct bpf_ksym *ksym)\n \tlist_del_rcu(&ksym->lnode);\n }\n \n+void bpf_ksym_del(struct bpf_ksym *ksym)\n+{\n+\tspin_lock_bh(&bpf_lock);\n+\t__bpf_ksym_del(ksym);\n+\tspin_unlock_bh(&bpf_lock);\n+}\n+\n static bool bpf_prog_kallsyms_candidate(const struct bpf_prog *fp)\n {\n \treturn fp->jited && !bpf_prog_was_classic(fp);\n","prefixes":["09/18"]}