{"id":1019116,"url":"http://patchwork.ozlabs.org/api/patches/1019116/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1545989148-13582-27-git-send-email-aleksandar.markovic@rt-rk.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1545989148-13582-27-git-send-email-aleksandar.markovic@rt-rk.com>","list_archive_url":null,"date":"2018-12-28T09:25:33","name":"[PULL,26/41] disas: nanoMIPS: Rename the decoder of 'gpr4' gpr encoding type","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"0bfa3810efa6f886064b97ad501bc8a4c039ba92","submitter":{"id":68635,"url":"http://patchwork.ozlabs.org/api/people/68635/?format=json","name":"Aleksandar Markovic","email":"aleksandar.markovic@rt-rk.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/1545989148-13582-27-git-send-email-aleksandar.markovic@rt-rk.com/mbox/","series":[{"id":83742,"url":"http://patchwork.ozlabs.org/api/series/83742/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=83742","date":"2018-12-28T09:25:09","name":"[PULL,01/41] MAINTAINERS: target/mips: Add MIPS files under default-configs directory","version":1,"mbox":"http://patchwork.ozlabs.org/series/83742/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/1019116/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/1019116/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=rt-rk.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 43R1x15KM7z9s55\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 28 Dec 2018 20:43:33 +1100 (AEDT)","from localhost ([127.0.0.1]:57879 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1gcofz-0004wA-Ft\n\tfor incoming@patchwork.ozlabs.org; Fri, 28 Dec 2018 04:43:31 -0500","from eggs.gnu.org ([208.118.235.92]:48032)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1gcoPL-0000sI-3S\n\tfor qemu-devel@nongnu.org; Fri, 28 Dec 2018 04:27:15 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <aleksandar.markovic@rt-rk.com>) id 1gcoPD-0003Jo-GA\n\tfor qemu-devel@nongnu.org; Fri, 28 Dec 2018 04:26:19 -0500","from mx2.rt-rk.com ([89.216.37.149]:49284 helo=mail.rt-rk.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <aleksandar.markovic@rt-rk.com>)\n\tid 1gcoPC-00037D-OM\n\tfor qemu-devel@nongnu.org; Fri, 28 Dec 2018 04:26:11 -0500","from localhost (localhost [127.0.0.1])\n\tby mail.rt-rk.com (Postfix) with ESMTP id 3C36B1A2122;\n\tFri, 28 Dec 2018 10:25:56 +0100 (CET)","from rtrkw774-lin.domain.local (rtrkw774-lin.domain.local\n\t[10.10.13.43])\n\tby mail.rt-rk.com (Postfix) with ESMTPSA id 0089A1A2152;\n\tFri, 28 Dec 2018 10:25:55 +0100 (CET)"],"X-Virus-Scanned":"amavisd-new at rt-rk.com","From":"Aleksandar Markovic <aleksandar.markovic@rt-rk.com>","To":"qemu-devel@nongnu.org","Date":"Fri, 28 Dec 2018 10:25:33 +0100","Message-Id":"<1545989148-13582-27-git-send-email-aleksandar.markovic@rt-rk.com>","X-Mailer":"git-send-email 2.7.4","In-Reply-To":"<1545989148-13582-1-git-send-email-aleksandar.markovic@rt-rk.com>","References":"<1545989148-13582-1-git-send-email-aleksandar.markovic@rt-rk.com>","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"89.216.37.149","Subject":"[Qemu-devel] [PULL 26/41] disas: nanoMIPS: Rename the decoder of\n\t'gpr4' gpr encoding type","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"peter.maydell@linaro.org, amarkovic@wavecomp.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"},"content":"From: Aleksandar Markovic <amarkovic@wavecomp.com>\n\nRename the decoder of 'gpr4' gpr encoding type in nanoMIPS\ndisassembler.\n\nReviewed-by: Aleksandar Rikalo <arikalo@wavecomp.com>\nSigned-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>\n---\n disas/nanomips.cpp | 20 ++++++++++----------\n disas/nanomips.h   |  2 +-\n 2 files changed, 11 insertions(+), 11 deletions(-)","diff":"diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp\nindex 1c313f3..5f6c93c 100644\n--- a/disas/nanomips.cpp\n+++ b/disas/nanomips.cpp\n@@ -406,7 +406,7 @@ uint64 NMD::encode_gpr4_zero(uint64 d)\n }\n \n \n-uint64 NMD::encode_gpr4(uint64 d)\n+uint64 NMD::decode_gpr_gpr4(uint64 d)\n {\n     static uint64 register_list[] = {  8,  9, 10, 11,  4,  5,  6,  7,\n                                       16, 17, 18, 19, 20, 21, 22, 23 };\n@@ -2363,8 +2363,8 @@ std::string NMD::ADDU_4X4_(uint64 instruction)\n     uint64 rt4_value = extract_rt4_9_7_6_5(instruction);\n     uint64 rs4_value = extract_rs4_4_2_1_0(instruction);\n \n-    std::string rs4 = GPR(encode_gpr4(rs4_value));\n-    std::string rt4 = GPR(encode_gpr4(rt4_value));\n+    std::string rs4 = GPR(decode_gpr_gpr4(rs4_value));\n+    std::string rt4 = GPR(decode_gpr_gpr4(rt4_value));\n \n     return img::format(\"ADDU %s, %s\", rs4, rt4);\n }\n@@ -9046,9 +9046,9 @@ std::string NMD::LW_4X4_(uint64 instruction)\n     uint64 rs4_value = extract_rs4_4_2_1_0(instruction);\n     uint64 u_value = extract_u_3_8__s2(instruction);\n \n-    std::string rt4 = GPR(encode_gpr4(rt4_value));\n+    std::string rt4 = GPR(decode_gpr_gpr4(rt4_value));\n     std::string u = IMMEDIATE(copy(u_value));\n-    std::string rs4 = GPR(encode_gpr4(rs4_value));\n+    std::string rs4 = GPR(decode_gpr_gpr4(rs4_value));\n \n     return img::format(\"LW %s, %s(%s)\", rt4, u, rs4);\n }\n@@ -10419,8 +10419,8 @@ std::string NMD::MOVEP_REV_(uint64 instruction)\n     uint64 rd2_value = extract_rd2_3_8(instruction);\n     uint64 rs4_value = extract_rs4_4_2_1_0(instruction);\n \n-    std::string rs4 = GPR(encode_gpr4(rs4_value));\n-    std::string rt4 = GPR(encode_gpr4(rt4_value));\n+    std::string rs4 = GPR(decode_gpr_gpr4(rs4_value));\n+    std::string rt4 = GPR(decode_gpr_gpr4(rt4_value));\n     std::string rd2 = GPR(encode_rd2_reg1(rd2_value));\n     std::string rs2 = GPR(encode_rd2_reg2(rd2_value));\n     /* !!!!!!!!!! - no conversion function */\n@@ -10985,8 +10985,8 @@ std::string NMD::MUL_4X4_(uint64 instruction)\n     uint64 rt4_value = extract_rt4_9_7_6_5(instruction);\n     uint64 rs4_value = extract_rs4_4_2_1_0(instruction);\n \n-    std::string rs4 = GPR(encode_gpr4(rs4_value));\n-    std::string rt4 = GPR(encode_gpr4(rt4_value));\n+    std::string rs4 = GPR(decode_gpr_gpr4(rs4_value));\n+    std::string rt4 = GPR(decode_gpr_gpr4(rt4_value));\n \n     return img::format(\"MUL %s, %s\", rs4, rt4);\n }\n@@ -15264,7 +15264,7 @@ std::string NMD::SW_4X4_(uint64 instruction)\n \n     std::string rtz4 = GPR(encode_gpr4_zero(rtz4_value));\n     std::string u = IMMEDIATE(copy(u_value));\n-    std::string rs4 = GPR(encode_gpr4(rs4_value));\n+    std::string rs4 = GPR(decode_gpr_gpr4(rs4_value));\n \n     return img::format(\"SW %s, %s(%s)\", rtz4, u, rs4);\n }\ndiff --git a/disas/nanomips.h b/disas/nanomips.h\nindex 757915c..109b131 100644\n--- a/disas/nanomips.h\n+++ b/disas/nanomips.h\n@@ -109,7 +109,7 @@ private:\n     uint64 decode_gpr_gpr3_src_store(uint64 d);\n     uint64 encode_rd1_from_rd(uint64 d);\n     uint64 encode_gpr4_zero(uint64 d);\n-    uint64 encode_gpr4(uint64 d);\n+    uint64 decode_gpr_gpr4(uint64 d);\n     uint64 encode_rd2_reg1(uint64 d);\n     uint64 encode_rd2_reg2(uint64 d);\n \n","prefixes":["PULL","26/41"]}