{"id":818201,"url":"http://patchwork.ozlabs.org/api/covers/818201/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20170925112917.21340-1-dgilbert@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170925112917.21340-1-dgilbert@redhat.com>","list_archive_url":null,"date":"2017-09-25T11:29:11","name":"[v2,0/6] migration: let pre_save fail","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/?format=json","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20170925112917.21340-1-dgilbert@redhat.com/mbox/","series":[{"id":4941,"url":"http://patchwork.ozlabs.org/api/series/4941/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4941","date":"2017-09-25T11:29:11","name":"migration: let pre_save fail","version":2,"mbox":"http://patchwork.ozlabs.org/series/4941/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/818201/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y122027DYz9t67\n\tfor ;\n\tMon, 25 Sep 2017 21:30:16 +1000 (AEST)","from localhost ([::1]:41789 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwRaX-0007wR-Vw\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 07:30:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59798)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwRZp-0007wL-4T\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:29:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwRZl-0001z4-VM\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:29:29 -0400","from mx1.redhat.com ([209.132.183.28]:50134)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwRZl-0001yg-N4\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 07:29:25 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C089285547;\n\tMon, 25 Sep 2017 11:29:24 +0000 (UTC)","from dgilbert-t530.redhat.com (ovpn-116-100.ams2.redhat.com\n\t[10.36.116.100])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BB36D60494;\n\tMon, 25 Sep 2017 11:29:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C089285547","From":"\"Dr. David Alan Gilbert (git)\" ","To":"qemu-devel@nongnu.org, quintela@redhat.com, peterx@redhat.com,\n\tfamz@redhat.com","Date":"Mon, 25 Sep 2017 12:29:11 +0100","Message-Id":"<20170925112917.21340-1-dgilbert@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tMon, 25 Sep 2017 11:29:24 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2 0/6] migration: let pre_save fail","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, cohuck@redhat.com, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"From: \"Dr. David Alan Gilbert\" \n\nAt the moment the pre-save method on VMStateDescription returns void\nwhich means there's no sane way of a pre_save routine failing. There\nare quite a few pre_save's that abort or do other nasty things, and it\nwould be better if they could fail cleanly.\n\nThis patch series doesn't fix any of those pre_save's - it just changes\npre_save to return an error value and routes that back up so the\nmigration fails. I'll leave that up to the individual device owners.\n\nThere are a bunch of corner cases that I've not fixed yet; these are\nmostly places that call vmstate_save_state which have been partially\nconverted to modern migration code; often the functions they're called\nfrom return void as well - they can get fixed later.\n\nSigned-off-by: Dr. David Alan Gilbert \n\nv2\n test: Split assert/side effects [Fam]\n new patch 3: Changed to also check the return of the ->put methods\n that should have been checked previously. [Peter]\n\nDr. David Alan Gilbert (6):\n migration: pre_save return int\n migration: check pre_save return in vmstate_save_state\n migration: Check field save returns\n migration: wire vmstate_save_state errors up to\n vmstate_subsection_save\n migration: Route errors up through vmstate_save\n migration: Route more error paths\n\n docs/devel/migration.txt | 2 +-\n hw/arm/pxa2xx.c | 4 +++-\n hw/arm/strongarm.c | 4 +++-\n hw/audio/wm8750.c | 4 +++-\n hw/block/fdc.c | 4 +++-\n hw/block/m25p80.c | 4 +++-\n hw/block/nand.c | 4 +++-\n hw/block/onenand.c | 4 +++-\n hw/char/serial.c | 4 +++-\n hw/display/qxl.c | 4 +++-\n hw/display/virtio-gpu.c | 4 +---\n hw/i2c/core.c | 4 +++-\n hw/i386/kvm/clock.c | 4 +++-\n hw/ide/core.c | 4 +++-\n hw/ide/pci.c | 4 +++-\n hw/input/ps2.c | 8 ++++++--\n hw/input/tsc210x.c | 4 +++-\n hw/intc/apic_common.c | 4 +++-\n hw/intc/arm_gic_common.c | 4 +++-\n hw/intc/arm_gicv3_common.c | 4 +++-\n hw/intc/arm_gicv3_its_common.c | 4 +++-\n hw/intc/i8259_common.c | 4 +++-\n hw/intc/ioapic_common.c | 4 +++-\n hw/intc/s390_flic_kvm.c | 6 ++++--\n hw/intc/xics.c | 8 ++++++--\n hw/net/e1000.c | 4 +++-\n hw/net/e1000e.c | 4 +++-\n hw/net/rtl8139.c | 4 +++-\n hw/net/virtio-net.c | 16 ++++++++++++----\n hw/net/vmxnet3.c | 4 +++-\n hw/pci-host/piix.c | 4 +++-\n hw/ppc/ppc.c | 4 +++-\n hw/ppc/spapr_iommu.c | 4 +++-\n hw/ppc/spapr_pci.c | 6 ++++--\n hw/s390x/css.c | 10 +++++++---\n hw/s390x/virtio-ccw.c | 4 +++-\n hw/scsi/lsi53c895a.c | 4 +++-\n hw/scsi/vmw_pvscsi.c | 4 +++-\n hw/timer/cadence_ttc.c | 4 +++-\n hw/timer/hpet.c | 4 +++-\n hw/timer/i8254_common.c | 4 +++-\n hw/timer/mc146818rtc.c | 4 +++-\n hw/timer/pl031.c | 4 +++-\n hw/timer/twl92230.c | 4 +++-\n hw/usb/dev-smartcard-reader.c | 4 +++-\n hw/usb/hcd-ehci.c | 4 +++-\n hw/usb/redirect.c | 4 +++-\n hw/virtio/vhost-vsock.c | 4 +++-\n hw/virtio/virtio.c | 13 +++++++------\n include/hw/virtio/virtio.h | 2 +-\n include/migration/vmstate.h | 6 +++---\n migration/colo-comm.c | 4 +++-\n migration/global_state.c | 4 +++-\n migration/savevm.c | 23 ++++++++++++++++------\n migration/trace-events | 1 +\n migration/vmstate-types.c | 11 ++++++++---\n migration/vmstate.c | 43 +++++++++++++++++++++++++++++++-----------\n replay/replay-snapshot.c | 4 +++-\n slirp/slirp.c | 8 ++++++--\n target/arm/machine.c | 4 +++-\n target/i386/machine.c | 7 +++++--\n target/ppc/machine.c | 4 +++-\n target/s390x/machine.c | 4 +++-\n target/sparc/machine.c | 4 +++-\n tests/test-vmstate.c | 13 +++++++++----\n 65 files changed, 271 insertions(+), 104 deletions(-)"}