{"id":817526,"url":"http://patchwork.ozlabs.org/api/covers/817526/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20170922140237.10869-1-carenas@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170922140237.10869-1-carenas@gmail.com>","list_archive_url":null,"date":"2017-09-22T14:02:31","name":"[RFC,0/6] linux-user: refactor socket.h into architecture specific sockbits","submitter":{"id":72390,"url":"http://patchwork.ozlabs.org/api/people/72390/?format=json","name":"Carlo Arenas","email":"carenas@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20170922140237.10869-1-carenas@gmail.com/mbox/","series":[{"id":4635,"url":"http://patchwork.ozlabs.org/api/series/4635/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4635","date":"2017-09-22T14:02:31","name":"linux-user: refactor socket.h into architecture specific sockbits","version":1,"mbox":"http://patchwork.ozlabs.org/series/4635/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/817526/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Vgs6kHmh\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzFZh0y60z9sRW\n\tfor ;\n\tSat, 23 Sep 2017 00:03:55 +1000 (AEST)","from localhost ([::1]:59077 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvOYb-0006us-Pd\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 10:03:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53772)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvOXt-0006uR-AR\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:03:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvOXn-0001La-Qc\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:03:09 -0400","from mail-pf0-x230.google.com ([2607:f8b0:400e:c00::230]:44379)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dvOXn-0001K4-Kk\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 10:03:03 -0400","by mail-pf0-x230.google.com with SMTP id e1so609638pfk.1\n\tfor ; Fri, 22 Sep 2017 07:03:01 -0700 (PDT)","from localhost.localdomain (c-73-189-82-67.hsd1.ca.comcast.net.\n\t[73.189.82.67]) by smtp.gmail.com with ESMTPSA id\n\td124sm6428901pfc.42.2017.09.22.07.02.58\n\t(version=TLS1 cipher=AES128-SHA bits=128/128);\n\tFri, 22 Sep 2017 07:02:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=0117UuN5aoibw6YlbJQrJv+ZilTmjKzuZ3aPgRvXdto=;\n\tb=Vgs6kHmhdKWqD5UzrXmWcBNy4hmT0M6gGnDrXbgwi2qASd2nXGV7ug3Lll4R+0u9pe\n\tX+tqbtFry8bpnFX2RyV1FI5hiRsZcgJUp3mo1Dn5dMiGGV0v9VE1MpKxrUQEtITWG6I2\n\t5ZNbYJQhZWlgZWfW1rtaUZqYy8+Ljl9LIaNqdU5InbRsTqR0W7C3ucrgDauNk1Cyej/J\n\tZyw3jHQM5d1GS3iqNSGap9ty2mpsry4+GVVLvpnoB2o7TJOwBWcvN4Fil9vXyhCZtZuO\n\tjavPsnWG6GFq772CAHyVZrHCIuAanjNZrDb18644SczRmgVGYrACx82VpUi+LovGMoUm\n\tGsvQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=0117UuN5aoibw6YlbJQrJv+ZilTmjKzuZ3aPgRvXdto=;\n\tb=XI+v4mD4eahAyxJOrJzC7aHSgkX4cgH3T8Z9UvU8hy/+WqjpJMvaJD3u/WUvIibIUY\n\tSsLnd+wQuHWEv/mhdgT7PFO0IpUf3Pz/X3MDIjwbCUMizXeKlyy7RCnTNuIPqOpdCWXY\n\tr04pskm9Y2pYuLuL+X2y+DvPUkGuofDmxnRA6WF86RgGGxZUFgTRn+iX6Pje1cb7F3mH\n\tTYK71SVmDpe1u71q2zAZrJzbqO6ark+lXstvZ3lB8apI4DuKmPWaq4wDb+ddFksoCqlu\n\tdl8k7mBSxAd7BTjTJnkEGEwcAPmVpK6uNokUEsH2l7RghNu4/FzoHgO2ZJ6yJsJ1EmtO\n\tb6LQ==","X-Gm-Message-State":"AHPjjUgvD/H+/Ep+osIASvNdFOO3OVZyZTqOfXyQ33chpsjWVi5Hc1nt\n\tQKGhyMchjyjU5Eky5R9Cbgs7Zg==","X-Google-Smtp-Source":"AOwi7QAZOMT/J+m0KW0rBbledb6iN90quW3HAe2TVtCE8u4HK5cRNQXe77kc0yKC/Ydxl98MSBUHog==","X-Received":"by 10.98.78.79 with SMTP id c76mr9572103pfb.20.1506088979757;\n\tFri, 22 Sep 2017 07:02:59 -0700 (PDT)","From":"=?utf-8?q?Carlo_Marcelo_Arenas_Bel=C3=B3n?= ","To":"qemu-devel@nongnu.org","Date":"Fri, 22 Sep 2017 07:02:31 -0700","Message-Id":"<20170922140237.10869-1-carenas@gmail.com>","X-Mailer":"git-send-email 2.14.1","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::230","Subject":"[Qemu-devel] [RFC 0/6] linux-user: refactor socket.h into\n\tarchitecture specific sockbits","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"riku.voipio@iki.fi, laurent@vivier.eu, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"the definitions in socket.h are meant to reflect the ones in linux for each\nrespective target, but are sometimes difficult to maintain.\n\nhppa (AKA parisc) was initially merged with an independent file that mirrors\nmore closely the corresponding one in linux but hasn't been updated since.\n\nwhile testing what should had been a simple change (adding to setsockopt\nsupport for another SO flag) it became obvious that doing this refactor\nwould help making the code easier to understand and avoid hard to see bugs\n(like definitions set to the wrong target as shown for sparc at least)\n\nthe changes are somehow mechanical, and I had made an effort to try to identify\nwhat has changed (and hopefully fix a bug), but there is a high probability\nsomething as silly as a typo might have introduced a bug, therefore, testing\nfor each target is encouraged but not something I could do on my own (being\nnew to qemu-user and not having access to the corresponding sysroots)\n\nthe fact that it is most likely that most socket functions where not working\nfor sparc, sparc64, mips64 and ppc64 is most likely an indication that more\ntesting (and regressions) is likely needed around this, so suggestions and\nhelp on that is also needed."}