{"id":817452,"url":"http://patchwork.ozlabs.org/api/covers/817452/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/1506081825-14209-1-git-send-email-pradeep.jagadeesh@huawei.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1506081825-14209-1-git-send-email-pradeep.jagadeesh@huawei.com>","list_archive_url":null,"date":"2017-09-22T12:03:39","name":"[v12,0/6] fsdev: qmp interface for io throttling","submitter":{"id":69852,"url":"http://patchwork.ozlabs.org/api/people/69852/?format=json","name":"Pradeep Jagadeesh","email":"pradeepkiruvale@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/1506081825-14209-1-git-send-email-pradeep.jagadeesh@huawei.com/mbox/","series":[{"id":4607,"url":"http://patchwork.ozlabs.org/api/series/4607/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=4607","date":"2017-09-22T12:03:39","name":"fsdev: qmp interface for io throttling","version":12,"mbox":"http://patchwork.ozlabs.org/series/4607/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/817452/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"A/SDEECt\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzBxk4Gqjz9sPk\n\tfor ;\n\tFri, 22 Sep 2017 22:05:14 +1000 (AEST)","from localhost ([::1]:58478 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvMhk-0006Np-KP\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 08:05:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46747)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvMgx-0006Lz-NG\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:04:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvMgt-0004tG-PB\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:04:23 -0400","from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:33120)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvMgt-0004sp-Jz\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 08:04:19 -0400","by mail-wm0-x244.google.com with SMTP id m127so1100639wmm.0\n\tfor ; Fri, 22 Sep 2017 05:04:18 -0700 (PDT)","from localhost.localdomain.localdomain ([217.110.131.66])\n\tby smtp.gmail.com with ESMTPSA id\n\tv78sm2567133wmv.48.2017.09.22.05.04.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 05:04:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=xZyBfl9xw3XVwNpuIU+LETVy7kvxF+mBpRjSJG7mSE4=;\n\tb=A/SDEECt6gEk5IZ+BQJecoU4DTT10e7F0935X6gwYMYc3a43kRj+oiq3lWXdtgaw5z\n\tDlHa7yRjFvN7MF941KBM5i3L/ecDhOPIde7WDU7ZB2uEwWT8aK+v/cV/xf4NoloRXYRw\n\tj8vuLZRms3xnB8r1xrk9/nW9BrYKV387WI4ign8W+49o/wdHzIxHEsPnOdtbM+k8g+0S\n\tVTvzqX9GX7coyjg/SMbsXdpeNCOD6vLvfu5T9hdWyNBZWzn6fc4gESI18DK6O4JRGmlO\n\tLl8HiUCYMQo/XX9adOdYqVFpxdE99ATYOdJB6awVJmLeFsp79uWur8vJncXyFXPEF1lb\n\tiXLw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=xZyBfl9xw3XVwNpuIU+LETVy7kvxF+mBpRjSJG7mSE4=;\n\tb=kd7MSQjX6CfkOcf2A3piIr9bLwb3w9mEZk1Y7DsESW6dpEnYL8QzQ9IQZQtq6dEutZ\n\tFbboCbj1uvFG7jCS/rAa4Qkb7XBT4cBWIvTgGSiZw5i98xpo1B28Kox/nPu47lm9er0X\n\t2vdOa+2BG7jGwyqzYHlojhcxiRgipL34eHOKNyNefaBmUh4WB7va1dA0LDSawdWdhAiy\n\tThnLCdZGGmJkeJYP/ufwrOPIyL/Xt71wu9v/2wEcBueseyML0xH47HfEZfTAJ7SOTVfw\n\tMR3aAgeA1xk0vox/lE02Ru6d/gxsGU8KZuUiKwc4jtQjlYtsQ9kVoOcNvUwvdxAIlOeR\n\tCXuA==","X-Gm-Message-State":"AHPjjUhrHeCoyzjjy5aS1hlYx9x/hVTtEXdVqGqXiEwbPfWe+SfmmFrt\n\tnPwV3MmzKDXoF9ryNgP5ebs=","X-Google-Smtp-Source":"AOwi7QDE4VcP1dta0MiCnx+mHgIcbpvCi3bCT+smFqXD8aGBBpVU7wE42zGPM7Lkd9etAVfSXu2vJg==","X-Received":"by 10.28.148.203 with SMTP id w194mr3542343wmd.91.1506081857142; \n\tFri, 22 Sep 2017 05:04:17 -0700 (PDT)","From":"Pradeep Jagadeesh ","X-Google-Original-From":"Pradeep Jagadeesh ","To":"\"eric blake\" ,\n\t\"greg kurz\" ","Date":"Fri, 22 Sep 2017 08:03:39 -0400","Message-Id":"<1506081825-14209-1-git-send-email-pradeep.jagadeesh@huawei.com>","X-Mailer":"git-send-email 1.8.3.1","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::244","Subject":"[Qemu-devel] [PATCH v12 0/6] fsdev: qmp interface for io throttling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alberto garcia ,\n\tManos Pitsidianakis , qemu-devel@nongnu.org,\n\t\"Dr. David Alan Gilbert\" ,\n\tMarkus Armbruster ,\n\tPradeep Jagadeesh ,\n\tjani kokkonen ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"These patches provide the qmp interface, to query the io throttle \nstatus of the all fsdev devices that are present in a vm.\nalso, it provides an interface to set the io throttle parameters of a\nfsdev to a required value. Some of the patches also remove the\nduplicate code that was present in block and fsdev files. \n\nPradeep Jagadeesh (6):\n throttle: factor out duplicate code\n qmp: Use ThrottleLimits structure\n qmp: factor out throttle code to reuse code\n hmp: create a throttle initialization function for code reuse\n fsdev: QMP interface for throttling\n fsdev: hmp interface for throttling\n\n Makefile | 3 +-\n blockdev.c | 97 ++-------------------------\n fsdev/qemu-fsdev-dummy.c | 11 +++\n fsdev/qemu-fsdev-throttle.c | 144 ++++++++++++++++++++++++++--------------\n fsdev/qemu-fsdev-throttle.h | 9 ++-\n fsdev/qemu-fsdev.c | 30 +++++++++\n hmp-commands-info.hx | 18 +++++\n hmp-commands.hx | 19 ++++++\n hmp.c | 81 ++++++++++++++++++++--\n hmp.h | 4 ++\n include/qemu/throttle-options.h | 3 +\n include/qemu/throttle.h | 4 +-\n include/qemu/typedefs.h | 1 +\n monitor.c | 5 ++\n qapi-schema.json | 4 ++\n qapi/block-core.json | 75 +--------------------\n qapi/fsdev.json | 94 ++++++++++++++++++++++++++\n qmp.c | 14 ++++\n util/throttle.c | 52 +++++++++++++++\n 19 files changed, 444 insertions(+), 224 deletions(-)\n create mode 100644 qapi/fsdev.json\n\nv0 -> v1:\n Addressed comments from Eric Blake, Greg Kurz and Daniel P.Berrange\n Mainly renaming the functions and removing the redundant code.\n\nv1 -> v2:\n Addressed comments from Eric Blake and Greg Kurz.\n As per the suggestion I split the patches into smaller patches.\n Removed some more duplicate code.\n\nv2 -> v3:\n Addresssed comments from Alberto Garcia.\n Changed the comment from block to iothrottle in the iothrottle.json \n Added the dummy functions in qemu-fsdev-dummy.c to address the compilation\n issues that were observed.\n\nv3 -> v4:\n Addressed comments from Eric Blake and Greg Kurz\n Re-ordered the patches\n Added the dummy functions in qmp.c to address the cross compilation issues\n\nv4 -> v5:\n Addressed comments from Eric Blake and Greg Kurz\n Split the fsdev qmp patch into hmp and qmp related patches\n Moved the common functionalities to throttle.c instead of creating\n a new file\n\nv5 -> v6:\n Addressed comments from Greg Kurz and Markus Armbruster\n Split the commits to specific to hmp and throttle as suggested by Greg\n Moved ThrottleConfig typedef to qemu/typedefs.h\n Addressed compilation issue on FreeBSD by adding flags in qmp.c\n\nv6 -> v7:\n Addressed comments from Albert Garcia and Dr. David Alan Gilbert\n Fixed the hmp-commands-info.hx and hmp-commands.hx as per Dr. David's\n comments.\n Fixed the bug with the hmp fsdev_set_io_throttle and info fsdev_iothrottle \n\nv7 -> v8:\n Addressed comments from Markus Armbruster and Eric Blake\n Removed unwanted headers from qmp-fsdev-throttle.h\n\nv8 -> v9:\n Addressed comments from Markus Armbruster and Eric Blake\n Removed the iothrottle.json and pushed the iothrottle struct to\n block-core.json\n\nv9 -> v10:\n Addressed comments from Albert Garcia\n Fixed issue related to dynamically passing throttle configuration\n Removed some unused code\n\nv10 -> v11:\n Addressed the comments from Markus Armbruster and Eric Blake\n Rebased the patches over 2.10\n\nv11 -> v12:\n Addressed comments by Manos Pitsidiankis\n Moved back the device id to the fsdeviothrottle structure"}