{"id":815704,"url":"http://patchwork.ozlabs.org/api/covers/815704/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20170919165226.23022-1-marcandre.lureau@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170919165226.23022-1-marcandre.lureau@redhat.com>","list_archive_url":null,"date":"2017-09-19T16:51:59","name":"[v2,00/27] vhost-user-scsi: code clean-up","submitter":{"id":66774,"url":"http://patchwork.ozlabs.org/api/people/66774/?format=json","name":"Marc-André Lureau","email":"marcandre.lureau@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/20170919165226.23022-1-marcandre.lureau@redhat.com/mbox/","series":[{"id":3931,"url":"http://patchwork.ozlabs.org/api/series/3931/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3931","date":"2017-09-19T16:51:59","name":"vhost-user-scsi: code clean-up","version":2,"mbox":"http://patchwork.ozlabs.org/series/3931/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/815704/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxV3K3k59z9ryr\n\tfor ;\n\tWed, 20 Sep 2017 03:19:09 +1000 (AEST)","from localhost ([::1]:44236 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duMAt-0002qI-Je\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 13:19:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45762)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duLlF-00051v-D4\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 12:52:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duLlA-0001Cx-US\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 12:52:37 -0400","from mx1.redhat.com ([209.132.183.28]:37050)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duLlA-0001CN-Ls\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 12:52:32 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9500481DF1;\n\tTue, 19 Sep 2017 16:52:31 +0000 (UTC)","from localhost (ovpn-112-56.ams2.redhat.com [10.36.112.56])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2236B5C542;\n\tTue, 19 Sep 2017 16:52:27 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9500481DF1","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","To":"qemu-devel@nongnu.org","Date":"Tue, 19 Sep 2017 18:51:59 +0200","Message-Id":"<20170919165226.23022-1-marcandre.lureau@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 19 Sep 2017 16:52:31 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2 00/27] vhost-user-scsi: code clean-up","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, felipe@nutanix.com, changpeng.liu@intel.com,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\tf4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Hi,\n\nWhile reviewing vhost-user-blk, I realized a lot of code was based on\nvhost-user-scsi, and I found a number of improvements could be\nmade. As a result in this series, I tried to move common glib code in\nlibvhost-user-glib. (I originally made libvhost-user glib-free, so if\nexternal projects want to play with it, they don't have to depend on\nglib, for ex vhost-user-bridge doesn't use glib).\n\nI haven't done extensive testing, I tried to setup a LUN with help\nfrom https://fedoraproject.org/wiki/Scsi-target-utils_Quickstart_Guide, but\nthe guest says \"Unexpected response from lun 1 while scanning, scan\naborted\" (before or after the series). Help welcome!\n\nThanks\n\nv2:\n- patch 3, 25, 26 missing review\n- drop giochannel patch, use libvhost-user-glib helper instead\n- misc style changes\n- comments improvements\n- fix vus dependency on libvhost-user.a\n\nMarc-André Lureau (27):\n glib-compat: move G_SOURCE_CONTINUE/REMOVE there\n build-sys: fix libvhost-user.a build\n build-sys: make vhost-user-scsi depend on libvhost-user.a\n libvhost-user: drop dependency on glib\n libvhost-user: improve vu_queue_pop() doc\n vhost-user-scsi: use g_strdup()\n vhost-user-scsi: connect unix socket before allocating\n vhost-user-scsi: code style fixes\n vhost-user-scsi: use glib allocation\n vhost-user-scsi: glib calls that allocate don't return NULL\n vhost-user-scsi: also free the gtree\n vhost-user-scsi: remove vdev_scsi_find_by_vu()\n vhost-user-scsi: simplify unix path cleanup\n vhost-user-scsi: use NULL pointer\n vhost-user-scsi: assert() in iscsi_add_lun()\n vhost-user-scsi: remove vdev_scsi_add_iscsi_lun()\n vhost-user-scsi: remove VUS_MAX_LUNS\n vhost-user-scsi: remove unimplemented functions\n vhost-user-scsi: rename VUS types\n vhost-user-scsi: avoid use of iscsi_ namespace\n vhost-user-scsi: don't copy iscsi/scsi-lowlevel.h\n vhost-user-scsi: drop extra callback pointer\n vhost-user-scsi: simplify source handling\n vhost-user-scsi: use glib logging\n libvhost-user: add glib source helper\n vhost-user-scsi: use libvhost-user glib helper\n vhost-user-scsi: remove server_sock from VusDev\n\n contrib/libvhost-user/libvhost-user-glib.h | 32 ++\n contrib/libvhost-user/libvhost-user.h | 3 +-\n include/glib-compat.h | 7 +\n contrib/libvhost-user/libvhost-user-glib.c | 154 +++++++\n contrib/libvhost-user/libvhost-user.c | 29 +-\n contrib/vhost-user-scsi/vhost-user-scsi.c | 629 +++++------------------------\n Makefile | 5 +-\n Makefile.objs | 1 -\n contrib/libvhost-user/Makefile.objs | 2 +-\n tests/Makefile.include | 2 +-\n 10 files changed, 316 insertions(+), 548 deletions(-)\n create mode 100644 contrib/libvhost-user/libvhost-user-glib.h\n create mode 100644 contrib/libvhost-user/libvhost-user-glib.c"}