{"id":815030,"url":"http://patchwork.ozlabs.org/api/covers/815030/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/cover/1505752137-15522-1-git-send-email-jbacik@fb.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","list_archive_url":null,"date":"2017-09-18T16:28:54","name":"[0/3] fix reuseaddr regression","submitter":{"id":72383,"url":"http://patchwork.ozlabs.org/api/people/72383/?format=json","name":"Josef Bacik","email":"josef@toxicpanda.com"},"mbox":"http://patchwork.ozlabs.org/project/netdev/cover/1505752137-15522-1-git-send-email-jbacik@fb.com/mbox/","series":[{"id":3676,"url":"http://patchwork.ozlabs.org/api/series/3676/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/list/?series=3676","date":"2017-09-18T16:28:56","name":"fix reuseaddr regression","version":1,"mbox":"http://patchwork.ozlabs.org/series/3676/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/815030/comments/","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=toxicpanda-com.20150623.gappssmtp.com\n\theader.i=@toxicpanda-com.20150623.gappssmtp.com\n\theader.b=\"G+2DH12p\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xws1L2f2Pz9s7F\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 02:30:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756159AbdIRQ3I (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 18 Sep 2017 12:29:08 -0400","from mail-qt0-f170.google.com ([209.85.216.170]:51214 \"EHLO\n\tmail-qt0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754958AbdIRQ3G (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 18 Sep 2017 12:29:06 -0400","by mail-qt0-f170.google.com with SMTP id q4so1118248qtq.8\n\tfor <netdev@vger.kernel.org>; Mon, 18 Sep 2017 09:29:06 -0700 (PDT)","from localhost ([2606:a000:4381:1201:225:22ff:feb3:e51a])\n\tby smtp.gmail.com with ESMTPSA id\n\ts43sm5647994qta.31.2017.09.18.09.29.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 09:29:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=toxicpanda-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id;\n\tbh=fGlWiyxuhPVslVB7Xz2PdBQn7MnJY1mdhssn9i5amYQ=;\n\tb=G+2DH12pJbvfieQZJjxZoQSWh1bHnlVe7vykePTtF9rPQYNVWkPBAjK/8VqoycbT1g\n\tYZTsjZegOP9uBR8Ab2ENFVkbjLTscVZK4HFH9hYiKwk3lO6xVvosjjQ9neWggkjLwE+4\n\tM2dS0ds2CV3EN8kvXXMzca4hsKPVwXbggTDKMK3APowfwoRas/N370nOr6pCmqlRAltT\n\trOCLPwFJYITD0fVXLh2YBNUDLeTLWK/8JTsipiEwMM1uzGfdyZn6+Hqyxr2vkZ9AB4CK\n\tPE/setRMXlxJEMuQmFgOV0K20QKny2k/zd0rxCXyHB/zk5gwFqSwig6zsnGRSCDRttLA\n\tURsA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=fGlWiyxuhPVslVB7Xz2PdBQn7MnJY1mdhssn9i5amYQ=;\n\tb=C6AkS6r+miVPPPM8Nl5QE4fdMqE2NpmyVR0iGYHX7Tsjm5GEm/JLsIV7nmtrWYvOX0\n\tN1PeLMlKbA2Vqd5PuoyfeHJ60uOVU5Y67BLKdEJIAgxY4h9N+P+Aqr+n67kYADQRtr+B\n\tvxHxuUZfcMd/IiK6f0LF6Za69kZrfN/pw1k6wt/vDy8IAVGJ5mm2kklAzfwkE4yjgLpR\n\tCow2bS1hfIPaUuHDbx6cfmcaHrZf7PXOxz2mSWCMjP3xc28Vafz/FvA17/oCToTbHQ9p\n\tPGw6obQevNCAaI0qt3ZuJY8POjdwFxUAPm66+1t+WyH6bba91JUb5ZYfgBFa+UokxfeX\n\tqitA==","X-Gm-Message-State":"AHPjjUg1wydfLVflKORcHnSd493oUpUeGGU3t4a7BOPLtFsneVpZvoFU\n\t4L9gkbCWuqMDNi9H","X-Google-Smtp-Source":"AOwi7QCgCSHFvWzsoinsKTnHo4dxpAOEyIqiRwlLAkVYQ2jnueJY8gA4clNa5llsTfumR4VtwmbBvA==","X-Received":"by 10.200.25.47 with SMTP id t44mr2757139qtj.86.1505752145787;\n\tMon, 18 Sep 2017 09:29:05 -0700 (PDT)","From":"josef@toxicpanda.com","X-Google-Original-From":"jbacik@fb.com","To":"davem@davemloft.net, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, crobinso@redhat.com,\n\tlabbott@redhat.com, kernel-team@fb.com","Subject":"[PATCH 0/3] fix reuseaddr regression","Date":"Mon, 18 Sep 2017 12:28:54 -0400","Message-Id":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","X-Mailer":"git-send-email 2.7.4","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"},"content":"I introduced a regression when reworking the fastreuse port stuff that allows\nbind conflicts to occur once a reuseaddr socket successfully opens on an\nexisting tb.  The root cause is I reversed an if statement which caused us to\nset the tb as if there were no owners on the socket if there were, which\nobviously is not correct.\n\nDave I have follow up patches that will add a selftest for this case and I ran\nthe other reuseport related tests as well.  These need to go in pretty quickly\nas it breaks kvm, I've marked them for stable.  Sorry for the regression,\n\nJosef"}