{"id":814856,"url":"http://patchwork.ozlabs.org/api/covers/814856/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/1505729649-11943-1-git-send-email-mgamal@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505729649-11943-1-git-send-email-mgamal@redhat.com>","list_archive_url":null,"date":"2017-09-18T10:14:07","name":"[v3,0/2] x86_iommu: Fix segfault when starting on non-PCI machines","submitter":{"id":72367,"url":"http://patchwork.ozlabs.org/api/people/72367/?format=json","name":"Mohammed Gamal","email":"mgamal@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/1505729649-11943-1-git-send-email-mgamal@redhat.com/mbox/","series":[{"id":3615,"url":"http://patchwork.ozlabs.org/api/series/3615/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3615","date":"2017-09-18T10:14:07","name":"x86_iommu: Fix segfault when starting on non-PCI machines","version":3,"mbox":"http://patchwork.ozlabs.org/series/3615/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/814856/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mgamal@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwhhn2jXjz9ryr\n\tfor ;\n\tMon, 18 Sep 2017 20:15:21 +1000 (AEST)","from localhost ([::1]:35571 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtt5D-0003PK-Eu\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 06:15:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40963)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtt4d-0003NS-7D\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:14:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtt4X-0002r1-Ni\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:14:43 -0400","from mx1.redhat.com ([209.132.183.28]:41234)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtt4X-0002qb-J5\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:14:37 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C42E6883BA\n\tfor ; Mon, 18 Sep 2017 10:14:35 +0000 (UTC)","from mmorsy.remote.csb (unknown [10.40.205.53])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5AC495D6A8;\n\tMon, 18 Sep 2017 10:14:23 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C42E6883BA","From":"Mohammed Gamal ","To":"qemu-devel@nongnu.org","Date":"Mon, 18 Sep 2017 12:14:07 +0200","Message-Id":"<1505729649-11943-1-git-send-email-mgamal@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 18 Sep 2017 10:14:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v3 0/2] x86_iommu: Fix segfault when starting\n\ton non-PCI machines","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, ehabkost@redhat.com, mst@redhat.com, peterx@redhat.com,\n\tpbonzini@redhat.com, Mohammed Gamal ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"Starting qemu with\nqemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu\nleads to a segfault. The code assume PCI bus is present and\ntries to access the bus structure without checking.\n\nThe patch series moves the error checks from vtd_realize()\nand amdvi_realize() to the generic x86_iommu_realize() and\nadds a check for PCI bus presence.\n\nv2 --> v3:\n* Use PC_MACHINE macro directly\n\nMohammed Gamal (2):\n x86_iommu: Move machine check to x86_iommu_realize()\n x86_iommu: check if machine has PCI bus\n\n hw/i386/amd_iommu.c | 10 +---------\n hw/i386/intel_iommu.c | 10 +---------\n hw/i386/x86-iommu.c | 12 ++++++++++++\n 3 files changed, 14 insertions(+), 18 deletions(-)"}