{"id":813770,"url":"http://patchwork.ozlabs.org/api/covers/813770/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/cover/1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>","list_archive_url":null,"date":"2017-09-14T10:40:04","name":"[v11,0/6] fsdev: qmp interface for io throttling","submitter":{"id":69852,"url":"http://patchwork.ozlabs.org/api/people/69852/?format=json","name":"Pradeep Jagadeesh","email":"pradeepkiruvale@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/cover/1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com/mbox/","series":[{"id":3065,"url":"http://patchwork.ozlabs.org/api/series/3065/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=3065","date":"2017-09-14T10:40:06","name":"fsdev: qmp interface for io throttling","version":11,"mbox":"http://patchwork.ozlabs.org/series/3065/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/covers/813770/comments/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"WNBcwAX0\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtFWG4mv8z9sDB\n\tfor ;\n\tThu, 14 Sep 2017 20:43:38 +1000 (AEST)","from localhost ([::1]:46873 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsRcO-0000gy-Mp\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 06:43:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52195)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsRZi-0006q0-15\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 06:40:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsRZc-0001wo-VE\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 06:40:50 -0400","from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:37125)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsRZc-0001tf-4g\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 06:40:44 -0400","by mail-wm0-x242.google.com with SMTP id f4so2872766wmh.4\n\tfor ; Thu, 14 Sep 2017 03:40:42 -0700 (PDT)","from localhost.localdomain.localdomain ([217.110.131.66])\n\tby smtp.gmail.com with ESMTPSA id\n\tw14sm742801wmf.13.2017.09.14.03.40.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 14 Sep 2017 03:40:41 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=iCVioAAwRbeb1smdUoemRtB7YhIpZyOjgYuHNnz+i1k=;\n\tb=WNBcwAX0/5AVlWlXwHsgpUPGEKn87hPWu18ZriT1mLwjtgC2/ERr94810qJwvcjTsG\n\tp5oRwBoV2NFvlUybuPPIR4zvxNNURHPqXm+0A5RU4819JBBv1DNCj08AgoGjhar0lt2J\n\tHlVimSHCdF+1BxjR7JRM6Tg6cO7FfkGiqDD8rgE+InWxAnntbz3TAbMV171W9iC/n1fH\n\tsJ2F9qorJWQLvlvf7vORemVdus/Mw0f9fTBbKJeSylQR+zGXqbjCPrXgymWju5lA0Gi8\n\tI6pefeeYoQtbnnBPzSWUcxlmWUEmTgLaMPEKQsjgwFYBPO1jwfTLhL+Cu2OUmgzJIVE/\n\tb+bw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=iCVioAAwRbeb1smdUoemRtB7YhIpZyOjgYuHNnz+i1k=;\n\tb=uaAic7ZaEqqtU8nMvGq5TEXgf9pYk7D99TgIRLofrRseMr9DWJJpOBgFywCloKXRbN\n\tQRHmSSGJIozNG5ktBRa+H6cKYk4qhfNenEjEZkXmW44dAQxRuUtV/NDVkf35pI32+gLP\n\t0PN64CFtnLrZqphE+q/GoaAgBHoqT4FRJ3Eo84Rj2Tcue61kZCqNa/IXm+sq8exraCZW\n\tB6C7g+zeTVYFGg6D6+2Y29My6dPcpOR5zCxf00JvZRMDcuzXE8vpp4PxorBXHzk/KP5t\n\tf6gOcvEIxALvgn+nawQ6batCoHzYqpjihHmllwjELvgV5S9WFW2g6LtHsF5+FvH7UGDh\n\tKkGw==","X-Gm-Message-State":"AHPjjUiGtzbpym63sHMSwJ2E+NF8VEINr86BL15MkMmF+Ay7c6sVB8Dn\n\tlHRvypQxWR3iGg==","X-Google-Smtp-Source":"AOwi7QDB1oiwQ6jsLQZvlTjiQbleNECUpdbnI/r50YB29ywHqH5CZ4kNaoqML/x4EN42LixnTfYYGA==","X-Received":"by 10.28.98.5 with SMTP id w5mr1565974wmb.51.1505385641572;\n\tThu, 14 Sep 2017 03:40:41 -0700 (PDT)","From":"Pradeep Jagadeesh ","X-Google-Original-From":"Pradeep Jagadeesh ","To":"\"eric blake\" ,\n\t\"greg kurz\" ","Date":"Thu, 14 Sep 2017 06:40:04 -0400","Message-Id":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>","X-Mailer":"git-send-email 1.8.3.1","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::242","Subject":"[Qemu-devel] [PATCH v11 0/6] fsdev: qmp interface for io throttling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alberto garcia , Markus Armbruster ,\n\tqemu-devel@nongnu.org, \"Dr. David Alan Gilbert\" ,\n\tPradeep Jagadeesh ,\n\tjani kokkonen ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"These patches provide the qmp interface, to query the io throttle \nstatus of the all fsdev devices that are present in a vm.\nalso, it provides an interface to set the io throttle parameters of a\nfsdev to a required value. Some of the patches also remove the\nduplicate code that was present in block and fsdev files. \n\nPradeep Jagadeesh (6):\n throttle: factor out duplicate code\n qmp: Use ThrottleLimits structure\n qmp: factor out throttle code to reuse code\n hmp: create a throttle initialization function for code reuse\n fsdev: QMP interface for throttling\n fsdev: hmp interface for throttling\n\n Makefile | 3 +-\n blockdev.c | 97 ++--------------------------\n fsdev/qemu-fsdev-dummy.c | 11 ++++\n fsdev/qemu-fsdev-throttle.c | 140 ++++++++++++++++++++++++++--------------\n fsdev/qemu-fsdev-throttle.h | 9 ++-\n fsdev/qemu-fsdev.c | 30 +++++++++\n hmp-commands-info.hx | 18 ++++++\n hmp-commands.hx | 19 ++++++\n hmp.c | 79 +++++++++++++++++++++--\n hmp.h | 4 ++\n include/qemu/throttle-options.h | 3 +\n include/qemu/throttle.h | 4 +-\n include/qemu/typedefs.h | 1 +\n monitor.c | 5 ++\n qapi-schema.json | 4 ++\n qapi/block-core.json | 78 ++--------------------\n qapi/fsdev.json | 81 +++++++++++++++++++++++\n qmp.c | 14 ++++\n util/throttle.c | 52 +++++++++++++++\n 19 files changed, 426 insertions(+), 226 deletions(-)\n create mode 100644 qapi/fsdev.json\n\nv0 -> v1:\n Addressed comments from Eric Blake, Greg Kurz and Daniel P.Berrange\n Mainly renaming the functions and removing the redundant code.\n\nv1 -> v2:\n Addressed comments from Eric Blake and Greg Kurz.\n As per the suggestion I split the patches into smaller patches.\n Removed some more duplicate code.\n\nv2 -> v3:\n Addresssed comments from Alberto Garcia.\n Changed the comment from block to iothrottle in the iothrottle.json \n Added the dummy functions in qemu-fsdev-dummy.c to address the compilation\n issues that were observed.\n\nv3 -> v4:\n Addressed comments from Eric Blake and Greg Kurz\n Re-ordered the patches\n Added the dummy functions in qmp.c to address the cross compilation issues\n\nv4 -> v5:\n Addressed comments from Eric Blake and Greg Kurz\n Split the fsdev qmp patch into hmp and qmp related patches\n Moved the common functionalities to throttle.c instead of creating\n a new file\n\nv5 -> v6:\n Addressed comments from Greg Kurz and Markus Armbruster\n Split the commits to specific to hmp and throttle as suggested by Greg\n Moved ThrottleConfig typedef to qemu/typedefs.h\n Addressed compilation issue on FreeBSD by adding flags in qmp.c\n\nv6 -> v7:\n Addressed comments from Albert Garcia and Dr. David Alan Gilbert\n Fixed the hmp-commands-info.hx and hmp-commands.hx as per Dr. David's\n comments.\n Fixed the bug with the hmp fsdev_set_io_throttle and info fsdev_iothrottle \n\nv7 -> v8:\n Addressed comments from Markus Armbruster and Eric Blake\n Removed unwanted headers from qmp-fsdev-throttle.h\n\nv8 -> v9:\n Addressed comments from Markus Armbruster and Eric Blake\n Removed the iothrottle.json and pushed the iothrottle struct to\n block-core.json\n\nv9 -> v10:\n Addressed comments from Albert Garcia\n Fixed issue related to dynamically passing throttle configuration\n Removed some unused code\n\nv10 -> v11:\n Addressed the comments from Markus Armbruster and Eric Blake\n Rebased the patches over 2.10"}